From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52AC0C433E2 for ; Thu, 3 Sep 2020 21:59:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18B9F20678 for ; Thu, 3 Sep 2020 21:59:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NrIYvumj"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="cfK1czkM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18B9F20678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hs0d8tP4QDQxXlirbEWhmDS/QGWfNi++KyiKyCQkYrE=; b=NrIYvumj1rsjP6uzHnTPI2DrL GazkP6e68uZNSgCA3uvOr0LQPPaKkCbWT4hsI5Eipzec/a9qWFhiv1WTMaVDI2W8K/Zq0n8NTJd8B PLXa1nLccPlaXNt0D+EZFOBOIdtRvsJSQlC3A6oPjQS3foqLzCuPWODHEsX7gsvg321ta2peM3K9D HGdXFHK0UNcUv/STQ+GRZ8ayMkffHdmUSh7lyPCJa3dFSKBh32EWurBwPnZOYnY5Y6TWftYYvvVaH 39cwpKpkNoP430YTlg+1kS1+KQNkmCGSEcGsgZR2pPMggbIRbyjYFwGLqhMENotBkfRtCXJL9pHQC YFh3pwUqw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDxFb-0004sm-HJ; Thu, 03 Sep 2020 21:58:35 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDxFY-0004rS-AB for linux-arm-kernel@lists.infradead.org; Thu, 03 Sep 2020 21:58:33 +0000 Received: by mail-pg1-x541.google.com with SMTP id d19so3180149pgl.10 for ; Thu, 03 Sep 2020 14:58:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zwlTSlngv7hk/k8joOBYJecRtutX3pQhWGRYHaQfHNc=; b=cfK1czkMgexKgeV+AniPDaw2RXSPRTJErK03aD3KyKL4Fgd4NeDHwP5V8Xl/FfVKCS 6F+iqqs9u11jyJ00qYjcMmLzcZHnV9wHK2dvI7ZXa7ITGd9X9E1vU0dh9lPkAo/o/+N9 ZlfpNW1hK+/ISGP4OP8u8wm5pAhXJBxxqUlTY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zwlTSlngv7hk/k8joOBYJecRtutX3pQhWGRYHaQfHNc=; b=Yj4QMzSB/eFmr1xhb4mc2RvPBee7+l2qNIkCdc3aFiIv69D0ova//JccZLDRXm4Bse Kv9bgMzWhN+XE+VYcUsB8PgRPhrtM3bhR4GqbrXDSSK9V/8eKBWxLHminWCLVD/x6lgJ cRnSMadQ/0U5ZUznBUEy4XNXAHDafX9C8h6dLjEPzpP5jJW2st7T/Y5w60qcwniJ/fHG snFT2NrzqccU3yQZ407Imc73NFNM3SMzE9+N4zBpD62Lf2kLJePAAu4YoEGwnnuzhIYf mbDMcBOVbAGTb/8J68fAIihd5GRJuIGZ+r2r/64w/Lkw9cDIPPywgjvnJd/d0PCxWMe+ qP4Q== X-Gm-Message-State: AOAM530hjHkH6VT1/SpwAGc3VWpvG+vL9sa0mca1uxi6ZX1r4snk0ALP Fk2ndtFj2Xyhr7wIIgrhQ6ZVAw== X-Google-Smtp-Source: ABdhPJxsSBaVqKQu0Depn8jVU89HVsiUUr1gbeyokvUp0RXsPEsXdBRA9MTk7ZF9gX6Cd/pjcZAmmw== X-Received: by 2002:a63:d70f:: with SMTP id d15mr4658855pgg.354.1599170310450; Thu, 03 Sep 2020 14:58:30 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id s198sm3638905pgc.4.2020.09.03.14.58.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 14:58:29 -0700 (PDT) Date: Thu, 3 Sep 2020 14:58:28 -0700 From: Kees Cook To: Sami Tolvanen Subject: Re: [PATCH v2 08/28] x86, build: use objtool mcount Message-ID: <202009031456.C058EC4@keescook> References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-9-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200903203053.3411268-9-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200903_175832_361981_2040EC2F X-CRM114-Status: GOOD ( 12.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, "Paul E. McKenney" , kernel-hardening@lists.openwall.com, Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild@vger.kernel.org, Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , clang-built-linux@googlegroups.com, linux-pci@vger.kernel.org, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 03, 2020 at 01:30:33PM -0700, Sami Tolvanen wrote: > Select HAVE_OBJTOOL_MCOUNT if STACK_VALIDATION is selected to use > objtool to generate __mcount_loc sections for dynamic ftrace with > Clang and gcc <5. > > Signed-off-by: Sami Tolvanen Am I right to understand that this fixes mcount for Clang generally (i.e. it's not _strictly_ related to LTO, though LTO depends on this change)? And does this mean mcount was working for gcc < 5? Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel