From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D747AC433E2 for ; Thu, 3 Sep 2020 22:30:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 939CE20716 for ; Thu, 3 Sep 2020 22:30:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QKQDh/Lj"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="KHsDbTkW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 939CE20716 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IN7h2Byt8TlmuvwdtqvIXapPWKShBERi2LpMOWdlToI=; b=QKQDh/LjdTONjxZ90TSRVnST8 uFDukrIrjZEI8YxTxrllcF07+sOEu1rriFoi4qgAUGMO61RckyhYS5NRCTy7qZbxZNqttXat9iy4m b6rjxrvsFP7z01K1loIpsyBZHOH/eyI/PB8qZfybw8ByckPV0P88uhe/P7U6pr22lyHIliOqgx9nJ O9T4J9JOTQmTFIOzefgZBgaC3gn4YRagndqU+9aDGjxiNffjwEPpvvMlwoUgXaycIrN2XFAMSemUA 2qcebmvYfdcJ1xOSRf7sVSoIdFTtgODaW+L/wzsItvm5hzh8v8yGoaBcvh773BLeZ/cQ9zWe5gvE3 c5dr/is9Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDxjT-0001Dm-Re; Thu, 03 Sep 2020 22:29:27 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDxjR-0001Ck-Kw for linux-arm-kernel@lists.infradead.org; Thu, 03 Sep 2020 22:29:26 +0000 Received: by mail-pg1-x541.google.com with SMTP id p37so3254316pgl.3 for ; Thu, 03 Sep 2020 15:29:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TORQKLjaztafBoTASZ16yvu7ARDRy50kM4Q1p96biak=; b=KHsDbTkWXmQI1RfBgYlEulerevLWOO1sRzFxAKb+aNgp895tLmEdR1w+6sTjCDCZIQ EuJ90PfQiTWeI7WLS02zfZZUzAc4XMY1Bk6zzL4EiQ37vuCk2BKlfRTd+vxSIXZp2XCf dIa1eEmzbBXCJesqA0svHofYBt8jl9vdhwQP4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TORQKLjaztafBoTASZ16yvu7ARDRy50kM4Q1p96biak=; b=QSZtq+Z9tCFkUbePtP+q2IgIcI8O00sxQn3M2ZNRkdGKVzTxoZw+U+Yzsj//rUM2Op W1IoQhObQZAjl8BVhWebYtsJQXIAzDdOIEiXax22CHTznkhtoSjP9SqcJalKmbCl4aXF aH2l91mNM73UsIDjgJx6t2MOJfzs92b+3RY1qzLjLjrFcXgt5FPM6SG1tHPjcDqG/Ic7 UqRFvTKzdyZhDjHWKPty0CpiCchTe88uwgNZknxKK1Hmepfo8BIHvXKfu+cfGDaryjuW 9PxPuOhcLRX+dMkEFbAybEND/kNhaPwRNz5pW96fXBAWvMPpZNkbs/5UX3okqXv+93+1 WySQ== X-Gm-Message-State: AOAM531YatxFwFMY2gD58VszyRIPDodD5NDSzpm0f6vCxO60DZLb6Tze WqrBsDYgiY8ctfPF6u5u46hm9A== X-Google-Smtp-Source: ABdhPJyg38PLw4/4AevyFkWAsUoEy3gRppS9+Cz/SI2Otq8bgnJU/k3kDNd4Q7TVX1+2h1rFxh2rAw== X-Received: by 2002:a63:344f:: with SMTP id b76mr4554312pga.388.1599172163775; Thu, 03 Sep 2020 15:29:23 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 64sm1588906pfg.98.2020.09.03.15.29.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 15:29:22 -0700 (PDT) Date: Thu, 3 Sep 2020 15:29:21 -0700 From: Kees Cook To: Sami Tolvanen Subject: Re: [PATCH v2 14/28] kbuild: lto: remove duplicate dependencies from .mod files Message-ID: <202009031529.78A2DE9D8@keescook> References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-15-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200903203053.3411268-15-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200903_182925_700716_1233A641 X-CRM114-Status: GOOD ( 15.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, "Paul E. McKenney" , kernel-hardening@lists.openwall.com, Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild@vger.kernel.org, Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , clang-built-linux@googlegroups.com, linux-pci@vger.kernel.org, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 03, 2020 at 01:30:39PM -0700, Sami Tolvanen wrote: > With LTO, llvm-nm prints out symbols for each archive member > separately, which results in a lot of duplicate dependencies in the > .mod file when CONFIG_TRIM_UNUSED_SYMS is enabled. When a module > consists of several compilation units, the output can exceed the > default xargs command size limit and split the dependency list to > multiple lines, which results in used symbols getting trimmed. > > This change removes duplicate dependencies, which will reduce the > probability of this happening and makes .mod files smaller and > easier to read. > > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel