From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48CE6C433E2 for ; Thu, 3 Sep 2020 22:43:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E531C20716 for ; Thu, 3 Sep 2020 22:43:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mHXFAAG5"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="GWCaNT3n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E531C20716 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JjrL1f2dcfcu0V3iAfkCuigfP5lSu+d0rUcGL1p9Co0=; b=mHXFAAG5gDZQW1/hEQ/GNJoIh 9k0eMpGgc0LATv9foToba3YzQVWITfaTHcSAkCv8N6qGPWxb2Jd8VankkyCn6BeSbTjk09hzl/w6U p6+7rEXKmgKZiRvV0QOCNMchlcg/IlO4FRtj+fukMHM6QTfrAZAJJeRvi0omuCvXNhu5Cpkce8Cdi U50BeV2rHeEEKZUeQ7zFZX3P7c1Ip+QjnopchZ8a5goe1DfQJoYxHr7jb2y22mG+y5oW0fpLm3ouA JVNjmbvI0xO7zMaYjexW5aUP5zAqpJWumMtOHevalOWF+5c8+hX4Jatd0IC1N7MSWNcwvHVxaHzTI Gg7R9BZkg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDxvW-00024P-NN; Thu, 03 Sep 2020 22:41:54 +0000 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDxvT-00023L-Q6 for linux-arm-kernel@lists.infradead.org; Thu, 03 Sep 2020 22:41:52 +0000 Received: by mail-pj1-x1043.google.com with SMTP id o16so2256555pjr.2 for ; Thu, 03 Sep 2020 15:41:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=t/oG9SCdq1xWr+ov4DXCG17oZgdOZVwWJcpUXXDNoEo=; b=GWCaNT3nM4fn50pBeGH+priah+inHtz/+o/HSxcFKJ+9g6L+7lcpaLmH1aFDCEt3sN cLNnfv5X6AEYL9NeIlpm/9yK+/MRS6sR6/uRRoPYye7RqP7/TVrQSHnggMT3tq9sR9hF zOPK2FA4z7TKMCX63xaseRtM1umBgGDIijy9M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=t/oG9SCdq1xWr+ov4DXCG17oZgdOZVwWJcpUXXDNoEo=; b=nY4l1CMmoOUDli7NXXayjb37b5koSK48ikxZ+178QBqWl5r5KH+ZhGDB1e87GpV26+ 65Bjj+L3gB1iDHK2aNyD8Ca9m/kF9Y1FqrbW0tixe1ivKHDNGEba3BzNptv2eKg/XL1V GUkPrxWLBO/BHAvEL1aiQEfW8hA1H4jfvA3+7PYDvi+qhIlSpRs9n2UyM6eNd7f4EqAg qIVw2fkQGdAGu1ooMSr0u28saeGivB9KKY2rRAW1pXy7nFNdOFCtL/Uc1zlrSTaHCPrh +hQCv/0d5f9R0giWAlKCnfIQgbA399qnN8GQC97ZSpb1FofVcJXo48CApipDz16bOGnb d03w== X-Gm-Message-State: AOAM530PnM6/iDs+4ffFPJCs+XcqoHjxawkoAH8PpKp4JVPtu58fYvE/ ZlW4dsGO8huz74G2WOU+72je0w== X-Google-Smtp-Source: ABdhPJzys++XSMZHn3WsTh+Gbvu5ZeD0Z5uwNitWJ8c9N8vmC+r+J+StAFQG3dzO4Nx2TrB3bIJMrw== X-Received: by 2002:a17:90a:f298:: with SMTP id fs24mr5478610pjb.4.1599172910026; Thu, 03 Sep 2020 15:41:50 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id i24sm3641252pfq.38.2020.09.03.15.41.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 15:41:48 -0700 (PDT) Date: Thu, 3 Sep 2020 15:41:47 -0700 From: Kees Cook To: Sami Tolvanen Subject: Re: [PATCH v2 16/28] init: lto: fix PREL32 relocations Message-ID: <202009031541.40B54A2E51@keescook> References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-17-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200903203053.3411268-17-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200903_184151_852599_18BB05D2 X-CRM114-Status: GOOD ( 14.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, "Paul E. McKenney" , kernel-hardening@lists.openwall.com, Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild@vger.kernel.org, Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , clang-built-linux@googlegroups.com, linux-pci@vger.kernel.org, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 03, 2020 at 01:30:41PM -0700, 'Sami Tolvanen' via Clang Built Linux wrote: > With LTO, the compiler can rename static functions to avoid global > naming collisions. As initcall functions are typically static, > renaming can break references to them in inline assembly. This > change adds a global stub with a stable name for each initcall to > fix the issue when PREL32 relocations are used. > > Signed-off-by: Sami Tolvanen This was a Delight(tm) to get right. Thanks for finding the right magic here. :) Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel