From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 177F8C43461 for ; Thu, 3 Sep 2020 22:43:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CBE1020716 for ; Thu, 3 Sep 2020 22:43:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="faYECuE8"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="XY2V+aPz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBE1020716 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4ui689wG9rOb/eoSBATQNEPHuVrThF/73723qSReV88=; b=faYECuE8NGcHJF57EYCks2twI 1RYGYzfm+VnXLGXhU29Pa/HKXTOcGKWm6honFt1iTGDI40ppRDzmDOB5NL0z27gGuUniSoO0bLQxW /qZABJOyZAP1Xn7txBsZ+lnItYP+63K9BYPebyBKKyuRy8lg+Y0fqT109qaB8xl7T4UEjOjh9fXpD OLWldzNtz5PkyHFzkrOYc2aKAxC5c+ht0mzdTdCOFYKCpvIrbibomfzegtJr3/Wxipx/Kso1PHaaq 6yGk6Zlk5fJuU+YpECvkROioPBWgckaL98N5LoKhXz+Wd4aapI3UKq/xa/EGKAcsD95acdtsjpqs/ eTSLhhCzg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDxvx-0002A4-AX; Thu, 03 Sep 2020 22:42:21 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDxvu-00028J-3R for linux-arm-kernel@lists.infradead.org; Thu, 03 Sep 2020 22:42:18 +0000 Received: by mail-pf1-x444.google.com with SMTP id v196so3510670pfc.1 for ; Thu, 03 Sep 2020 15:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TlwuOH2EQG6MCnppWuU43l955MakvluKpUTVDERTNO8=; b=XY2V+aPzW1+LDnPQgs8LCKdfsW+ukc0CH4hsERu2c197BquhpT6ytbY651mqbWroP5 NoijPo4tmmhjTbE82fXMmxBiTTfrN9b+BObSgnEn5HC00srbReXMVw7CaVxDZQjvWDNb sLqtBJzVmvCGKIRCPcZC9IKz2mLH5Kg/+0yME= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TlwuOH2EQG6MCnppWuU43l955MakvluKpUTVDERTNO8=; b=OK/wbsvO3jydmxJaDUEBWQfu2T2LZR5i9QXJlDBQKj5umMmXmsZ9IJYiYk1NA1vflq HjtOoJqtHKoNhYmzTE1bbvbot21UslV4roEvc+3Jy2DSlejJj8FreN22CeQg2rOM88lD NXGvmT4nbk0r1MoLUTj1sE8dC9z3+frlzwUyFZT5tmcwInmAK6KY872pedlBQxKvJFJK 75yl3q0O9kw5Lodo+kHEwyQRcxSv340vlQ3qSI3i6TIO7dtKdCwfIqfh/+jcezRmtKB8 nzzC42U4idiPeObL8oT624+AWtYQCP0OUDWsxvshOiEgjXG86HYHO8D+WG0o6CyNxchg YWWg== X-Gm-Message-State: AOAM532L4bgDwXdkXWOQhP3aylizvQLukbjiPTlQ9MVhmBNHJkEmMiVW gMGYfRGKrQuFmBPSCKtpt0eIdQ== X-Google-Smtp-Source: ABdhPJyqBzmMfYaY/Mz5zx6mhtV8btCsnKX7oA2efoS7o6nY6a3yOyI6Ra3/iG5Srj/uMw3Z86qeLw== X-Received: by 2002:a63:384b:: with SMTP id h11mr4827548pgn.113.1599172936031; Thu, 03 Sep 2020 15:42:16 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id a6sm3760136pgt.70.2020.09.03.15.42.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 15:42:14 -0700 (PDT) Date: Thu, 3 Sep 2020 15:42:13 -0700 From: Kees Cook To: Sami Tolvanen Subject: Re: [PATCH v2 17/28] PCI: Fix PREL32 relocations for LTO Message-ID: <202009031542.F6DA50F6@keescook> References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-18-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200903203053.3411268-18-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200903_184218_190695_F12471F5 X-CRM114-Status: GOOD ( 14.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, "Paul E. McKenney" , kernel-hardening@lists.openwall.com, Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild@vger.kernel.org, Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , clang-built-linux@googlegroups.com, linux-pci@vger.kernel.org, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 03, 2020 at 01:30:42PM -0700, Sami Tolvanen wrote: > With Clang's Link Time Optimization (LTO), the compiler can rename > static functions to avoid global naming collisions. As PCI fixup > functions are typically static, renaming can break references > to them in inline assembly. This change adds a global stub to > DECLARE_PCI_FIXUP_SECTION to fix the issue when PREL32 relocations > are used. > > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel