From: "Pali Rohár" <pali@kernel.org>
To: Andre Heider <a.heider@gmail.com>
Cc: Tomasz Maciej Nowak <tmn505@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>,
devicetree@vger.kernel.org,
Gregory Clement <gregory.clement@bootlin.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases
Date: Mon, 7 Sep 2020 19:42:00 +0200 [thread overview]
Message-ID: <20200907174200.yqojaguthi6khn3v@pali> (raw)
In-Reply-To: <3ec54259-4bfe-8462-e8d5-083fc009707a@gmail.com>
On Monday 07 September 2020 19:13:41 Andre Heider wrote:
> > @@ -120,7 +124,7 @@
> > #address-cells = <1>;
> > #size-cells = <0>;
> > - port@0 {
> > + switch0port0: port@0 {
>
> This label is unused it seems.
Yes, it is unused, but I defined labels for all ports so it would be
clean that ports are indexed from zero and not from one. Also it looks
inconsistent if some of DSA ports have labels and some does not.
>
> > reg = <0>;
> > label = "cpu";
> > ethernet = <ð0>;
> > @@ -131,19 +135,19 @@
> > };
> > };
> > - port@1 {
> > + switch0port1: port@1 {
> > reg = <1>;
> > label = "wan";
> > phy-handle = <&switch0phy0>;
> > };
> > - port@2 {
> > + switch0port2: port@2 {
> > reg = <2>;
> > label = "lan0";
> > phy-handle = <&switch0phy1>;
> > };
> > - port@3 {
> > + switch0port3: port@3 {
> > reg = <3>;
> > label = "lan1";
> > phy-handle = <&switch0phy2>;
> >
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-07 17:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 11:27 [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases Pali Rohár
2020-09-07 14:42 ` Andrew Lunn
2020-09-07 14:52 ` Pali Rohár
2020-09-07 15:43 ` Andrew Lunn
2020-09-07 16:13 ` Pali Rohár
2020-09-07 17:23 ` Andrew Lunn
2020-09-08 7:47 ` Pali Rohár
2020-09-23 16:19 ` Pali Rohár
2020-09-24 8:15 ` Gregory CLEMENT
2020-09-07 17:13 ` Andre Heider
2020-09-07 17:23 ` Andrew Lunn
2020-09-07 17:35 ` Pali Rohár
2020-09-07 17:43 ` Andre Heider
2020-09-07 17:47 ` Pali Rohár
2020-09-07 17:50 ` Andre Heider
2020-09-07 18:50 ` Andrew Lunn
2020-09-07 17:42 ` Pali Rohár [this message]
2020-09-07 17:44 ` Andre Heider
2020-09-23 15:01 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907174200.yqojaguthi6khn3v@pali \
--to=pali@kernel.org \
--cc=a.heider@gmail.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tmn505@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).