linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Lokesh Vutla <lokeshvutla@ti.com>, <ssantosh@kernel.org>
Cc: Device Tree Mailing List <devicetree@vger.kernel.org>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Sekhar Nori <nsekhar@ti.com>, Tero Kristo <t-kristo@ti.com>,
	Rob Herring <robh+dt@kernel.org>,
	Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 4/4] arm64: dts: ti: Add support for J7200 Common Processor Board
Date: Tue, 8 Sep 2020 06:57:41 -0500	[thread overview]
Message-ID: <20200908115741.v6enutg2mdnwhkk6@akan> (raw)
In-Reply-To: <20200827065144.17683-5-lokeshvutla@ti.com>

On 12:21-20200827, Lokesh Vutla wrote:
[..]
> 
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>  arch/arm64/boot/dts/ti/Makefile               |  3 +-
>  .../dts/ti/k3-j7200-common-proc-board.dts     | 64 +++++++++++++++++++
>  arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi   | 29 +++++++++
>  3 files changed, 95 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>  create mode 100644 arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
> 
> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
> index 05c0bebf65d4..60ab9b72c130 100644
> --- a/arch/arm64/boot/dts/ti/Makefile
> +++ b/arch/arm64/boot/dts/ti/Makefile
> @@ -8,4 +8,5 @@
>  
>  dtb-$(CONFIG_ARCH_K3_AM6_SOC) += k3-am654-base-board.dtb
>  
> -dtb-$(CONFIG_ARCH_K3_J721E_SOC) += k3-j721e-common-proc-board.dtb
> +dtb-$(CONFIG_ARCH_K3_J721E_SOC) += k3-j721e-common-proc-board.dtb \
> +				   k3-j7200-common-proc-board.dtb


As we discussed in [1], to allow lesser dependencies and better
maintainability,
a) Lets first s/CONFIG_ARCH_K3_AM6_SOC/CONFIG_ARCH_K3/ and same
   with CONFIG_ARCH_K3_J721E_SOC in the dts Makefile. Santosh: headsup,
   we are cleaning up users of the SOC config options[2] - we will clean
   the Kconfig up in a follow-on rc/kernel rev.
b) lets not use the \ and instead, use += - it will be lesser diff as we
add new dtbs.
+dtb-$(CONFIG_ARCH_K3) += k3-j7200-common-proc-board.dtb

[1] https://lore.kernel.org/linux-arm-kernel/20200908112534.t5bgrjf7y3a6l2ss@akan/
[2] https://mailman.alsa-project.org/pipermail/alsa-devel/2020-September/173791.html
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> new file mode 100644
> index 000000000000..e27069317c4e
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts

Otherwise looks fine to me.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-09-08 11:58 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-27  6:51 [PATCH v2 0/4] arm64: Initial support for Texas Instrument's J7200 Platform Lokesh Vutla
2020-08-27  6:51 ` [PATCH v2 1/4] dt-bindings: arm: ti: Convert K3 board/soc bindings to DT schema Lokesh Vutla
2020-08-28  0:41   ` Nishanth Menon
2020-08-28  3:14     ` Lokesh Vutla
2020-08-28  3:47       ` Suman Anna
2020-08-28 13:07       ` Nishanth Menon
2020-09-04 11:55       ` Nishanth Menon
2020-09-04  7:15   ` Lokesh Vutla
2020-08-27  6:51 ` [PATCH v2 2/4] dt-bindings: arm: ti: Add bindings for J7200 SoC Lokesh Vutla
2020-08-27  6:51 ` [PATCH v2 3/4] arm64: dts: ti: Add support " Lokesh Vutla
2020-08-27 17:04   ` Suman Anna
2020-09-08 11:47     ` Nishanth Menon
2020-08-31  9:13   ` Peter Ujfalusi
2020-09-02  3:51     ` Lokesh Vutla
2020-08-27  6:51 ` [PATCH v2 4/4] arm64: dts: ti: Add support for J7200 Common Processor Board Lokesh Vutla
2020-09-08 11:57   ` Nishanth Menon [this message]
2020-08-27  9:09 ` [PATCH v2 0/4] arm64: Initial support for Texas Instrument's J7200 Platform Grygorii Strashko
2020-09-07 12:02 ` Lokesh Vutla
2020-09-07 14:14   ` Nishanth Menon
2020-09-07 14:23     ` Lokesh Vutla
2020-09-07 23:48       ` Nishanth Menon
2020-09-08  9:55         ` Tero Kristo
2020-09-08 11:25           ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200908115741.v6enutg2mdnwhkk6@akan \
    --to=nm@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=lokeshvutla@ti.com \
    --cc=nsekhar@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=ssantosh@kernel.org \
    --cc=t-kristo@ti.com \
    --subject='Re: [PATCH v2 4/4] arm64: dts: ti: Add support for J7200 Common Processor Board' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).