From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2836BC433E2 for ; Tue, 8 Sep 2020 18:24:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C85F42080A for ; Tue, 8 Sep 2020 18:24:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OVMl9N9r"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="Oo/DQrZC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C85F42080A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8nQADSC6KQwhVAwy63PUhvgHQuySN1tboRPdRKIlChg=; b=OVMl9N9r2TP9zhfVRUOYOROxH bDGHAzsdbzkIiKO7xQgHzE8Ulconq7WRX3PvLaDKwoVO6GItdAkB6AHqWdT4BfWSj8XiUdTv23cjW WuIOEHwNPui15A1ikZzYKGYvL4vJTWqKQwZ+lTcrGQeongbIn6eDvuuUoweLP+UWpd+Uxo/qyH6dj zPO0DOeU+KBqd0XaqcCXUZPfpXgZWVDFzVGFFf1AGJ1fBy0EygBtrruOxN1CQCSpJJzWcsoDiE+WG q6W8XjLrC9pWb5fbv5CgmN8za7EcCdOKMAl7cAYJMSp0i+E0/fTjhFFpX+2Ck6RTtx6mwXwUR8wZn T1C/rIG2w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFiH2-0004pE-Tf; Tue, 08 Sep 2020 18:23:20 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFiGz-0004nb-6c for linux-arm-kernel@lists.infradead.org; Tue, 08 Sep 2020 18:23:18 +0000 Received: by mail-pf1-x442.google.com with SMTP id k15so11640936pfc.12 for ; Tue, 08 Sep 2020 11:23:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=mfB0S2TmcGDxX8xZkZ/chTU0dmPHOOO8nuKSmYrB2mM=; b=Oo/DQrZCB0KIovn2oIQvAUWTptWqamehVi+n9pOLZRf1yPmAlsDgequytTa8T71Hfc MnZ8qfVQW2q6h/Gb3s3xMzJv0ALrHyHScJJ+WdbP6brRxtmNudTvVWKGbUjfoC5KHF4b uGSGjTSSevWadA70wvgbB72exIK9HnLgQdo9pBIgjKkAOXHzO50M1u7BZGl1okDbUiqz czRJlEsh6kR0+ujAUZ5GoU2okMRHEd7MJeAWIce5U7hvYLvI/36yTxGrED/UXTfJN1Pp +8kHwWJ0fqPNtnwRBmLuZUKXP2wEoOXwXAgDcmvidR+BlAhYV4QFIECLoW9snCOd1lTW zkcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mfB0S2TmcGDxX8xZkZ/chTU0dmPHOOO8nuKSmYrB2mM=; b=A1Z0GLnvqSYVyEryPdUbNq8reoMll3N1KqH4s3G6rGhjiNQD7M+g7cLB9icKhNuEhY Pw4Qj4YwNZsXxxcemiZ4SQGOzoZIAq/KmQdAKUoT45QQjp++Cx32kJvD2yovqeLbnfYW V14OXqM+Z8TN6HxdHn3efDjKqeOjyOBLH77Ff83onxYZ0+8N0woGPQftUcDV1BwFpmw9 a1yEkf4XdRL8IImeSG4cjXhpV1e1xMntsCMD3vpY0qE0LcWD0NTK6qb5CBJmhAfjktCv jnHR3cxgLI/3DV+NVuqzalWLTnvGlZnW34m++A6rzZf0F6OLcUJiz+Fm6zbg2k1mmSnr sSmA== X-Gm-Message-State: AOAM533U2ZeN95Lwnc0I05925RTdG5JmM8XgJwmw2olLMLeORF5z3iY4 DrL4VUUZE5p1YNBnaYXeULPZzw== X-Google-Smtp-Source: ABdhPJwprY99iDi73Le2vnSOxXHnK9OCb6eXlfe519dNjZDsp0xdQH72w/MWOHjt+KXl9278n5yCtw== X-Received: by 2002:a17:902:10f:: with SMTP id 15mr24890192plb.121.1599589394447; Tue, 08 Sep 2020 11:23:14 -0700 (PDT) Received: from google.com ([2620:15c:201:2:f693:9fff:fef4:1b6d]) by smtp.gmail.com with ESMTPSA id h11sm108910pfe.185.2020.09.08.11.23.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 11:23:13 -0700 (PDT) Date: Tue, 8 Sep 2020 11:23:08 -0700 From: Sami Tolvanen To: Kees Cook Subject: Re: [PATCH v2 10/28] kbuild: lto: fix module versioning Message-ID: <20200908182308.GA1227805@google.com> References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-11-samitolvanen@google.com> <202009031510.32523E45EC@keescook> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202009031510.32523E45EC@keescook> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200908_142317_278426_1301DC97 X-CRM114-Status: GOOD ( 18.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, "Paul E. McKenney" , kernel-hardening@lists.openwall.com, Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild@vger.kernel.org, Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , clang-built-linux@googlegroups.com, linux-pci@vger.kernel.org, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 03, 2020 at 03:11:54PM -0700, Kees Cook wrote: > On Thu, Sep 03, 2020 at 01:30:35PM -0700, Sami Tolvanen wrote: > > With CONFIG_MODVERSIONS, version information is linked into each > > compilation unit that exports symbols. With LTO, we cannot use this > > method as all C code is compiled into LLVM bitcode instead. This > > change collects symbol versions into .symversions files and merges > > them in link-vmlinux.sh where they are all linked into vmlinux.o at > > the same time. > > > > Signed-off-by: Sami Tolvanen > > The only thought I have here is I wonder if this change could be made > universally instead of gating on LTO? (i.e. is it noticeably slower to > do it this way under non-LTO?) I don't think it's noticeably slower, but keeping the version information in object files when possible is cleaner, in my opinion. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel