From: Rob Herring <robh@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] dt-bindings: microchip: atmel,at91rm9200-tcb: add atmel,tcb-pwm
Date: Tue, 8 Sep 2020 14:48:34 -0600 [thread overview]
Message-ID: <20200908204834.GA886652@bogus> (raw)
In-Reply-To: <20200820225546.2246517-2-alexandre.belloni@bootlin.com>
On Fri, Aug 21, 2020 at 12:55:43AM +0200, Alexandre Belloni wrote:
> Move the TCB pwm nodes under their parent and move its documentation to the
> main file.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> Cc: Rob Herring <robh+dt@kernel.org>
>
> .../devicetree/bindings/pwm/atmel-tcb-pwm.txt | 16 ----------
> .../soc/microchip/atmel,at91rm9200-tcb.yaml | 31 ++++++++++++++++++-
> 2 files changed, 30 insertions(+), 17 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/pwm/atmel-tcb-pwm.txt
>
> diff --git a/Documentation/devicetree/bindings/pwm/atmel-tcb-pwm.txt b/Documentation/devicetree/bindings/pwm/atmel-tcb-pwm.txt
> deleted file mode 100644
> index 985fcc65f8c4..000000000000
> --- a/Documentation/devicetree/bindings/pwm/atmel-tcb-pwm.txt
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -Atmel TCB PWM controller
> -
> -Required properties:
> -- compatible: should be "atmel,tcb-pwm"
> -- #pwm-cells: should be 3. See pwm.yaml in this directory for a description of
> - the cells format. The only third cell flag supported by this binding is
> - PWM_POLARITY_INVERTED.
> -- tc-block: The Timer Counter block to use as a PWM chip.
What happened to 'tc-block'? Commit message should mention why it is
gone.
> -
> -Example:
> -
> -pwm {
> - compatible = "atmel,tcb-pwm";
> - #pwm-cells = <3>;
> - tc-block = <1>;
> -};
> diff --git a/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml b/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml
> index 55fffae05dcf..a51adfdb58f6 100644
> --- a/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml
> +++ b/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml
> @@ -59,6 +59,7 @@ patternProperties:
> items:
> - enum:
> - atmel,tcb-timer
> + - atmel,tcb-pwm
> - microchip,tcb-capture
> reg:
> description:
> @@ -68,11 +69,33 @@ patternProperties:
>
> minItems: 1
> maxItems: 3
> + required:
> + - compatible
> + - reg
> +
> + "^pwm@[0-2]$":
> + description: The timer block channels that are used as PWMs.
> + $ref: ../../pwm/pwm.yaml#
> + type: object
> + properties:
> + compatible:
> + const: atmel,tcb-pwm
> + reg:
> + description:
> + TCB channel to use for this PWM.
enum: [ 0, 1, 2 ]
> +
> + maxItems: 1
> + "#pwm-cells":
> + description:
> + The only third cell flag supported by this binding is
> + PWM_POLARITY_INVERTED.
> + const: 3
>
> required:
> - compatible
> - reg
additionalProperties: false
>
> +
> allOf:
> - if:
> properties:
> @@ -158,7 +181,13 @@ examples:
> compatible = "atmel,tcb-timer";
> reg = <1>;
> };
> - };
> +
> + pwm@2 {
> + compatible = "atmel,tcb-pwm";
> + reg = <2>;
> + #pwm-cells = <3>;
> + };
> + };
> /* TCB0 Capture with QDEC: */
> timer@f800c000 {
> compatible = "atmel,at91rm9200-tcb", "simple-mfd", "syscon";
> --
> 2.26.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-08 20:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 22:55 [PATCH 0/4] pwm: atmel-tcb: rework device tree binding Alexandre Belloni
2020-08-20 22:55 ` [PATCH 1/4] dt-bindings: microchip: atmel, at91rm9200-tcb: add atmel, tcb-pwm Alexandre Belloni
2020-09-08 20:48 ` Rob Herring [this message]
2020-09-30 10:00 ` [PATCH 1/4] dt-bindings: microchip: atmel,at91rm9200-tcb: add atmel,tcb-pwm Alexandre Belloni
2020-08-20 22:55 ` [PATCH 2/4] pwm: atmel-tcb: switch to new binding Alexandre Belloni
2020-08-20 22:55 ` [PATCH 3/4] pwm: atmel-tcb: add sama5d2 support Alexandre Belloni
2020-08-20 22:55 ` [PATCH 4/4] ARM: dts: at91: kizbox: switch to new pwm-atmel-tcb binding Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908204834.GA886652@bogus \
--to=robh@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).