From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95507C433E2 for ; Thu, 10 Sep 2020 18:31:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B31821D40 for ; Thu, 10 Sep 2020 18:31:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZoAFaSnn"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="UCp+FppW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B31821D40 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NG4sAk4NXXVaZ30hJT7KtvqwND13GnexHLWq/1qEyxg=; b=ZoAFaSnnu2aCJ+uhpg3isHMiY KLlEyPN1d15GPrWWuCjXprpKlu8sZnwUs/kfvu+2MVqV0nGDyEvlO1F+Hd+uTbesnixsOzXdYWwpY r3Q9O8qLHThyILhk0E7Rn9UNLsO1e/IO9t3fQwwqyfl/M30RX9cC6XeEYMcAdfNZ6UAChBi/+kN/u UWV1HniREDPE5NwIb04dyZZKb/EqKpftIay6YemT/tLeuO/id/rTSQhyZMlDAYkezBwWCzVlBY2rP iOJ2gYo6qeJVwtS+6mgi7SEG5Tx0EtRMTzmkAMR8BiqA787zgER6fHzo3VLxtXLjhxqAe6+8jzhAv k0Adnq1cQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGRKL-0003dp-Ly; Thu, 10 Sep 2020 18:29:45 +0000 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGRKI-0003bj-KO for linux-arm-kernel@lists.infradead.org; Thu, 10 Sep 2020 18:29:43 +0000 Received: by mail-pj1-x1041.google.com with SMTP id u3so437250pjr.3 for ; Thu, 10 Sep 2020 11:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wjAWuNbVBoEPyXn+QBzLMnCnG3b1YEYkoDZS6EgQpPI=; b=UCp+FppW+25RCEWuidrdmD2H7oNwJWAPscXMA2ljdT7Hwfc6emJQQRXJKlonqRXwCr ZNZwT1diexj1oIPFx0vZRCKp8ePiBMfI0fNJK+PDlwitnt2/pXVXXfcmv7xMHDx85MGD jjgpGgVOnGdOdetQ71hUdu1jBGb560fU84u+I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wjAWuNbVBoEPyXn+QBzLMnCnG3b1YEYkoDZS6EgQpPI=; b=rqBcKuNnjSivcPe2/9z63WbGsoWnttXxQDdtmd9FWySbQqZJmtnIvE7bWpynx6wq9u Rytwr1QN0uAM5c8k4R16/sCjF3CpFqdndDfV8WOyHq7CxjDD6xN2SJKasUMruEIp9kZi oXzeO61fEMtbVNLE8WARz2M6qEJ+He1kClsBF5Rf97KxLB5Y02RdGqIT3nHhGXhScDnS axu6gVZpsJQDTsC+IJOpE5omo1I01oz/I4rNaLwzEQ7TcixKCttnfiFnshuacM+Pa2aM 9uyMbsJJ/Po0C6/OmX81xtx4hG9E7AG1X/cIKHGMrQjcBzp8IS7rQi7rj++fjDSEZ1VN ZRpA== X-Gm-Message-State: AOAM530R/x6iS06uDyZSp8kA+7FP/BQH0MVm0pePUnDk1iGTK45GNS0g TapvA11g7DGTzQ8HoIV5bWd8YA== X-Google-Smtp-Source: ABdhPJwQHia5IxoItB0v8TFyFBQYaMjt9d9oEodKfnuR8Fqxq3O6+WSooIjqvBiG9AzcqTroMIMGDQ== X-Received: by 2002:a17:90b:3717:: with SMTP id mg23mr1229702pjb.42.1599762580221; Thu, 10 Sep 2020 11:29:40 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z9sm6606733pfk.118.2020.09.10.11.29.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2020 11:29:39 -0700 (PDT) Date: Thu, 10 Sep 2020 11:29:38 -0700 From: Kees Cook To: Steven Rostedt Subject: Re: [PATCH v2 05/28] objtool: Add a pass for generating __mcount_loc Message-ID: <202009101127.28B4414D2A@keescook> References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-6-samitolvanen@google.com> <202009031450.31C71DB@keescook> <20200904093104.GH1362448@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200904093104.GH1362448@hirez.programming.kicks-ass.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200910_142942_697149_81F02632 X-CRM114-Status: GOOD ( 27.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , X86 ML , "Paul E. McKenney" , Kernel Hardening , peterz@infradead.org, Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild , Nick Desaulniers , LKML , clang-built-linux , Sami Tolvanen , linux-pci@vger.kernel.org, Will Deacon , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 04, 2020 at 11:31:04AM +0200, peterz@infradead.org wrote: > On Thu, Sep 03, 2020 at 03:03:30PM -0700, Sami Tolvanen wrote: > > On Thu, Sep 3, 2020 at 2:51 PM Kees Cook wrote: > > > > > > On Thu, Sep 03, 2020 at 01:30:30PM -0700, Sami Tolvanen wrote: > > > > From: Peter Zijlstra > > > > > > > > Add the --mcount option for generating __mcount_loc sections > > > > needed for dynamic ftrace. Using this pass requires the kernel to > > > > be compiled with -mfentry and CC_USING_NOP_MCOUNT to be defined > > > > in Makefile. > > > > > > > > Link: https://lore.kernel.org/lkml/20200625200235.GQ4781@hirez.programming.kicks-ass.net/ > > > > Signed-off-by: Peter Zijlstra > > > > > > Hmm, I'm not sure why this hasn't gotten picked up yet. Is this expected > > > to go through -tip or something else? > > > > Note that I picked up this patch from Peter's original email, to which > > I included a link in the commit message, but it wasn't officially > > submitted as a patch. However, the previous discussion seems to have > > died, so I included the patch in this series, as it cleanly solves the > > problem of whitelisting non-call references to __fentry__. I was > > hoping for Peter and Steven to comment on how they prefer to proceed > > here. > > Right; so I'm obviously fine with this patch and I suppose I can pick it > (and the next) into tip/objtool/core, provided Steve is okay with this > approach. Hello Steven-of-the-future-after-4000-emails![1] ;) Getting your Ack on this would be very welcome, and would unblock a portion of this series. Thanks! :) [1] https://twitter.com/srostedt/status/1303697650592755712 -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel