From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59E0AC433E2 for ; Fri, 11 Sep 2020 13:57:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFF6020855 for ; Fri, 11 Sep 2020 13:57:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0BYJ4hh2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="o4p1Xnr4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFF6020855 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GYLESfl7BGJkzanff+ZxtJ15kF72IMjpyq2NK0nAvJY=; b=0BYJ4hh2OCgZORbFakAah/30n znbkXe3F1w6sxrGvQSwydRxidGu6r6k3+KP4HwHEH8h3pdtqJSbv2fxL/u4wTs/VHASC7agKIrKoU cCi6avDvFQHbMZZ0HbByzqsFxBXhmen1DjvitdmptaczdWDdP7PJJ5DnnUHPh4JSOT6qEprBJ1Jfk p40PfROHR5MUMIEMLwiYwD3X3Lw0DdEBYs3tQ58VNYCr01Lr51/ZflvH018bF1KOVR7gy/AdI2HmE pnhlRGkX6pkyOVMu97jLRfce7DsAK/MapdS+L3lH3nHxN7LwhvroZZfWPudSZh0Brc17vm03aVTx3 yOh+ExrlQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGjWo-0006M9-H7; Fri, 11 Sep 2020 13:55:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGjWk-0006Kn-10 for linux-arm-kernel@lists.infradead.org; Fri, 11 Sep 2020 13:55:47 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C3B9B206DB; Fri, 11 Sep 2020 13:55:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599832545; bh=6pYau5l0Hp4fpB7f3ZAsCK6sdBpk/klyi7e2jD5YUsc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o4p1Xnr4kY0liYaCgITjHVQ6JxItL1amWSl2avp6QlxigfUYC1sFvFwUbSsHQmssF RakyXKoogD9YgTKz/cM5KcyxNHcO9Uc93BIdU8ImPeR/k4ZSbKdLZW677dPiLNJER9 AoBoztRc2AzFMJM7gw00GItRsnNHqfrYY8XzBS6g= Date: Fri, 11 Sep 2020 14:55:40 +0100 From: Will Deacon To: Dave Martin Subject: Re: [PATCH v6 1/6] arm64: kprobe: add checks for ARMv8.3-PAuth combined instructions Message-ID: <20200911135539.GA19961@willie-the-truck> References: <20200904104209.32385-1-amit.kachhap@arm.com> <20200904104209.32385-2-amit.kachhap@arm.com> <20200907214551.GD13815@willie-the-truck> <20200908105107.GQ6642@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200908105107.GQ6642@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200911_095546_157130_0E18F461 X-CRM114-Status: GOOD ( 21.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Suzuki K Poulose , Catalin Marinas , Mark Brown , James Morse , Amit Daniel Kachhap , Vincenzo Frascino , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 08, 2020 at 11:51:08AM +0100, Dave Martin wrote: > On Mon, Sep 07, 2020 at 10:45:51PM +0100, Will Deacon wrote: > > On Fri, Sep 04, 2020 at 04:12:04PM +0530, Amit Daniel Kachhap wrote: > > > diff --git a/arch/arm64/include/asm/insn.h b/arch/arm64/include/asm/insn.h > > > index 0bc46149e491..324234068fee 100644 > > > --- a/arch/arm64/include/asm/insn.h > > > +++ b/arch/arm64/include/asm/insn.h > > > @@ -359,9 +359,21 @@ __AARCH64_INSN_FUNCS(brk, 0xFFE0001F, 0xD4200000) > > > __AARCH64_INSN_FUNCS(exception, 0xFF000000, 0xD4000000) > > > __AARCH64_INSN_FUNCS(hint, 0xFFFFF01F, 0xD503201F) > > > __AARCH64_INSN_FUNCS(br, 0xFFFFFC1F, 0xD61F0000) > > > +__AARCH64_INSN_FUNCS(braaz, 0xFFFFFC1F, 0xD61F081F) > > > +__AARCH64_INSN_FUNCS(brabz, 0xFFFFFC1F, 0xD61F0C1F) > > > +__AARCH64_INSN_FUNCS(braa, 0xFFFFFC00, 0xD71F0800) > > > +__AARCH64_INSN_FUNCS(brab, 0xFFFFFC00, 0xD71F0C00) > > > > When do we need to distinguish these variants? Can we modify the mask/value > > pair so that we catch bra* in one go? That would match how they are > > documented in the Arm ARM. > > > > > __AARCH64_INSN_FUNCS(blr, 0xFFFFFC1F, 0xD63F0000) > > > +__AARCH64_INSN_FUNCS(blraaz, 0xFFFFFC1F, 0xD63F081F) > > > +__AARCH64_INSN_FUNCS(blrabz, 0xFFFFFC1F, 0xD63F0C1F) > > > +__AARCH64_INSN_FUNCS(blraa, 0xFFFFFC00, 0xD73F0800) > > > +__AARCH64_INSN_FUNCS(blrab, 0xFFFFFC00, 0xD73F0C00) > > > > Same here for blra* > > > > > __AARCH64_INSN_FUNCS(ret, 0xFFFFFC1F, 0xD65F0000) > > > +__AARCH64_INSN_FUNCS(retaa, 0xFFFFFFFF, 0xD65F0BFF) > > > +__AARCH64_INSN_FUNCS(retab, 0xFFFFFFFF, 0xD65F0FFF) > > > __AARCH64_INSN_FUNCS(eret, 0xFFFFFFFF, 0xD69F03E0) > > > +__AARCH64_INSN_FUNCS(eretaa, 0xFFFFFFFF, 0xD69F0BFF) > > > +__AARCH64_INSN_FUNCS(eretab, 0xFFFFFFFF, 0xD69F0FFF) > > > > ... and here for ereta*. > > From my side: > > I thought about this myself, but I thought that this may be easier to > maintain if we avoid lumping instructions together. Maybe, but I'm just suggesting to lump them together in the same way as the Arm ARM, which I think helps readability because it lines up directly with the text. > I guess I'm happy either way. Ok, thanks. Amit -- can you repost the series with that change, please, and I'll queue the lot for 5.10? Thanks, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel