* [PATCH] drm: xlnx: remove defined but not used 'scaling_factors_666'
@ 2020-09-10 14:06 Jason Yan
2020-09-10 18:14 ` Hyun Kwon
0 siblings, 1 reply; 5+ messages in thread
From: Jason Yan @ 2020-09-10 14:06 UTC (permalink / raw)
To: hyun.kwon, laurent.pinchart, airlied, daniel, michal.simek,
yanaijie, dri-devel, linux-arm-kernel, linux-kernel
Cc: Hulk Robot
This addresses the following gcc warning with "make W=1":
drivers/gpu/drm/xlnx/zynqmp_disp.c:245:18: warning:
‘scaling_factors_666’ defined but not used [-Wunused-const-variable=]
245 | static const u32 scaling_factors_666[] = {
| ^~~~~~~~~~~~~~~~~~~
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
index a455cfc1bee5..98bd48f13fd1 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
@@ -242,12 +242,6 @@ static const u32 scaling_factors_565[] = {
ZYNQMP_DISP_AV_BUF_5BIT_SF,
};
-static const u32 scaling_factors_666[] = {
- ZYNQMP_DISP_AV_BUF_6BIT_SF,
- ZYNQMP_DISP_AV_BUF_6BIT_SF,
- ZYNQMP_DISP_AV_BUF_6BIT_SF,
-};
-
static const u32 scaling_factors_888[] = {
ZYNQMP_DISP_AV_BUF_8BIT_SF,
ZYNQMP_DISP_AV_BUF_8BIT_SF,
--
2.25.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: xlnx: remove defined but not used 'scaling_factors_666'
2020-09-10 14:06 [PATCH] drm: xlnx: remove defined but not used 'scaling_factors_666' Jason Yan
@ 2020-09-10 18:14 ` Hyun Kwon
2020-09-11 8:15 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Hyun Kwon @ 2020-09-10 18:14 UTC (permalink / raw)
To: Jason Yan
Cc: airlied, linux-kernel, dri-devel, Hulk Robot, Michal Simek,
laurent.pinchart, daniel, linux-arm-kernel
Hi Jason,
On Thu, Sep 10, 2020 at 07:06:30AM -0700, Jason Yan wrote:
> This addresses the following gcc warning with "make W=1":
>
> drivers/gpu/drm/xlnx/zynqmp_disp.c:245:18: warning:
> ‘scaling_factors_666’ defined but not used [-Wunused-const-variable=]
> 245 | static const u32 scaling_factors_666[] = {
> | ^~~~~~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: Hyun Kwon <hyun.kwon@xilinx.com>
Thanks!
-hyun
> ---
> drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> index a455cfc1bee5..98bd48f13fd1 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> @@ -242,12 +242,6 @@ static const u32 scaling_factors_565[] = {
> ZYNQMP_DISP_AV_BUF_5BIT_SF,
> };
>
> -static const u32 scaling_factors_666[] = {
> - ZYNQMP_DISP_AV_BUF_6BIT_SF,
> - ZYNQMP_DISP_AV_BUF_6BIT_SF,
> - ZYNQMP_DISP_AV_BUF_6BIT_SF,
> -};
> -
> static const u32 scaling_factors_888[] = {
> ZYNQMP_DISP_AV_BUF_8BIT_SF,
> ZYNQMP_DISP_AV_BUF_8BIT_SF,
> --
> 2.25.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: xlnx: remove defined but not used 'scaling_factors_666'
2020-09-10 18:14 ` Hyun Kwon
@ 2020-09-11 8:15 ` Daniel Vetter
2020-09-11 16:27 ` Hyun Kwon
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2020-09-11 8:15 UTC (permalink / raw)
To: Hyun Kwon
Cc: Jason Yan, airlied, linux-kernel, dri-devel, Hulk Robot,
Michal Simek, laurent.pinchart, daniel, linux-arm-kernel
On Thu, Sep 10, 2020 at 11:14:18AM -0700, Hyun Kwon wrote:
> Hi Jason,
>
> On Thu, Sep 10, 2020 at 07:06:30AM -0700, Jason Yan wrote:
> > This addresses the following gcc warning with "make W=1":
> >
> > drivers/gpu/drm/xlnx/zynqmp_disp.c:245:18: warning:
> > ‘scaling_factors_666’ defined but not used [-Wunused-const-variable=]
> > 245 | static const u32 scaling_factors_666[] = {
> > | ^~~~~~~~~~~~~~~~~~~
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Jason Yan <yanaijie@huawei.com>
>
> Reviewed-by: Hyun Kwon <hyun.kwon@xilinx.com>
I think you're the maintainer, so please also push patches to
drm-misc-next. Otherwise they'll just get lost, or at least it's very
confusing when a maintainer reviews a patch but there's no indication what
will happen with the patch.
-Daniel
>
> Thanks!
>
> -hyun
>
> > ---
> > drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > index a455cfc1bee5..98bd48f13fd1 100644
> > --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > @@ -242,12 +242,6 @@ static const u32 scaling_factors_565[] = {
> > ZYNQMP_DISP_AV_BUF_5BIT_SF,
> > };
> >
> > -static const u32 scaling_factors_666[] = {
> > - ZYNQMP_DISP_AV_BUF_6BIT_SF,
> > - ZYNQMP_DISP_AV_BUF_6BIT_SF,
> > - ZYNQMP_DISP_AV_BUF_6BIT_SF,
> > -};
> > -
> > static const u32 scaling_factors_888[] = {
> > ZYNQMP_DISP_AV_BUF_8BIT_SF,
> > ZYNQMP_DISP_AV_BUF_8BIT_SF,
> > --
> > 2.25.4
> >
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: xlnx: remove defined but not used 'scaling_factors_666'
2020-09-11 8:15 ` Daniel Vetter
@ 2020-09-11 16:27 ` Hyun Kwon
2020-09-12 0:45 ` Hyun Kwon
0 siblings, 1 reply; 5+ messages in thread
From: Hyun Kwon @ 2020-09-11 16:27 UTC (permalink / raw)
To: Daniel Vetter
Cc: Jason Yan, airlied, linux-kernel, dri-devel, Hulk Robot,
Michal Simek, laurent.pinchart, linux-arm-kernel
Hi Daniel,
On Fri, Sep 11, 2020 at 01:15:19AM -0700, Daniel Vetter wrote:
> On Thu, Sep 10, 2020 at 11:14:18AM -0700, Hyun Kwon wrote:
> > Hi Jason,
> >
> > On Thu, Sep 10, 2020 at 07:06:30AM -0700, Jason Yan wrote:
> > > This addresses the following gcc warning with "make W=1":
> > >
> > > drivers/gpu/drm/xlnx/zynqmp_disp.c:245:18: warning:
> > > ‘scaling_factors_666’ defined but not used [-Wunused-const-variable=]
> > > 245 | static const u32 scaling_factors_666[] = {
> > > | ^~~~~~~~~~~~~~~~~~~
> > >
> > > Reported-by: Hulk Robot <hulkci@huawei.com>
> > > Signed-off-by: Jason Yan <yanaijie@huawei.com>
> >
> > Reviewed-by: Hyun Kwon <hyun.kwon@xilinx.com>
>
> I think you're the maintainer, so please also push patches to
> drm-misc-next. Otherwise they'll just get lost, or at least it's very
> confusing when a maintainer reviews a patch but there's no indication what
> will happen with the patch.
Right. I wanted to give it some time before pushing. I'll clearly state going
forward.
Thanks,
-hyun
> -Daniel
>
> >
> > Thanks!
> >
> > -hyun
> >
> > > ---
> > > drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 ------
> > > 1 file changed, 6 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > > index a455cfc1bee5..98bd48f13fd1 100644
> > > --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > > @@ -242,12 +242,6 @@ static const u32 scaling_factors_565[] = {
> > > ZYNQMP_DISP_AV_BUF_5BIT_SF,
> > > };
> > >
> > > -static const u32 scaling_factors_666[] = {
> > > - ZYNQMP_DISP_AV_BUF_6BIT_SF,
> > > - ZYNQMP_DISP_AV_BUF_6BIT_SF,
> > > - ZYNQMP_DISP_AV_BUF_6BIT_SF,
> > > -};
> > > -
> > > static const u32 scaling_factors_888[] = {
> > > ZYNQMP_DISP_AV_BUF_8BIT_SF,
> > > ZYNQMP_DISP_AV_BUF_8BIT_SF,
> > > --
> > > 2.25.4
> > >
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: xlnx: remove defined but not used 'scaling_factors_666'
2020-09-11 16:27 ` Hyun Kwon
@ 2020-09-12 0:45 ` Hyun Kwon
0 siblings, 0 replies; 5+ messages in thread
From: Hyun Kwon @ 2020-09-12 0:45 UTC (permalink / raw)
To: Daniel Vetter
Cc: Jason Yan, airlied, linux-kernel, dri-devel, Hulk Robot,
Michal Simek, laurent.pinchart, linux-arm-kernel
On Fri, Sep 11, 2020 at 09:27:08AM -0700, Hyun Kwon wrote:
> Hi Daniel,
>
> On Fri, Sep 11, 2020 at 01:15:19AM -0700, Daniel Vetter wrote:
> > On Thu, Sep 10, 2020 at 11:14:18AM -0700, Hyun Kwon wrote:
> > > Hi Jason,
> > >
> > > On Thu, Sep 10, 2020 at 07:06:30AM -0700, Jason Yan wrote:
> > > > This addresses the following gcc warning with "make W=1":
> > > >
> > > > drivers/gpu/drm/xlnx/zynqmp_disp.c:245:18: warning:
> > > > ‘scaling_factors_666’ defined but not used [-Wunused-const-variable=]
> > > > 245 | static const u32 scaling_factors_666[] = {
> > > > | ^~~~~~~~~~~~~~~~~~~
> > > >
> > > > Reported-by: Hulk Robot <hulkci@huawei.com>
> > > > Signed-off-by: Jason Yan <yanaijie@huawei.com>
> > >
> > > Reviewed-by: Hyun Kwon <hyun.kwon@xilinx.com>
> >
> > I think you're the maintainer, so please also push patches to
> > drm-misc-next. Otherwise they'll just get lost, or at least it's very
> > confusing when a maintainer reviews a patch but there's no indication what
> > will happen with the patch.
>
> Right. I wanted to give it some time before pushing. I'll clearly state going
> forward.
>
Pushed to drm-misc/drm-misc-next.
Thanks,
-hyun
> Thanks,
> -hyun
>
> > -Daniel
> >
> > >
> > > Thanks!
> > >
> > > -hyun
> > >
> > > > ---
> > > > drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 ------
> > > > 1 file changed, 6 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > > > index a455cfc1bee5..98bd48f13fd1 100644
> > > > --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > > > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > > > @@ -242,12 +242,6 @@ static const u32 scaling_factors_565[] = {
> > > > ZYNQMP_DISP_AV_BUF_5BIT_SF,
> > > > };
> > > >
> > > > -static const u32 scaling_factors_666[] = {
> > > > - ZYNQMP_DISP_AV_BUF_6BIT_SF,
> > > > - ZYNQMP_DISP_AV_BUF_6BIT_SF,
> > > > - ZYNQMP_DISP_AV_BUF_6BIT_SF,
> > > > -};
> > > > -
> > > > static const u32 scaling_factors_888[] = {
> > > > ZYNQMP_DISP_AV_BUF_8BIT_SF,
> > > > ZYNQMP_DISP_AV_BUF_8BIT_SF,
> > > > --
> > > > 2.25.4
> > > >
> >
> > --
> > Daniel Vetter
> > Software Engineer, Intel Corporation
> > http://blog.ffwll.ch
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-12 0:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-10 14:06 [PATCH] drm: xlnx: remove defined but not used 'scaling_factors_666' Jason Yan
2020-09-10 18:14 ` Hyun Kwon
2020-09-11 8:15 ` Daniel Vetter
2020-09-11 16:27 ` Hyun Kwon
2020-09-12 0:45 ` Hyun Kwon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).