* [PATCH] spi: bcm2835: Make polling_limit_us static
@ 2020-09-12 7:22 Jason Yan
2020-09-14 14:52 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-09-12 7:22 UTC (permalink / raw)
To: broonie, f.fainelli, rjui, sbranden, bcm-kernel-feedback-list,
nsaenzjulienne, linux-spi, linux-rpi-kernel, linux-arm-kernel
Cc: Hulk Robot, Jason Yan
This eliminates the following sparse warning:
drivers/spi/spi-bcm2835.c:78:14: warning: symbol 'polling_limit_us' was
not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/spi/spi-bcm2835.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-bcm2835.c b/drivers/spi/spi-bcm2835.c
index 5519f1eda238..b87116e9b413 100644
--- a/drivers/spi/spi-bcm2835.c
+++ b/drivers/spi/spi-bcm2835.c
@@ -75,7 +75,7 @@
#define DRV_NAME "spi-bcm2835"
/* define polling limits */
-unsigned int polling_limit_us = 30;
+static unsigned int polling_limit_us = 30;
module_param(polling_limit_us, uint, 0664);
MODULE_PARM_DESC(polling_limit_us,
"time in us to run a transfer in polling mode\n");
--
2.25.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] spi: bcm2835: Make polling_limit_us static
2020-09-12 7:22 [PATCH] spi: bcm2835: Make polling_limit_us static Jason Yan
@ 2020-09-14 14:52 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2020-09-14 14:52 UTC (permalink / raw)
To: f.fainelli, bcm-kernel-feedback-list, rjui, linux-rpi-kernel,
Jason Yan, linux-spi, sbranden, nsaenzjulienne, linux-arm-kernel
Cc: Hulk Robot
On Sat, 12 Sep 2020 15:22:11 +0800, Jason Yan wrote:
> This eliminates the following sparse warning:
>
> drivers/spi/spi-bcm2835.c:78:14: warning: symbol 'polling_limit_us' was
> not declared. Should it be static?
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: bcm2835: Make polling_limit_us static
commit: cbd632ea8ee4ae07d12e85ed07aa5d667a1f47d8
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-14 14:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-12 7:22 [PATCH] spi: bcm2835: Make polling_limit_us static Jason Yan
2020-09-14 14:52 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).