From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F38DC43461 for ; Sun, 13 Sep 2020 23:29:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB05921D80 for ; Sun, 13 Sep 2020 23:29:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iQEAzGh8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=beagleboard-org.20150623.gappssmtp.com header.i=@beagleboard-org.20150623.gappssmtp.com header.b="LbtnCqyg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB05921D80 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=beagleboard.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=J7s73sHCVIPmAEdaqVHW1Bh+c4qyofBqcSq0bXj5WC8=; b=iQEAzGh81inbyMwVbFU0awXE8 ke5ycJd5ns5iu43HI6XMCZTdiF/bkCn4WGXb9Psl9Mgn+r/ZF9l1SSjMRCKSG/zClrBdpboOpRoPm kG/EyCUsPRHVc7BH25Zc5iEHrE1e2NUaGZ0fmsinNtMhKLh5Ffp17qZcW5PPoMsjpgHLcBng9YU0y rszKyIYd9efuMReIt+OARIVhNBC0J8Qp9mE19LDReP8O3uIaSxfa1sQ9OFPo36Qt0ETydAV4bXcnD e0yVdtIW1me8YiSLIRPtZUgUXGJBq8zQ6RNZMuFNQN7FVhjWzQXT+Rsk+maZJ3D+4RNOaipYHvqzl w6zwH3D0w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHbP3-0005aw-EQ; Sun, 13 Sep 2020 23:27:25 +0000 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHbP0-0005aY-8l for linux-arm-kernel@lists.infradead.org; Sun, 13 Sep 2020 23:27:23 +0000 Received: by mail-ej1-x641.google.com with SMTP id p9so20619322ejf.6 for ; Sun, 13 Sep 2020 16:27:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7v1NPAzkydR89JgSgtMekj7yJTyNSI10q1eiI/1zrxo=; b=LbtnCqygM/AuEhSdhgY7FRI2gjpUMcxbHXdfb0uHIYeZA9t2vwKhMboyANhMt+5f67 qvP9iZ5nFKResiZfOg14T1PJKOFCcBkJeb8i5gSc/PUsuz13KLo38haND0jXqkp/Kj0d 5EEIUQFMlCLklphxKJd3PNUc+J4+66ohkvBfI99e+gc1lMr6ORQj4FIclvYNdUrbCop5 5OIayk+vT1zzsgy0UtOTUKxkO7YDVNuZ5Wr7r/uRY60Fp+9CTZz5Kum22fzHgASJk4U4 Kws1Gz4Y06JJzEouM/B/ntLM7vGqqU73D085Uw+j+V7ThIfmhlec9Y6j21mNBB7hnUzG I6wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7v1NPAzkydR89JgSgtMekj7yJTyNSI10q1eiI/1zrxo=; b=IMsIUDRdnmu+cK2rpj+N6bdT/RjxSh6z3OtFFzYGusl+qizIr+peA8WPvx4CBsANE7 qq6MQJPOWkpv8J3IFe+0mpdzcGYLiDmu2DhsUeJ810gl1xshTx0EC1Q+C7BmEu/lThFU VW8dLw4Tk8PYNPizpWl/UXqPE5qU2CoLkVRYQcwwo7IyIykMiwMTg5RM6cBUcQGF6GPy g6tS4OHA+Y0t1Qg3Nw/FxhYD8NwTqmRN43e7nQh1+/PvuCWZ82i4Ll1SbmMvV1GQviZR NYDCdeXQaog86FOHstxyOm9n4MkUvswrw88UBbAurcFN+oODRys9pkM1u6470Ah0UncI dOww== X-Gm-Message-State: AOAM530c7ZECGpZFQL8sZav56GQOu33tCXwrTQTgjiYUA+p8ldAAGhZT jXjoyhg16RH0uyUYmFh6MSs4wg== X-Google-Smtp-Source: ABdhPJwUHzdDh00QRhRrdeDG6VXAgb0lLJ45sQRWLXSg9W49GeB8WQ7hHXcKFEid7iQQR9GZYllpnA== X-Received: by 2002:a17:906:4cd6:: with SMTP id q22mr11753793ejt.139.1600039639010; Sun, 13 Sep 2020 16:27:19 -0700 (PDT) Received: from x1 ([2604:a880:400:d0::26:8001]) by smtp.gmail.com with ESMTPSA id br7sm6356560ejb.76.2020.09.13.16.27.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2020 16:27:18 -0700 (PDT) Date: Mon, 14 Sep 2020 01:27:11 +0200 From: Drew Fustini To: Trent Piepho Subject: Re: [PATCH v4 1/2] pinctrl: single: parse #pinctrl-cells = 2 Message-ID: <20200913232711.GA2065644@x1> References: <20200701013320.130441-1-drew@beagleboard.org> <20200701013320.130441-2-drew@beagleboard.org> <3139716.CMS8C0sQ7x@zen.local> <20200913194233.GA1955808@x1> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200913194233.GA1955808@x1> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200913_192722_327665_B985818B X-CRM114-Status: GOOD ( 29.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jason Kridner , Tony Lindgren , Linus Walleij , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Rob Herring , Haojian Zhuang , bcousson@baylibre.com, linux-omap@vger.kernel.org, Robert Nelson , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Sep 13, 2020 at 09:42:33PM +0200, Drew Fustini wrote: > On Tue, Sep 08, 2020 at 04:52:58PM -0700, Trent Piepho wrote: > > On Tuesday, June 30, 2020 6:33:19 PM PDT Drew Fustini wrote: > > > If "pinctrl-single,pins" has 3 arguments (offset, conf, mux), then > > > pcs_parse_one_pinctrl_entry() does an OR operation on conf and mux to > > > get the value to store in the register. > > > > > > > - vals[found].val = pinctrl_spec.args[1]; > > > + > > > + switch (pinctrl_spec.args_count) { > > > + case 2: > > > + vals[found].val = pinctrl_spec.args[1]; > > > + break; > > > + case 3: > > > + vals[found].val = (pinctrl_spec.args[1] | > > pinctrl_spec.args[2]); > > > + break; > > > + } > > > > > > dev_dbg(pcs->dev, "%pOFn index: 0x%x value: 0x%x\n", > > > pinctrl_spec.np, offset, > > pinctrl_spec.args[1]); > > > > If #pinctrl-cells value is greater than 2, nothing will set vals[found].val to > > anything other than zero (from when it's calloc'ed) and the pinctrl will > > silently be programmed to zero. > > If #pinctrl-cells is 3, then it will be: > > vals[found].val = (pinctrl_spec.args[1] | pinctrl_spec.args[2]); > > Do you mean if #pinctrl-cells is great than 3 then it will just have a > default value of zero? > > That does appear to be the case and is probably not the behavior we > want. Thank you for pointing this out. Earlier, there is a check to > make sure there are at least 2 arguments: > > if (pinctrl_spec.args_count < 2) { > dev_err(pcs->dev, "invalid args_count for spec: %i\n", > pinctrl_spec.args_count); > break; > } > > I'll submit a patch where the upper bound is also checked: > > if (pinctrl_spec.args_count < 2 || pinctrl_spec.args_count > 3) { > dev_err(pcs->dev, "invalid args_count for spec: %i\n", > pinctrl_spec.args_count); > break; > } > I was mistaken when I wrote the above. I was using the term #pinctrl-cells when I should have been writing pinctrl_spec.args_count. pinctrl_spec.args_count is 2 when #pictrl-cells is 1. pinctrl_spec.args_count is 3 when #pictrl-cells is 2. I have submitted patches [1][2] with fixes for the bounds check and the dev_dbg(). > > The debug printout was not change to print vals[found].val, so it will > > continue to print the value of the 2nd cell. > > Thank you for pointing this out. Yes, this is an oversight and I will > submit a patch. > > > The result is that a #pinctrl-cells of 3 will produce no warning or error, > > program the pinctrl to zero, whilst at the same time emit debug log messages > > that it is programming the expected values. > > > > The device tree documentation still states that #pinctrl-cells must be 1 when > > using pinctrl-single,pins. This new special case of ORing two values is not > > documented. > > This is a good point, too. I will make a patch to update the > documentation. > > > -Drew [1] https://lore.kernel.org/linux-omap/20200913231557.2063071-1-drew@beagleboard.org/ [2] https://lore.kernel.org/linux-omap/20200913230306.2061645-1-drew@beagleboard.org/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel