From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9170FC433E2 for ; Mon, 14 Sep 2020 20:33:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4843620E65 for ; Mon, 14 Sep 2020 20:33:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hr1tDjvf"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="fLq43tsj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4843620E65 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xyFnN/LOpigsmAXM/U831plzAL+40EDHEmJV+6HZyVc=; b=hr1tDjvfcTnlmsn/rOP9yMVq9 mjghrbkymdYxm05U/UC4y+uNuwJ2Eo4ZvPqaC3RR/POMgpmIKJ8mE/FSxzaGGJC5XkNN0PyzC0nY4 5x9FTHiWtC4Ze5+Jtfjy1YngkUGBzYMUI7oFikP56WF0GwQ4O3WApjLNFt5teICSFsHVgGDQAF/dJ 2awTh35Vg7+RVNgU/8+6VcA0lIFrjjIqutXSOMZOr35+XcyUiuagnYI5m9yMG/45FKL/jGUeIsuaM O1peL2hyWDBwLbdlR6Ou7Wopqmh8nEYCVjQLX2fIc3SBdjUWtf9ZQdiPi4W0z5BB4aX1q3TrbN8L5 VlTZStzZA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHv97-000099-0B; Mon, 14 Sep 2020 20:32:17 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHv93-00007o-7d for linux-arm-kernel@lists.infradead.org; Mon, 14 Sep 2020 20:32:14 +0000 Received: by mail-pl1-x642.google.com with SMTP id r19so71987pls.1 for ; Mon, 14 Sep 2020 13:32:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=MAegNs4VOwWv9UrQbG/3KsC+fif9tz3H9h+v9DTenlg=; b=fLq43tsj0idL5YeRKTDNHNUi+/bcp9W/YMHPxve4qth42qg71hfTUM5Xq3cazIdDrI NFB+4SH1S70GAC48b8DplcyZACd4EXVyXgXskD80RFmDCDa/3pUt9RLyrlu1vxpWwB4f i2X0eeheLlVij915s5y5BUr4hEXriYpLc1OPM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MAegNs4VOwWv9UrQbG/3KsC+fif9tz3H9h+v9DTenlg=; b=SEIikeiJpmW1a1Pa9Iin1SUvKx7He+lrLdhc9Y/3/rG1A1A491/b1YsDmgd4d1XhtS al1scEJ2NrCg69N+N8Omj1OM7yagZjeCnLXebHwI4/VXovL8h4axRLepVOI3RrRyLUIb yJgSQEXfMb7duknX2q0qcTZlzurd2kMKd+JHhQgfTzyIgLs7OHkfz94QO35zw+ACPewF UUK5W1plcr4VuzI2pvpgWB99EvK1I72JN0kmj+llsc30SpUkQeLSH4GgC46T0RD+Sva8 f072cafgalMosudIkKmUTyvXB/EfI5tW8G8l9T5mPM9EeryVzu2iLe8syk+0nf5Gg6Hv gGbA== X-Gm-Message-State: AOAM531oWxXHkDD4F1QhiREy8b4O0T7pRf8YiSK59+Bw+jdRq375T7lA XVLUdSYYCc9m6XlfcK5BPY0tTw== X-Google-Smtp-Source: ABdhPJwLrAeD4ZMb7OCOucEtPSfmxZNEDPJonNkzAiZJUR7jlcfwd9QjlJseUiJhoAyO2uqhAGri2A== X-Received: by 2002:a17:90b:364c:: with SMTP id nh12mr972235pjb.182.1600115531070; Mon, 14 Sep 2020 13:32:11 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id j19sm11207357pfi.51.2020.09.14.13.32.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 13:32:10 -0700 (PDT) Date: Mon, 14 Sep 2020 13:32:09 -0700 From: Kees Cook To: Michael Ellerman Subject: Re: [PATCH 00/15] selftests/seccomp: Refactor change_syscall() Message-ID: <202009141321.366935EF52@keescook> References: <20200912110820.597135-1-keescook@chromium.org> <87wo0wpnah.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87wo0wpnah.fsf@mpe.ellerman.id.au> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200914_163213_346584_B0D158ED X-CRM114-Status: GOOD ( 17.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thadeu Lima de Souza Cascardo , Will Drewry , linux-xtensa@linux-xtensa.org, linux-kernel@vger.kernel.org, Andy Lutomirski , Max Filippov , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Christian Brauner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 14, 2020 at 10:15:18PM +1000, Michael Ellerman wrote: > Kees Cook writes: > > Hi, > > > > This refactors the seccomp selftest macros used in change_syscall(), > > in an effort to remove special cases for mips, arm, arm64, and xtensa, > > which paves the way for powerpc fixes. > > > > I'm not entirely done testing, but all-arch build tests and x86_64 > > selftests pass. I'll be doing arm, arm64, and i386 selftests shortly, > > but I currently don't have an easy way to check xtensa, mips, nor > > powerpc. Any help there would be appreciated! > > The series builds fine for me, and all the tests pass (see below). > > Thanks for picking up those changes to deal with powerpc being oddball. > > Tested-by: Michael Ellerman (powerpc) Awesome; thanks! However... > > cheers > > > ./seccomp_bpf > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > # RUN global.kcmp ... > # OK global.kcmp > ok 1 global.kcmp > [...] > # RUN global.KILL_thread ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. Was this a mis-paste, or has something very very bad happened here in global.KILL_one_arg_six finishes? > # RUN global.kcmp ... > # OK global.kcmp > ok 1 global.kcmp > [...] > # RUN global.user_notification_basic ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_basic ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_signal ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_closed_listener ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_child_pid_ns ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_sibling_pid_ns ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_sibling_pid_ns ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_sibling_pid_ns ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_fault_recv ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_continue ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_filter_empty ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_filter_empty_threaded ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_addfd ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_addfd_rlimit ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # PASSED: 86 / 86 tests passed. > # Totals: pass:86 fail:0 xfail:0 xpass:0 skip:0 error:0 And after every user_notification test? O_O -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel