From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 398E7C433E2 for ; Tue, 15 Sep 2020 00:52:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C268420897 for ; Tue, 15 Sep 2020 00:52:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IjaRy+Dj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C268420897 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QHFtdbIl/cCNaACqLOSA+AxVoVBDBskY9UxvfDS/mY4=; b=IjaRy+DjuTQE/VIg489tlvkSj UphUVHfOyy+hkHPDEkg1bZNHtjFxTjAQ2PJoAyGMYVApaMU6OEicXhK35/tUkXa2m08qAz7isxEMD OqVoec189k+e7ma0IHvvVS0jKTe4VoWRXBpEnYC5IgSQaDsTfJs2wihLPT5RckA9zsHYcUBv6cEXl eys/swtO48CNsugP/9j5LVOxSZa2OKF7Z+iIxX75xvA8hEVNfiPboY2fsveB5QBkgPc3IM1I7XuMi PAh/RW9lRyowx6tk9FbPz4pIIs2/G9vvRoGniuJy2wJvBquAaRI52kzqTpBP0oIlAmF6cG5RoYFNP klLcbgqGQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHzBE-0008G6-HJ; Tue, 15 Sep 2020 00:50:44 +0000 Received: from mail-io1-f66.google.com ([209.85.166.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHzBB-0008FX-Qh for linux-arm-kernel@lists.infradead.org; Tue, 15 Sep 2020 00:50:42 +0000 Received: by mail-io1-f66.google.com with SMTP id y13so2233078iow.4 for ; Mon, 14 Sep 2020 17:50:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=numAVrZHb/8qHZ8ZB/q47ZsqxyQJj3mtvFr+S2iyq1s=; b=X8xsiXLvJnVMHeT5Ch0ZkdNAeMb8IimyizMcgH762/SMDfbvsJI+fWQUHACL7J6YAv aQ6NeZc+ThwquGbpqCNAVmKqkg+ZwJegkSGWVmbZmQzeo11uYxWe1pQs9JNr/8o2B9ZE VLta4JYfVppUOgRB5jVkCBGtWyg9DZX74TJIyNKZCtp42Xl9z5+IQ3G/bSDZNOOE3ULG 3RH8Qmxw5aPj0A+kKjmPbS30v1++Z0S4+TUV4lYolZ4HpUSBaWYS+WEEimYEFJjC6ReM nKiAZxshFQJieY8P+LuA4QqtEo1pITysLSXzvTlsouZL+D8VKpTNIwP44T/ZmniTCdfQ 0ryQ== X-Gm-Message-State: AOAM530BzPWo6jp3VHMa5YvGDXqo2QbEQJ0A9HxlVqYmQ7UM9lHzkGVJ j78tL6RQVlDU7pH3mFQ8hQ== X-Google-Smtp-Source: ABdhPJzkrOQ/Tj7bU50E5bkevBB2M2BB4OOXNmNinYGgnhVgF/+j7fw6h1GCd5QDyj11FlbJwqaGpw== X-Received: by 2002:a02:a305:: with SMTP id q5mr15660693jai.121.1600131041000; Mon, 14 Sep 2020 17:50:41 -0700 (PDT) Received: from xps15 ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id s85sm8227021ilk.35.2020.09.14.17.50.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 17:50:40 -0700 (PDT) Received: (nullmailer pid 604109 invoked by uid 1000); Tue, 15 Sep 2020 00:50:34 -0000 Date: Mon, 14 Sep 2020 18:50:34 -0600 From: Rob Herring To: Jonathan =?iso-8859-1?Q?Neusch=E4fer?= Subject: Re: [PATCH v2 02/10] dt-bindings: mfd: Add binding for Netronix's embedded controller Message-ID: <20200915005034.GA593718@bogus> References: <20200905133230.1014581-1-j.neuschaefer@gmx.net> <20200905133230.1014581-3-j.neuschaefer@gmx.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200905133230.1014581-3-j.neuschaefer@gmx.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200914_205041_873680_C6618D90 X-CRM114-Status: GOOD ( 25.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Heiko Stuebner , devicetree@vger.kernel.org, Linus Walleij , Thierry Reding , Fabio Estevam , linux-rtc@vger.kernel.org, Arnd Bergmann , Mauro Carvalho Chehab , Sam Ravnborg , Daniel Palmer , Andreas Kemnade , NXP Linux Team , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , linux-pwm@vger.kernel.org, Stephan Gerhold , allen , Sascha Hauer , Lubomir Rintel , Mark Brown , Lee Jones , linux-arm-kernel@lists.infradead.org, Alessandro Zummo , linux-kernel@vger.kernel.org, Pengutronix Kernel Team , Heiko Stuebner , Josua Mayer , Shawn Guo , "David S. Miller" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Sep 05, 2020 at 03:32:22PM +0200, Jonathan Neusch=E4fer wrote: > This EC is found in e-book readers of multiple brands (e.g. Kobo, > Tolino), and is typically implemented as a TI MSP430 microcontroller. > = > It controls different functions of the system, such as power on/off, > RTC, PWM for the backlight. The exact functionality provided can vary > between boards. > = > Signed-off-by: Jonathan Neusch=E4fer > --- > v2: > - Add the plaintext DT binding for comparison > = > = > For reference, here is the binding in text form: > = > Netronix Embedded Controller > = > This EC is found in e-book readers of multiple brands (e.g. Kobo, Tolin= o), and > is typically implemented as a TI MSP430 microcontroller. > = > = > Required properties: > - compatible: should be "netronix,ntxec" > - reg: The I2C address of the EC > = > Optional properties: > - system-power-controller: > See Documentation/devicetree/bindings/power/power-controller.txt > - interrupts or interrupts-extended > - interrupt-controller > - #interrupt-cells: Should be 1 > = > Optional subnodes: > = > Sub-nodes are identified by their compatible string. > = > compatible string | description > --------------------------------|-------------------------------------- > netronix,ntxec-pwm | PWM (used for backlight) > netronix,ntxec-rtc | real time clock > = > = > Example: > = > &i2c3 { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_i2c3>; > status =3D "okay"; > = > ec: embedded-controller@43 { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_ntxec>; > = > compatible =3D "netronix,ntxec"; > reg =3D <0x43>; > system-power-controller; > interrupt-parent =3D <&gpio4>; > interrupts =3D <11 IRQ_TYPE_EDGE_FALLING>; > interrupt-controller; > #interrupt-cells =3D <1>; > = > pwm { > compatible =3D "netronix,ntxec-pwm"; > #pwm-cells =3D <2>; > }; > = > rtc { > compatible =3D "netronix,ntxec-rtc"; > interrupts-extended =3D <&ec 15>; > interrupt-names =3D "alarm"; > }; > }; > }; > --- > .../bindings/mfd/netronix,ntxec.yaml | 57 +++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/netronix,ntxec.= yaml > = > diff --git a/Documentation/devicetree/bindings/mfd/netronix,ntxec.yaml b/= Documentation/devicetree/bindings/mfd/netronix,ntxec.yaml > new file mode 100644 > index 0000000000000..596df460f98eb > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/netronix,ntxec.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/netronix,ntxec.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Netronix Embedded Controller > + > +maintainers: > + - Jonathan Neusch=E4fer > + > +description: | > + This EC is found in e-book readers of multiple brands (e.g. Kobo, Toli= no), and > + is typically implemented as a TI MSP430 microcontroller. > + > + > +properties: > + compatible: > + const: netronix,ntxec > + > + reg: > + items: > + - description: The I2C address of the EC > + > + system-power-controller: > + type: boolean > + description: See Documentation/devicetree/bindings/power/power-contr= oller.txt > + > + interrupts: > + minItems: 1 > + description: > + The EC can signal interrupts via a GPIO line > + > +required: > + - compatible > + - reg additionalProperties: false > + > +examples: > + - | > + #include > + i2c { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + ec: embedded-controller@43 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_ntxec>; > + > + compatible =3D "netronix,ntxec"; > + reg =3D <0x43>; > + system-power-controller; > + interrupt-parent =3D <&gpio4>; > + interrupts =3D <11 IRQ_TYPE_EDGE_FALLING>; > + interrupt-controller; > + #interrupt-cells =3D <1>; These need to be documented too. > + }; > + }; > -- > 2.28.0 > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel