From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9169BC433E2 for ; Tue, 15 Sep 2020 19:43:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B45020770 for ; Tue, 15 Sep 2020 19:43:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1buBWxI6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B45020770 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UGg9cWCJudmO3ZbrNhJNDsC9Xsq70Qkq2aEuxl2WRbQ=; b=1buBWxI6bnLVgxF7qfSHuaPAl 8p51nTP6uso/8WQVXDCS04SHXiA0Q8bhrrc5glvhXmQUdpb3eM8iT2GGTas6po0LmKukmA7/NG/sF HWC2Gl3znZoQrEBbKtFTdOiQjPyAC5UYmJV+YIb/BzrDq1KLIFsvSzNE13uVSES3axLLa/2pO/6F6 oV8kquKfB7AaxbgQaDQhTj5mYR7iXeyF9aex2UUvZF5O2YoO1Ua88uKHm+AAI5OMS5uYbnU3YjcWS j+p4C0d0O+/QuWEzEjGOHswTchQNBFLXD2UXy8o1lp49fkw85CwHzokAuXslUgvfCDj1aSwGR5t8B jcwEEkyag==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIGq2-0002jz-Ox; Tue, 15 Sep 2020 19:42:02 +0000 Received: from mail-io1-f66.google.com ([209.85.166.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIGq0-0002jJ-0S for linux-arm-kernel@lists.infradead.org; Tue, 15 Sep 2020 19:42:00 +0000 Received: by mail-io1-f66.google.com with SMTP id j2so5458809ioj.7 for ; Tue, 15 Sep 2020 12:41:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KoMBD7bZ7/04a7spyIzL/jABF0GGBoCw3/93FOBmre4=; b=IkmjoR75G36/bc9l/x+HBUT2LTqFFmkxPr+wcvKxEeYQjvMp2Jhc5e51Gp0pM2cKZa syfBak1Hibo85ZBPnpmkxrunsvLaWMXMmVcHausa8OMMtihuXdDxeZWmYCQZi5GYX6N1 bmjbQGpjVmp9mq2kN8sdlTUE2WK1TLemc7Gl+ad4+2Eza7j4p9GO4uBbYkjubckyy3Ai 0lN62oKRm2FTWl1oWk8IOc8VDMIOnB39reMH4suP2CZKtdeDYoldGFhtv1uR1lbocdPg 4zMmioG/1qY42qGZwYR+D9L//rT48juPNjPqWlV2rrHzNfTZHo43cMLpQ6c+8vInVS7T zHcA== X-Gm-Message-State: AOAM531zRnIwKl6MsBsZypRFJIU6cLOJtpriaDExgc5GiNAkgwrvZqyn ypmsZCitl3qQCXi3ROS85A== X-Google-Smtp-Source: ABdhPJxqHEezzhn9NZakudm0c7bkFStWclj5gAvuy/jB4WnxJpwrisZHOrKO0Yx62rktPyobQBmN2g== X-Received: by 2002:a6b:d606:: with SMTP id w6mr16186811ioa.89.1600198919002; Tue, 15 Sep 2020 12:41:59 -0700 (PDT) Received: from xps15 ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id p9sm8125532iov.18.2020.09.15.12.41.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 12:41:58 -0700 (PDT) Received: (nullmailer pid 2379577 invoked by uid 1000); Tue, 15 Sep 2020 19:41:57 -0000 Date: Tue, 15 Sep 2020 13:41:57 -0600 From: Rob Herring To: Krzysztof Kozlowski Subject: Re: [PATCH v3 1/4] dt-bindings: i2c: imx-lpi2c: Add properties and use unevaluatedProperties Message-ID: <20200915194157.GA2377739@bogus> References: <20200910182244.5815-1-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200910182244.5815-1-krzk@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200915_154200_058301_24410F1D X-CRM114-Status: GOOD ( 19.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Wolfram Sang , Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 10, 2020 at 08:22:41PM +0200, Krzysztof Kozlowski wrote: > Additional properties actually might appear (e.g. power-domains) so > describe all typical properties, reference generic i2c schema and use > unevaluatedProperties to fix dtbs_check warnings like: > > arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml: i2c@5a800000: > 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+' > > arch/arm64/boot/dts/freescale/imx8qxp-colibri-eval-v3.dt.yaml: i2c@5a800000: > 'touchscreen@2c' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v2: > 1. Add assigned-clock-parents > > Changes since v1: > 1. Add more properties and include /schemas/i2c/i2c-controller.yaml# > --- > .../bindings/i2c/i2c-imx-lpi2c.yaml | 20 +++++++++++++++++-- > 1 file changed, 18 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml > index ac0bc5dd64d6..918535b33384 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml > @@ -9,6 +9,9 @@ title: Freescale Low Power Inter IC (LPI2C) for i.MX > maintainers: > - Anson Huang > > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + > properties: > compatible: > enum: > @@ -16,29 +19,42 @@ properties: > - fsl,imx8qxp-lpi2c > - fsl,imx8qm-lpi2c > > + '#address-cells': true > + '#size-cells': true Can drop these as they are in i2c-controller.yaml. > + > reg: > maxItems: 1 > > interrupts: > maxItems: 1 > > + assigned-clock-parents: true > + assigned-clock-rates: true > + assigned-clocks: true > + clock-frequency: true > + > + clock-names: > + maxItems: 1 > + > clocks: > maxItems: 1 > > + power-domains: true How many? > + > required: > - compatible > - reg > - interrupts > - clocks > > -additionalProperties: false > +unevaluatedProperties: false > > examples: > - | > #include > #include > > - lpi2c7@40a50000 { > + i2c@40a50000 { > compatible = "fsl,imx7ulp-lpi2c"; > reg = <0x40A50000 0x10000>; > interrupt-parent = <&intc>; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel