* [PATCH v2 1/2] dt-bindings: iio: adc: exynos-adc: require second interrupt with touch screen
@ 2020-09-10 16:19 Krzysztof Kozlowski
2020-09-10 16:19 ` [PATCH v2 2/2] dt-bindings: iio: adc: exynos-adc: do not require syscon on S5Pv210 Krzysztof Kozlowski
2020-09-15 19:44 ` [PATCH v2 1/2] dt-bindings: iio: adc: exynos-adc: require second interrupt with touch screen Rob Herring
0 siblings, 2 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-10 16:19 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Rob Herring, Kukjin Kim,
Krzysztof Kozlowski, linux-iio, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
The ADC in S3C/S5P/Exynos SoCs can be used also for handling touch
screen. In such case the second interrupt is required. This second
interrupt can be anyway provided, even without touch screens. This
fixes dtbs_check warnings like:
arch/arm/boot/dts/s5pv210-aquila.dt.yaml: adc@e1700000: interrupts: [[23], [24]] is too long
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huwei.com>
---
Changes since v1:
1. Fix if:has-touchscreen, as pointed by Rob.
2. Add Ack.
---
.../bindings/iio/adc/samsung,exynos-adc.yaml | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
index cc3c8ea6a894..17a08be3fe85 100644
--- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
@@ -41,7 +41,10 @@ properties:
maxItems: 2
interrupts:
- maxItems: 1
+ description:
+ ADC interrupt followed by optional touchscreen interrupt.
+ minItems: 1
+ maxItems: 2
"#io-channel-cells":
const: 1
@@ -107,6 +110,15 @@ allOf:
items:
- const: adc
+ - if:
+ required:
+ - has-touchscreen
+ then:
+ properties:
+ interrupts:
+ minItems: 2
+ maxItems: 2
+
examples:
- |
adc: adc@12d10000 {
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] dt-bindings: iio: adc: exynos-adc: do not require syscon on S5Pv210
2020-09-10 16:19 [PATCH v2 1/2] dt-bindings: iio: adc: exynos-adc: require second interrupt with touch screen Krzysztof Kozlowski
@ 2020-09-10 16:19 ` Krzysztof Kozlowski
2020-09-15 19:45 ` Rob Herring
2020-09-15 19:44 ` [PATCH v2 1/2] dt-bindings: iio: adc: exynos-adc: require second interrupt with touch screen Rob Herring
1 sibling, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-10 16:19 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Rob Herring, Kukjin Kim,
Krzysztof Kozlowski, linux-iio, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
The ADC in S5Pv210 does not have ADC phy registers in separate block for
which syscon would be needed. Remove this requirement to fix dtbs_check
warnings like:
arch/arm/boot/dts/s5pv210-fascinate4g.dt.yaml: adc@e1700000: 'samsung,syscon-phandle' is a required property
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huwei.com>
---
Changes since v1:
1. Add Ack.
---
.../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
index 17a08be3fe85..37d6591ff78c 100644
--- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
@@ -81,7 +81,6 @@ allOf:
- samsung,exynos-adc-v2
- samsung,exynos3250-adc
- samsung,exynos4212-adc
- - samsung,s5pv210-adc
then:
required:
- samsung,syscon-phandle
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: iio: adc: exynos-adc: require second interrupt with touch screen
2020-09-10 16:19 [PATCH v2 1/2] dt-bindings: iio: adc: exynos-adc: require second interrupt with touch screen Krzysztof Kozlowski
2020-09-10 16:19 ` [PATCH v2 2/2] dt-bindings: iio: adc: exynos-adc: do not require syscon on S5Pv210 Krzysztof Kozlowski
@ 2020-09-15 19:44 ` Rob Herring
2020-09-16 6:17 ` Krzysztof Kozlowski
1 sibling, 1 reply; 6+ messages in thread
From: Rob Herring @ 2020-09-15 19:44 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Lars-Peter Clausen, linux-iio, linux-kernel,
Rob Herring, linux-samsung-soc, Kukjin Kim, Jonathan Cameron,
Peter Meerwald-Stadler, Hartmut Knaack, linux-arm-kernel
On Thu, 10 Sep 2020 18:19:32 +0200, Krzysztof Kozlowski wrote:
> The ADC in S3C/S5P/Exynos SoCs can be used also for handling touch
> screen. In such case the second interrupt is required. This second
> interrupt can be anyway provided, even without touch screens. This
> fixes dtbs_check warnings like:
>
> arch/arm/boot/dts/s5pv210-aquila.dt.yaml: adc@e1700000: interrupts: [[23], [24]] is too long
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: Jonathan Cameron <Jonathan.Cameron@huwei.com>
>
> ---
>
> Changes since v1:
> 1. Fix if:has-touchscreen, as pointed by Rob.
> 2. Add Ack.
> ---
> .../bindings/iio/adc/samsung,exynos-adc.yaml | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: iio: adc: exynos-adc: do not require syscon on S5Pv210
2020-09-10 16:19 ` [PATCH v2 2/2] dt-bindings: iio: adc: exynos-adc: do not require syscon on S5Pv210 Krzysztof Kozlowski
@ 2020-09-15 19:45 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2020-09-15 19:45 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, linux-samsung-soc, Lars-Peter Clausen, linux-iio,
linux-kernel, Rob Herring, linux-arm-kernel,
Peter Meerwald-Stadler, Hartmut Knaack, Kukjin Kim,
Jonathan Cameron
On Thu, 10 Sep 2020 18:19:33 +0200, Krzysztof Kozlowski wrote:
> The ADC in S5Pv210 does not have ADC phy registers in separate block for
> which syscon would be needed. Remove this requirement to fix dtbs_check
> warnings like:
>
> arch/arm/boot/dts/s5pv210-fascinate4g.dt.yaml: adc@e1700000: 'samsung,syscon-phandle' is a required property
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: Jonathan Cameron <Jonathan.Cameron@huwei.com>
>
> ---
>
> Changes since v1:
> 1. Add Ack.
> ---
> .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: iio: adc: exynos-adc: require second interrupt with touch screen
2020-09-15 19:44 ` [PATCH v2 1/2] dt-bindings: iio: adc: exynos-adc: require second interrupt with touch screen Rob Herring
@ 2020-09-16 6:17 ` Krzysztof Kozlowski
2020-09-16 18:03 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-16 6:17 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Rob Herring, Lars-Peter Clausen, devicetree, linux-iio,
linux-kernel, linux-samsung-soc, Rob Herring, Kukjin Kim,
Peter Meerwald-Stadler, Hartmut Knaack, linux-arm-kernel
On Tue, Sep 15, 2020 at 01:44:44PM -0600, Rob Herring wrote:
> On Thu, 10 Sep 2020 18:19:32 +0200, Krzysztof Kozlowski wrote:
> > The ADC in S3C/S5P/Exynos SoCs can be used also for handling touch
> > screen. In such case the second interrupt is required. This second
> > interrupt can be anyway provided, even without touch screens. This
> > fixes dtbs_check warnings like:
> >
> > arch/arm/boot/dts/s5pv210-aquila.dt.yaml: adc@e1700000: interrupts: [[23], [24]] is too long
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > Acked-by: Jonathan Cameron <Jonathan.Cameron@huwei.com>
> >
> > ---
> >
> > Changes since v1:
> > 1. Fix if:has-touchscreen, as pointed by Rob.
> > 2. Add Ack.
> > ---
> > .../bindings/iio/adc/samsung,exynos-adc.yaml | 14 +++++++++++++-
> > 1 file changed, 13 insertions(+), 1 deletion(-)
> >
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Jonathan,
Could you pick up these two?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: iio: adc: exynos-adc: require second interrupt with touch screen
2020-09-16 6:17 ` Krzysztof Kozlowski
@ 2020-09-16 18:03 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2020-09-16 18:03 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Lars-Peter Clausen, devicetree, linux-iio,
linux-kernel, linux-samsung-soc, Rob Herring, Kukjin Kim,
Peter Meerwald-Stadler, Hartmut Knaack, linux-arm-kernel
On Wed, 16 Sep 2020 08:17:47 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Tue, Sep 15, 2020 at 01:44:44PM -0600, Rob Herring wrote:
> > On Thu, 10 Sep 2020 18:19:32 +0200, Krzysztof Kozlowski wrote:
> > > The ADC in S3C/S5P/Exynos SoCs can be used also for handling touch
> > > screen. In such case the second interrupt is required. This second
> > > interrupt can be anyway provided, even without touch screens. This
> > > fixes dtbs_check warnings like:
> > >
> > > arch/arm/boot/dts/s5pv210-aquila.dt.yaml: adc@e1700000: interrupts: [[23], [24]] is too long
> > >
> > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > > Acked-by: Jonathan Cameron <Jonathan.Cameron@huwei.com>
> > >
> > > ---
> > >
> > > Changes since v1:
> > > 1. Fix if:has-touchscreen, as pointed by Rob.
> > > 2. Add Ack.
> > > ---
> > > .../bindings/iio/adc/samsung,exynos-adc.yaml | 14 +++++++++++++-
> > > 1 file changed, 13 insertions(+), 1 deletion(-)
> > >
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
>
> Jonathan,
>
> Could you pick up these two?
Done. Applied to the togreg branch of iio.git and pushed out
as testing for the autobuilders to possibly poke them.
Thanks,
Jonathan
>
> Best regards,
> Krzysztof
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-16 18:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-10 16:19 [PATCH v2 1/2] dt-bindings: iio: adc: exynos-adc: require second interrupt with touch screen Krzysztof Kozlowski
2020-09-10 16:19 ` [PATCH v2 2/2] dt-bindings: iio: adc: exynos-adc: do not require syscon on S5Pv210 Krzysztof Kozlowski
2020-09-15 19:45 ` Rob Herring
2020-09-15 19:44 ` [PATCH v2 1/2] dt-bindings: iio: adc: exynos-adc: require second interrupt with touch screen Rob Herring
2020-09-16 6:17 ` Krzysztof Kozlowski
2020-09-16 18:03 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).