From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8603C43461 for ; Tue, 15 Sep 2020 19:56:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F93520809 for ; Tue, 15 Sep 2020 19:56:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jv5jeT3M"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vbKyE1eG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F93520809 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=p6LvMpN6RchUqNaHHiUnL154bRh5T9Nn+GzVW1paP+s=; b=jv5jeT3Mfnwl+Z2bMPW+GAaMv DpN5dMUQ/UV6uQDRI+02ijGcUA8EcUEo/GMFStn7ix48wpkkCQZOlHu7BenW0JIS3pNkxPwCRvdld gKGMXkjLePaUb+I380oWu/RiLV4K+DC7QvEjI3eu95x2l/kGHvseK+cpwv03ukhe9eO/Y+/rf/3l3 mDcYFXa2N5qzhUVORzUN0d0MzjFPktvMN+7OrTNpC7z4CiT9clCvCi6FMgzpGHmmQb7HYEczvVUW6 7CmA4gJXUeGNs8PQo11AXAH7E25DQMgfuOPpii1MNrzroZaN9sEiNEUfrAd4LBk5HIppU2lVv56U5 KbJ6bCmEw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIH2j-0005mL-VX; Tue, 15 Sep 2020 19:55:10 +0000 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIH2g-0005lV-Kg for linux-arm-kernel@lists.infradead.org; Tue, 15 Sep 2020 19:55:08 +0000 Received: by mail-pj1-x1043.google.com with SMTP id s14so414743pju.1 for ; Tue, 15 Sep 2020 12:55:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ANJOfSdlpRaHSBBO4TQnqknbM6J+0XuYtQl6sOjOU6g=; b=vbKyE1eGXl1ab37xPuCgN3XERmZgx8c72CmccznAaQT/qdPIFWgEvL2g7tdxHUje1+ uH3g5E43P/o9/UJXb7GQiTNIYyMi0BTbo9lWzld48up8d8Dpu5ogNRBAKeUa8TQgWld4 mXnM7bosw+BwFaU3OdjM3MkSleUZ0pAHWgLipyCpVaQWGWHMKkgE5EtkjCyhdPbfacRb BF4zvVAEvnt46T2LrUiCt+Ej1O5VNJn4gCUeqdOMVp0NP959/LyLVZ2HbrBpysEqZZ7U /glUHqltfoq9EtlZslQ0cG+F+Ocwp8nEhATulLHJinhygWWgTymGqXK7y09zkav+1GU6 8HAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ANJOfSdlpRaHSBBO4TQnqknbM6J+0XuYtQl6sOjOU6g=; b=nv6GF1/rsZQYI1MEV4ZGATEEffoB/JAqpZmJc4kp9FkUndyOKEfT5UAscf8OsqiWLY ZIOVKqo6MwjhDY+j2r5vE7b+OT/ADXK5s+o8aulb4WO4MtQ0S9BNEQJFWuDuR1ue62er VleKjXa6MxXm3k1+CZaBxAebHkphCcIo4o5mlBJ+2MCk5BbGLZP4FNA3kGKdwq7tcf4t zlTDx/6AehX8l2mkU1WLCXbg3fISu4KhS/OhI2u6RGzxDkRPEJLvIikaH+/ShCTQSsyG Q/1reE7DWTh+KRkxtA0hxNX5Ag3ruqjcK+PuqY45U/YFqRYlR5woZE6DnZOVZ82f6iDj fpmw== X-Gm-Message-State: AOAM532svANq4ZMYV3IV1DWcmz1v5h7+ntspollU0Z52zDUTr2YveUPd F8eegk4yeoCZ6x35+WOIMl177A== X-Google-Smtp-Source: ABdhPJypvLei95eAIfBf9YhOFqqQKZ1C34DJmEf5yt+0uB+ckb9ORNsADCaKLRMdqq9zVPIXlUuLOA== X-Received: by 2002:a17:902:9685:b029:d1:e5e7:be1b with SMTP id n5-20020a1709029685b02900d1e5e7be1bmr3266435plp.78.1600199704611; Tue, 15 Sep 2020 12:55:04 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id z4sm14594221pfr.197.2020.09.15.12.55.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 12:55:04 -0700 (PDT) Date: Tue, 15 Sep 2020 13:55:01 -0600 From: Mathieu Poirier To: Christoph Hellwig Subject: Re: [PATCH 6/6] dma-mapping: introduce DMA range map, supplanting dma_pfn_offset Message-ID: <20200915195501.GA3666944@xps15> References: <20200914073343.1579578-1-hch@lst.de> <20200914073343.1579578-7-hch@lst.de> <20200914230147.GA3251212@xps15> <20200915054122.GA18079@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200915054122.GA18079@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200915_155506_976982_96A3B695 X-CRM114-Status: GOOD ( 28.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-sh@vger.kernel.org, linux-pci@vger.kernel.org, linux-remoteproc@vger.kernel.org, Bjorn Andersson , Frank Rowand , Florian Fainelli , Russell King , linux-acpi@vger.kernel.org, Ohad Ben-Cohen , devicetree@vger.kernel.org, loic.pallardy.st.com@xps15, Rob Herring , Santosh Shilimkar , Nathan Chancellor , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org, arnaud.pouliquen@st.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Jim Quinlan , Robin Murphy Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 15, 2020 at 07:41:22AM +0200, Christoph Hellwig wrote: > On Mon, Sep 14, 2020 at 05:01:47PM -0600, Mathieu Poirier wrote: > > [700 lines of the fullquote deleted..] > > > > + for (r = map; r->size; r++) > > > + num_ranges++; > > > + > > > + new_map = kmemdup(map, array_size(num_ranges + 1, sizeof(*map)), > > > + GFP_KERNEL); > > > + if (!new_map) > > > + return -ENOMEM; > > > + to->dma_range_map = new_map; > > > + return 0; > > > +} > > > + > > > > This patch seemed Ok to me but it broke the stm32 remoteproc implementation. When > > I tested things out function dma_coerce_mask_and_cohenrent() returns -5 and the > > rest of the initialisation fails. I isolated things to function dma_to_pfn() > > [2]. In the original implementation __bus_to_pfn() returns 0xfffff and > > dev->dma_pfn_offset is equal to 0x38000. As such the function returns 0x137fff > > and dma_supported() a non-zero value[3]. > > > > With this set function dma_to_pfn() received a face lift. Function > > __bus_to_pfn() still returns 0xfffff but translate_dma_to_phys() returns 0, > > which forces dma_supported() to also return 0 and that is where the -5 (-EIO) > > comes from. > > > > Taking a futher look at translate_dma_to_phy(), @dma_addr never falls within the > > bus_dma_region ranges and returns 0. > > > > I'm suspecting an initialisation problem and if it occurred here, it will > > likely show up elsewhere. > > Can you try this incremental patch? > > diff --git a/include/linux/dma-direct.h b/include/linux/dma-direct.h > index 088c97181ab146..c6b21acba7a459 100644 > --- a/include/linux/dma-direct.h > +++ b/include/linux/dma-direct.h > @@ -46,7 +46,7 @@ static inline phys_addr_t translate_dma_to_phys(struct device *dev, > if (dma_addr >= m->dma_start && dma_addr - m->dma_start < m->size) > return (phys_addr_t)dma_addr + m->offset; > > - return 0; > + return (phys_addr_t)-1; That did the trick - the stm32 platform driver's probe() function completes and the remote processor is operatinal. That being said the value returned by function dma_to_pfn() is 0x137fff in the original code and 0xfffff with your patches applied. Thanks, Mathieu > } > > #ifdef CONFIG_ARCH_HAS_PHYS_TO_DMA _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel