From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F4C1C433E2 for ; Wed, 16 Sep 2020 15:26:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A04D8223D6 for ; Wed, 16 Sep 2020 15:26:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UKjIqHbz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A04D8223D6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TI6umVI7PkoLM5N801yY3benim6eQwF9V9s5tSIsxcs=; b=UKjIqHbzjoI49yKkqS0HoQ01b DRq0WRBprXCsgdTNAA0grgukv4uGpvZb6bhhSpEXhe4P1EhMxRS8YlxQlSNMxQqwnhYhJIlrkX64t +7aQ9b2xqIm672ldyDi2wTw4igYDRdAKVEVaV6POJeLXh9NuVgdlGeX3mzg1ytwVIq3yx4H31r0J1 orsvzv2bv1J0tgsmVvPuZ/xBaLwVy0WqO4sCyGwrIg+yOHdUEvFEERq6Oz8Iw3jp1PXIZRSRu2GwQ SIuAzDk+FfXRVbXv4MBlmhnL7Uvdhg3SfNA9qcRWDCL+geVzzbWK3cCfSZ15vcZUx5WaciDJbdxQd JWquPC3yw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIZIb-0007NQ-Kv; Wed, 16 Sep 2020 15:24:45 +0000 Received: from mail-il1-f196.google.com ([209.85.166.196]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIZIZ-0007Mx-5L; Wed, 16 Sep 2020 15:24:43 +0000 Received: by mail-il1-f196.google.com with SMTP id u18so6800124iln.13; Wed, 16 Sep 2020 08:24:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6G5lOpVUlHWWGXIZ1jolJG0Sb394B1bYevllH8NK7Gc=; b=h2GbsCjtSF0DhlzcQ4p5UJWlcmgr1DH5Lu9XU6vJucO0E9J7Obto27HlylANlEro8b xfiba+OiskAJeV0Y9ocN89ETJrTANkcnYISMcohLw+JA5oRD0XtFyMzQylmu0QFej8H+ NG7NB8aaJ4maRxeIz7+tP4Y0suyDFyRYMP/3f7iFzXy7qryCWJu3UDddE9BpjFppgm/U kYmhH3fwclg5kLSubhEMhY8xocL+Ef+W6pUwWdIeZH5ZZ2Ay5N7/Ha2waMPQVazGcU6y YkzArjJCG5lZ7kWMOpuf7Ud2oq8p/zhSv2+T6mU6rEwM1ziYU4+QKruTfnQ6PlkVZWen MdKQ== X-Gm-Message-State: AOAM530wgvyzXJoJHR9zCqPCWmYYOcuF1w3vzqjN182qMMHztroMYp6M +VWRouSCj1XJDy57ka/ySg== X-Google-Smtp-Source: ABdhPJzSoz+rtnLXZQoJdrYYoga5TX85PXPw9tY0/1eRJt6R8LO9wd1xaTDTXuLVykA3Ex3b8PSz4Q== X-Received: by 2002:a92:8e42:: with SMTP id k2mr6234382ilh.175.1600269881838; Wed, 16 Sep 2020 08:24:41 -0700 (PDT) Received: from xps15 ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id o15sm10747097ilc.41.2020.09.16.08.24.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 08:24:40 -0700 (PDT) Received: (nullmailer pid 3994603 invoked by uid 1000); Wed, 16 Sep 2020 15:24:38 -0000 Date: Wed, 16 Sep 2020 09:24:38 -0600 From: Rob Herring To: Jim Quinlan Subject: Re: [PATCH v12 05/10] PCI: brcmstb: Add bcm7278 PERST# support Message-ID: <20200916152438.GA3991893@bogus> References: <20200911175232.19016-1-james.quinlan@broadcom.com> <20200911175232.19016-6-james.quinlan@broadcom.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200911175232.19016-6-james.quinlan@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200916_112443_233702_1B7A877E X-CRM114-Status: GOOD ( 13.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Lorenzo Pieralisi , linux-pci@vger.kernel.org, open list , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Philipp Zabel , Bjorn Helgaas , Jim Quinlan , Robin Murphy , Christoph Hellwig , Nicolas Saenz Julienne Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 11, 2020 at 01:52:25PM -0400, Jim Quinlan wrote: > From: Jim Quinlan > > The PERST# bit was moved to a different register in 7278-type STB chips. > In addition, the polarity of the bit was also changed; for other chips > writing a 1 specified assert; for 7278-type chips, writing a 0 specifies > assert. Of course, PERST# is a PCIe asserted-low signal. > > While we are here, also change the bridge_sw_init_set() functions so like > the perst_set() functions they are chip specific and we no longer rely on > data wrt chip specific field mask and shift values. > > Signed-off-by: Jim Quinlan > Acked-by: Florian Fainelli > --- > drivers/pci/controller/pcie-brcmstb.c | 97 +++++++++++++++++++-------- > 1 file changed, 69 insertions(+), 28 deletions(-) Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel