From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CED9AC43461 for ; Thu, 17 Sep 2020 00:21:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7082320684 for ; Thu, 17 Sep 2020 00:21:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="r6K9JJc4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="rBlJl3SX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7082320684 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:From:Subject:References:Mime-Version:Message-Id: In-Reply-To:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ExY6buEL1b9b3wZVHLp4M49V840CMFFRGp39tmkl3NY=; b=r6K9JJc4QJ6R0WzhfDN6IY8RT g+PuOIQuAil+diaYlZfKq/LQtAE8RiZq82ZLcDIIkfHzS5bSiys6kUXDpozWl8As60iTtxBJ8jSZL mRq3+j1fRkNtPzZYvtwi3hYX5a4p/iAaS5LAACNC2X595Ew5JLikMp+4rkKoTfbxDLMVmm806XWfE LHvhEIc2fmlVA2mH/FYzNQtKCvK0iHMRydos+Az+qDp1lfx2mZhaBXRktlqnTBLtrSiwAonxRmb1H 6cEeNG9CdQdKQXkJvvwNSDqh15YTJNNDdVOm2CNr/ksKfIkaJ1381V5LNvaV+NVillivAbjagS7zp zQFXgv3DQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIheJ-0008VC-2b; Thu, 17 Sep 2020 00:19:43 +0000 Received: from mail-yb1-xb4a.google.com ([2607:f8b0:4864:20::b4a]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIheG-0008Tx-JR for linux-arm-kernel@lists.infradead.org; Thu, 17 Sep 2020 00:19:41 +0000 Received: by mail-yb1-xb4a.google.com with SMTP id 193so520841ybi.8 for ; Wed, 16 Sep 2020 17:19:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=+spLOPOqYEotDF2y8HQ3qi+ewoKqTD1Kc3/rTara360=; b=rBlJl3SXnzuNoP+/CYZPQ99ocjRmNYgBHzsNpUqS8tRmaaXkNFDiL8LiZkJBnSc30D ioYHkZlYVPY2/ZInNiot7dvrlDcK6d0op2AsjfEpJ1lG8kFPPNlbChiO6bJCoH9yX5eK CSmbESZRmWOWBptKgdealJtke9nzCfijbmzNCBloGxf0DvWqSNXu3kvJOX+nJTZewouf pRIwTYr5fCL6fKb7E1Ihb7KqNI+693GnUB0WSFOELf8v7gUyuA7T2sDr5Vyr6IKjL//S oH3VauqBHT252EEw17MgWJ7+0NgX7CtfubK5CrN1kMfxoCqXD1SCT2j9Ubn9c6Wdx4Aq iCqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=+spLOPOqYEotDF2y8HQ3qi+ewoKqTD1Kc3/rTara360=; b=eGgGPTIDXS/edNU2KYWgIi/DMiLZ8ZXqXzTQ+psicdBA5/uSMOsObrOHnbxrGqsLhW mNiDdGvnbvJ+v7pv+4WGGM0q3FNyHOuzQUOaedDpxVXRC+3Ecg4b1lWoIGy+hUBea0V9 xhve0P3gsVd5r1lbhIJ8GeBRgNaBJHNUDMNIUCeibt+TgYf0TbWXAsWPl8NkxBmPFYub 3SobTb8lk1hZe4RPh4MBIwVEkR35jFJQ6VHqPSdDT/uXX+7WyNKUio1NQAIx+pYWWDqM 5Otgggl/Mkal1xVoxhAh2MUoJtb5+Hb0QhKr/xOPFSRvFQh7HyTU4CPKLRincosVfzgl mnvQ== X-Gm-Message-State: AOAM5336moS7NnxJP/d/U0yzFaQexAUehvBgJNJIaUoSd6oo3gsnekq1 VnG8QlrMbfQOJKcicShBb8L6KPbDgtkky5jfMDY= X-Google-Smtp-Source: ABdhPJxFVnDgO0PkN03oaF3DVPp+VMqT0IyJLbNA+PK8/KYsKl3bGJWlYL1KXXFbTUY7SGKtrGdQb6+kqu0h9o/uKi4= X-Received: from ndesaulniers1.mtv.corp.google.com ([2620:15c:211:202:f693:9fff:fef4:4d25]) (user=ndesaulniers job=sendgmr) by 2002:a25:d90c:: with SMTP id q12mr5406595ybg.442.1600301976708; Wed, 16 Sep 2020 17:19:36 -0700 (PDT) Date: Wed, 16 Sep 2020 17:19:34 -0700 In-Reply-To: <20200916085933.25220-1-song.bao.hua@hisilicon.com> Message-Id: <20200917001934.2793370-1-ndesaulniers@google.com> Mime-Version: 1.0 References: <20200916085933.25220-1-song.bao.hua@hisilicon.com> X-Mailer: git-send-email 2.28.0.618.gf4bc123cb7-goog Subject: Re: arm64: mm: move dma_contiguous_reserve() to be after paging_init() From: Nick Desaulniers To: song.bao.hua@hisilicon.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200916_201940_648470_9630AC72 X-CRM114-Status: GOOD ( 10.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sfr@canb.auug.org.au, clang-built-linux@googlegroups.com, linuxarm@huawei.com, ardb@kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, will@kernel.org, guro@fb.com, linux-arm-kernel@lists.infradead.org, mike.kravetz@oracle.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org It looks like that change referenced may also break arm32 boots with today's next? The following allows me to boot, but I have no idea if it's incorrect or not. diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c index 45f9d5ec2360..7118b98c1f5f 100644 --- a/arch/arm/mm/init.c +++ b/arch/arm/mm/init.c @@ -226,9 +226,6 @@ void __init arm_memblock_init(const struct machine_desc *mdesc) early_init_fdt_reserve_self(); early_init_fdt_scan_reserved_mem(); - /* reserve memory for DMA contiguous allocations */ - dma_contiguous_reserve(arm_dma_limit); - arm_memblock_steal_permitted = false; memblock_dump_all(); } @@ -248,6 +245,9 @@ void __init bootmem_init(void) */ sparse_init(); + /* reserve memory for DMA contiguous allocations */ + dma_contiguous_reserve(arm_dma_limit); + /* * Now free the memory - free_area_init needs * the sparse mem_map arrays initialized by sparse_init() _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel