From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCBDEC433E2 for ; Thu, 17 Sep 2020 11:44:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 595E7206BE for ; Thu, 17 Sep 2020 11:44:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qyuehQNu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="N6ezIbX7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 595E7206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=r6oBSoN2oK4K/BcJHSu78uqFEeXa8HJIpZyiljCFnX8=; b=qyuehQNuNgaIFKCHat75vF2oe 5KXluMHl/8Z/RhX5/ep6buyQkIZ7jjCY0L5hwGnR4fbHSrDxj7q3UF0dVVIAId4jpoHMXx5j2Ff17 R89XcyC2RLlvTgddajmWI+rbYeTbWcdRdRoQ+LP/R7tqRyVPInPg9X56qXsAdIGB8uf7JdbxA0yVz wEJ1t19Nz0OPKHRWY7pYMTPsStXOkgTXvPR72u+PUDNEvq3sf/DMaKmgIhNRQGe0U1FCOhxPa0PXS IIHDTDNRKk4h3kIFLaiYHUBJ/j3P+Apm+KEyr5UQuWzPcYPXMWxuzeZC87pKNyo80Mcr46uBf8wvu FHbrqr+iQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIsJN-0005uv-GB; Thu, 17 Sep 2020 11:42:49 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIsJH-0005tN-KZ for linux-arm-kernel@lists.infradead.org; Thu, 17 Sep 2020 11:42:45 +0000 Received: by mail-pf1-x444.google.com with SMTP id l126so1051320pfd.5 for ; Thu, 17 Sep 2020 04:42:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tbCk5p7oO2RdlRD/fPrmujkHJKQX4faYoGEB4vvyBms=; b=N6ezIbX7shKrOnqKZs2VsSEENkfnpWROILduNXEqk6aNwusO5ZuUood+O/EOp0TFQP cKFpng21+37nEo6dF3fOc78ysYYAq2Fnxdmtfe4EyPF5gIUTG8p+Mdd3hzHhITfDSOTi sZAyBRy+0NjQAYhauKbJNVr9dwtQJNRA6NnrFXPJM70zyNzbcUJsovDhQdWy4flDAuA8 H/i9uflGKyHgEXWjM1sUGmLfmG+5AdkqBX4UQYASoMZOEE54TmEPzPUIf6h08wJhMjea AvT646ru16L1+3uVpAysBFbGM+cNS6tDFZOB6AQ2lTNcoDrDbbqL7CBCaXcvsiS0MhGC 6qNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tbCk5p7oO2RdlRD/fPrmujkHJKQX4faYoGEB4vvyBms=; b=E5HJAflS4tuNExWv3Y8gbZxGZT/Zp5lsVRh7jybgcWWkf6rqKdIwWFr1OSxIfyhtkI lF+qPyK+GKnMXxFCTTgskxbkHfN7JsaK6GZX4GSFnKifgezgPDGmWVaafgv1kucmnTSn kNcmtOHet9+KEhI0XdR2pNA/J3aUHI5T9E2y32E5e8Zb8dVJwJiKeFanj1i24E+utpz8 52yQ9K+UFUbSB1JIxy7mHaQafkmpqefKIiPCcimJbagRjkyctqO15s5fGbiaDavfH0xT AuQ5cqaGKPe5aFDXIUXDijkRgLC70JV8I7uXcwk6DhMihgiAuJPSg0ybllta0Iw8/UtS 2mWQ== X-Gm-Message-State: AOAM533eEzpO0g6I0JMhDHQ8Fs3XBlT8/ioNceOWuvoNkPjtyal8LgK3 cKhac2PeIrg4lHNPNF7o8yKo4g== X-Google-Smtp-Source: ABdhPJzg+6AtBlKuvkuo/6mrCHV18a8dk3yL0uRbFFpP1YKIHq6fIYSTHSD9RTT+jhOMnx+Pnd93yg== X-Received: by 2002:a62:7743:0:b029:13c:1611:658e with SMTP id s64-20020a6277430000b029013c1611658emr26546071pfc.11.1600342961108; Thu, 17 Sep 2020 04:42:41 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([2600:3c01::f03c:91ff:fe8a:bb03]) by smtp.gmail.com with ESMTPSA id z4sm20630791pfr.197.2020.09.17.04.42.36 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Sep 2020 04:42:40 -0700 (PDT) Date: Thu, 17 Sep 2020 19:42:31 +0800 From: Leo Yan To: Marc Zyngier Subject: Re: [PATCHv3] perf kvm: add kvm-stat for arm64 Message-ID: <20200917114231.GE12548@leoy-ThinkPad-X240s> References: <20200917003645.689665-1-sergey.senozhatsky@gmail.com> <20200917100950.GC12548@leoy-ThinkPad-X240s> <20200917101219.GD12548@leoy-ThinkPad-X240s> <652f10660f09bd608b825233713f775a@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <652f10660f09bd608b825233713f775a@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200917_074243_733236_A5F9D6B3 X-CRM114-Status: GOOD ( 28.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Mathieu Poirier , Peter Zijlstra , John Garry , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Sergey Senozhatsky , Suleiman Souhlal , Namhyung Kim , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 17, 2020 at 11:21:15AM +0100, Marc Zyngier wrote: [...] > > > > +const char *vcpu_id_str = "id"; > > > > > > On Arm64, ftrace tracepoint "kvm_entry" doesn't contain the field "id" > > > or field "vcpu_id", thus it always reads out the "id" is 0 and it is > > > recorded into Perf's structure vcpu_event_record::vcpu_id and assigned > > > to perf thread's private data "thread::private". > > > > > > With current code, it will not mess up different vcpus' samples > > > because > > > now the samples are analyzed based on thread context, but since all > > > threads' "vcpu_id" is zero, thus all samples are accounted for > > > "vcpu_id=0" and cannot print out correct result with option "--vcpu": > > > > > > > > > $ perf kvm stat report --vcpu 4 > > > > > > Analyze events for all VMs, VCPU 4: > > > > > > VM-EXIT Samples Samples% Time% Min Time > > > Max Time Avg time > > > > > > Total Samples:0, Total events handled time:0.00us. > > > > > > > > > This is an issue I observed, if we want to support option "--vcpu", > > > seems we need to change ftrace event for "kvm_entry", but this will > > > break ABI. > > > > > > Essentially, this issue is caused by different archs using different > > > format for ftrace event "kvm_entry", on x86 it contains feild > > > "vcpu_id" but arm64 only just records "vcpu_pc". > > > > > > @Marc, @Will, do you have any suggestion for this? Do you think it's > > > feasible to add a new field "vcpu_id" into the tracepoint "kvm_entry" > > > for Arm64's version? > > The question really is: how will you handle the ABI breackage? > I don't see a good solution for it, apart from having a *separate* > tracepoint that collects all the information you need. And even that is > really ugly. I searched a bit and found in practice it's not impossible to add new parameters for existed tracepoint, e.g. [1][2] are two examples to add new parameters for existed tracepoints and have been merged into mainline kernel. IIUC, we keep the old parameters for a tracepoint so this can avoid to break ABI if any apps have used this tracepoint, and adding a new parameter for the tracepoint should be safe. If you agree with this, I'd like to suggest to apply below change. How about you think for this? diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c index 46dc3d75cf13..d9f9b8e1df77 100644 --- a/arch/arm64/kvm/arm.c +++ b/arch/arm64/kvm/arm.c @@ -736,7 +736,7 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu) /************************************************************** * Enter the guest */ - trace_kvm_entry(*vcpu_pc(vcpu)); + trace_kvm_entry(vcpu->vcpu_id, *vcpu_pc(vcpu)); guest_enter_irqoff(); ret = kvm_call_hyp_ret(__kvm_vcpu_run, vcpu); diff --git a/arch/arm64/kvm/trace_arm.h b/arch/arm64/kvm/trace_arm.h index 4691053c5ee4..e1d3e7a67e8b 100644 --- a/arch/arm64/kvm/trace_arm.h +++ b/arch/arm64/kvm/trace_arm.h @@ -12,18 +12,20 @@ * Tracepoints for entry/exit to guest */ TRACE_EVENT(kvm_entry, - TP_PROTO(unsigned long vcpu_pc), - TP_ARGS(vcpu_pc), + TP_PROTO(unsigned int vcpu_id, unsigned long vcpu_pc), + TP_ARGS(vcpu_id, vcpu_pc), TP_STRUCT__entry( + __field( unsigned int, vcpu_id ) __field( unsigned long, vcpu_pc ) ), TP_fast_assign( + __entry->vcpu_id = vcpu_id; __entry->vcpu_pc = vcpu_pc; ), - TP_printk("PC: 0x%08lx", __entry->vcpu_pc) + TP_printk("vcpu: %u, PC: 0x%08lx", __entry->vcpu_id, __entry->vcpu_pc) ); TRACE_EVENT(kvm_exit, Thanks, Leo [1] https://lkml.org/lkml/2019/2/26/282 [2] https://lore.kernel.org/linux-mm/20191106080037.GA59367@google.com/t/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel