From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0617C43461 for ; Thu, 17 Sep 2020 17:06:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 46D4B206CA for ; Thu, 17 Sep 2020 17:06:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jTFKVKuS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46D4B206CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wPZDU1qav6YeEgCW5pZTzkWxRf94s/wUPiCPtD18a7c=; b=jTFKVKuSNi8Hxw78MrzwnlHUD TYeyCbuyXIrIl5LMvdumWtppLQHKVmN1a2IphE29iWFY0YoEQwY2bOnyXL2+RxN6DXOE1cTwcdC4p 7aGDbuvXnVEaYDkjNyts3eE+vYuz4tmewZcBPoLlJOu7bHsw4kMyJSMTi8oJCBpakA/LCn7gHiJmi Ljxe0acnHsyOTyOfwOjdehWPaX9tVya61Wnpf7ShtE5Xbya8ZJaeISMfyVJp4LZRBIJ56BGYB2NiV mWaUmeABwcg+MbpqXFCfaQOOGGOhXFjYKqiSlvPDMp2uYA8PFeOEsHFadpGHxwr+S4y9eipbo8JOT 4hKv2iBxQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIxKd-0001mH-Q5; Thu, 17 Sep 2020 17:04:27 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIxKb-0001lZ-1h for linux-arm-kernel@lists.infradead.org; Thu, 17 Sep 2020 17:04:25 +0000 Received: from gaia (unknown [31.124.44.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1E30D206A2; Thu, 17 Sep 2020 17:04:20 +0000 (UTC) Date: Thu, 17 Sep 2020 18:04:18 +0100 From: Catalin Marinas To: Andrey Konovalov Subject: Re: [PATCH v2 34/37] kasan, arm64: print report from tag fault handler Message-ID: <20200917170418.GI10662@gaia> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200917_130425_152577_89FACA53 X-CRM114-Status: GOOD ( 17.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Marco Elver , Elena Petrova , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 15, 2020 at 11:16:16PM +0200, Andrey Konovalov wrote: > diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c > index cdc23662691c..ac79819317f2 100644 > --- a/arch/arm64/mm/fault.c > +++ b/arch/arm64/mm/fault.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -295,17 +296,23 @@ static void die_kernel_fault(const char *msg, unsigned long addr, > do_exit(SIGKILL); > } > > +#ifdef CONFIG_KASAN_HW_TAGS > static void report_tag_fault(unsigned long addr, unsigned int esr, > struct pt_regs *regs) > { > - bool is_write = ((esr & ESR_ELx_WNR) >> ESR_ELx_WNR_SHIFT) != 0; > + bool is_write = ((esr & ESR_ELx_WNR) >> ESR_ELx_WNR_SHIFT) != 0; > > - pr_alert("Memory Tagging Extension Fault in %pS\n", (void *)regs->pc); > - pr_alert(" %s at address %lx\n", is_write ? "Write" : "Read", addr); > - pr_alert(" Pointer tag: [%02x], memory tag: [%02x]\n", > - mte_get_ptr_tag(addr), > - mte_get_mem_tag((void *)addr)); > + /* > + * SAS bits aren't set for all faults reported in EL1, so we can't > + * find out access size. > + */ > + kasan_report(addr, 0, is_write, regs->pc); > } > +#else > +/* Tag faults aren't enabled without CONFIG_KASAN_HW_TAGS. */ > +static inline void report_tag_fault(unsigned long addr, unsigned int esr, > + struct pt_regs *regs) { } > +#endif So is there a point in introducing this function in an earlier patch, just to remove its content here? -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel