From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6DF2C43461 for ; Thu, 17 Sep 2020 18:33:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B0F1206B6 for ; Thu, 17 Sep 2020 18:33:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NRF1SBP+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B0F1206B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jic23.retrosnub.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1bvKUfwEDF9kJ/W3UaFgg03JaqYWJfm0Y7dx/2ClSy8=; b=NRF1SBP+sMvf6uCY4+hsy//3K IDOhoPIn7yVLbGhXUi6vRY5ReL6EPmI/peW9T1BR48vzAbL2Rz0z5IY8Qw98xVLPHLO7ubKxrm4mK S/EhvkCQkkrsiXMHQ/6Po34i2xsCkVGKc8ZtH8bs26qfjOB/XCOosfBeldziNliIVO+vNFIxsiXYn 8gg1tVLlviqt5sSJwh9BMiqaLml4SKFxuVUaaBxvpMZVA9vsLCLzt95GS0PsWrpa0lNRtwKrtHf76 fUwMkDju0dYK4xysq0nNbUWLmxeSsl5CUcwtBoGAso6n7Z05MulhEsPwrPhkKIl7bqLfJPNXJVWOe j36rhBxIA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIyhc-00059c-SD; Thu, 17 Sep 2020 18:32:16 +0000 Received: from saturn.retrosnub.co.uk ([2a00:1098:86::1:1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIyha-00057m-Dd for linux-arm-kernel@lists.infradead.org; Thu, 17 Sep 2020 18:32:15 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) by saturn.retrosnub.co.uk (Postfix; Retrosnub mail submission) with ESMTPSA id 44C509E016A; Thu, 17 Sep 2020 19:32:08 +0100 (BST) Date: Thu, 17 Sep 2020 19:32:06 +0100 From: Jonathan Cameron To: Bartosz Golaszewski Subject: Re: [PATCH 15/30] iio: dummy: iio_dummy_evgen: Demote file header and supply description for 'irq_sim_domain' Message-ID: <20200917193206.40f68d76@archlinux> In-Reply-To: <20200718160046.5d1c8abb@archlinux> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-16-lee.jones@linaro.org> <20200718160046.5d1c8abb@archlinux> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200917_143214_550471_733D94A3 X-CRM114-Status: GOOD ( 21.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lars-Peter Clausen , linux-iio , Marc Zyngier , LKML , Peter Meerwald-Stadler , Hartmut Knaack , Lee Jones , arm-soc Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 18 Jul 2020 16:00:46 +0100 Jonathan Cameron wrote: > On Sat, 18 Jul 2020 11:24:40 +0200 > Bartosz Golaszewski wrote: > > > On Thu, Jul 16, 2020 at 3:59 PM Lee Jones wrote: > > > > > > File headers are not good candidates for kerneldoc. > > > > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/iio/dummy/iio_dummy_evgen.c:30: warning: Cannot understand * @regs: irq regs we are faking > > > on line 30 - I thought it was a doc line > > > drivers/iio/dummy/iio_dummy_evgen.c:42: warning: Function parameter or member 'irq_sim_domain' not described in 'iio_dummy_eventgen' > > > > > > Cc: Marc Zyngier > > > Cc: Bartosz Golaszewski > > > Signed-off-by: Lee Jones > > > --- > > > drivers/iio/dummy/iio_dummy_evgen.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/iio/dummy/iio_dummy_evgen.c b/drivers/iio/dummy/iio_dummy_evgen.c > > > index ee85d596e5284..1febbbff0ded6 100644 > > > --- a/drivers/iio/dummy/iio_dummy_evgen.c > > > +++ b/drivers/iio/dummy/iio_dummy_evgen.c > > > @@ -1,5 +1,5 @@ > > > // SPDX-License-Identifier: GPL-2.0-only > > > -/** > > > +/* > > > * Copyright (c) 2011 Jonathan Cameron > > > * > > > * Companion module to the iio simple dummy example driver. > > > @@ -27,11 +27,13 @@ > > > #define IIO_EVENTGEN_NO 10 > > > > > > /** > > > + * struct iio_dummy_eventgen > > Good to say what this structure is. Perhaps "event generator specific state" > > > > * @regs: irq regs we are faking > > > * @lock: protect the evgen state > > > * @inuse: mask of which irqs are connected > > > * @irq_sim: interrupt simulator > > > * @base: base of irq range > > > + * @irq_sim_domain: irq domain > > > > To be even more clear: this could say: "interrupt simulator domain". > > > > Bartosz Tweaked during applying and applied. > > > > > */ > > > struct iio_dummy_eventgen { > > > struct iio_dummy_regs regs[IIO_EVENTGEN_NO]; > > > -- > > > 2.25.1 > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel