From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9607C43464 for ; Mon, 21 Sep 2020 13:05:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8596521789 for ; Mon, 21 Sep 2020 13:05:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OAQoYTfb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="BK91AnXD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8596521789 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3OnOQHvKS2vlcTPCnRaTmUf1HoocUMwnxHzbpq42ddQ=; b=OAQoYTfbnHJb8n7HQXknLFJHp T/aVy8cR6pvPJxdmvc0pEdfgbWClhBOT9M3Ts980sTZzTcKh2B/ILLPNa87UV/stjukqxVy2UtKYU zjtVKYVpt1z2tFV0CGj96VXebnykmvLLhede6jC99M1vZEGEEKKErgCvLm4+SZEkJhDdgsZJ8jAzZ zeJ005gsp4orO2jjm89Vqr79JKdQNPURGhkM+Wr/woFCPWRdPq3nCn4MqgD638xFmXZ4SRweO4yKX bMHqmWZj7RM4hlqLvQT5SHcdJVqkM4+uB1i7WTWGU/KtlQIf/SXBt9nJqEIa5xvj95k/Ygbi94cFO otz/NLf2w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKLTk-0003ng-5X; Mon, 21 Sep 2020 13:03:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKLTh-0003nD-Vc for linux-arm-kernel@lists.infradead.org; Mon, 21 Sep 2020 13:03:34 +0000 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7DFC421BE5; Mon, 21 Sep 2020 13:03:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600693412; bh=/OXxvRuG9UKcQRKGwiYUXauAuIovgqSdUTuP2bCvGxc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BK91AnXD8umfR9eGG22AlARI0YYWuVA+LtPMvJ7jmlfx9fcC/mM7YICUl8Vrir2Ml DIZxeACidTCoL5lFzdwGm3c6r7G6e9uUZ99QlbzkJeAc7o/JvizkwnnvPVPuIcYXRk K3nWZjjjuk0ZGKIvXAU2wXzqWa3fayM6DRDwsqYE= Date: Mon, 21 Sep 2020 21:03:27 +0800 From: Shawn Guo To: Meenakshi Aggarwal Subject: Re: [PATCH 2/2] arm64: dts: lx2160a: add device tree for lx2162aqds board Message-ID: <20200921130325.GA25428@dragon> References: <1599059610-7570-1-git-send-email-meenakshi.aggarwal@nxp.com> <1599059610-7570-2-git-send-email-meenakshi.aggarwal@nxp.com> <20200905075419.GN9261@dragon> <20200912094913.GB25109@dragon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200921_090334_138287_D3DF3969 X-CRM114-Status: GOOD ( 23.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Kuldeep Singh , "linux-kernel@vger.kernel.org" , Leo Li , "robh+dt@kernel.org" , Varun Sethi , Ioana Ciornei , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 21, 2020 at 06:00:53AM +0000, Meenakshi Aggarwal wrote: > > > > -----Original Message----- > > From: Shawn Guo > > Sent: Saturday, September 12, 2020 3:19 PM > > To: Meenakshi Aggarwal > > Cc: robh+dt@kernel.org; Varun Sethi ; Leo Li > > ; linux-arm-kernel@lists.infradead.org; > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ioana Ciornei > > ; Kuldeep Singh > > Subject: Re: [PATCH 2/2] arm64: dts: lx2160a: add device tree for lx2162aqds > > board > > > > On Wed, Sep 09, 2020 at 07:10:12AM +0000, Meenakshi Aggarwal wrote: > > > > > + sb_3v3: regulator-sb3v3 { > > > > > + compatible = "regulator-fixed"; > > > > > + regulator-name = "MC34717-3.3VSB"; > > > > > + regulator-min-microvolt = <3300000>; > > > > > + regulator-max-microvolt = <3300000>; > > > > > + regulator-boot-on; > > > > > + regulator-always-on; > > > > > > > > I do not see any point to have regulator-boot-on or > > > > regulator-always-on for a regulator that doesn't have on/off control. > > > [Meenakshi Aggarwal] Properties are added to specify that platform > > > firmware's out of reset configuration enabled the regulator and regulator > > should never be disabled or change its operative status. > > > > What I was wondering if how this regulator is enabled by firmware, by some > > GPIO control? In that case, 'gpio' property should be there to describe the GPIO > > control. > > > [Meenakshi Aggarwal] Its not controlled by GPIO. Its gets power on with board. > > > > > > Can you help in understanding why these optional properties cannot be > > > used together > > > > It's totally fine to use these properties together. But if the regulator doesn't > > have on/off control, neither of them makes sense. > [Meenakshi Aggarwal] As per documentation, we should keep " regulator-always-on " as per description, we > Can remove " regulator-boot-on" property from dts. > > regulator-always-on: > description: boolean, regulator should never be disabled Again, the property is only meaningful for a regulator that can possibly be disabled. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel