From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3FF8C4727C for ; Sat, 26 Sep 2020 00:02:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5712D21D7F for ; Sat, 26 Sep 2020 00:02:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WuJc7TVR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5712D21D7F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cdqe.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:MIME-Version:Message-ID:Subject:To:From:Date:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=X4XaERgUztCPbBrKSNIJTzZpDrFAE1/CCUAzLkT5IwU=; b=WuJc7TVRI3vH4aNfwCdq+uyMkv 2sDJGcVP9ju0XlVy3SFA5WQsW3B+9caQM8v7c3LubFI5vE4u1lPjuya6g/Y2Nnw0gnvz5skZaIv80 NtmMb388ASP6Z9v7KzNTKJyp5a2Ig2pRPyCJ67ChhrD+VslFP+911sL0OtEiBO2by2wFXmn3+1Nol nrmaauSF2w4/csfCI6I8PUALVq2LwIyNX1tvwJoV82uQ1DxcHJ8AujO1RxHUNtiDlwPvHzW8G6HvZ /y7qHV+jwYOlrjmw7LW30yLm4MQKIWK3dJ22sS/Lv5QRKkts12On+b0BP/lq+G/ZwC9Kwl/7MdXgT Tfq66xhw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLxeH-0002Qs-Ft; Sat, 26 Sep 2020 00:01:09 +0000 Received: from agrajag.zerfleddert.de ([2a01:4f8:bc:1de::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLxeE-0002QZ-QC for linux-arm-kernel@lists.infradead.org; Sat, 26 Sep 2020 00:01:07 +0000 Received: by agrajag.zerfleddert.de (Postfix, from userid 1000) id BAA945B2057C; Sat, 26 Sep 2020 01:55:41 +0200 (CEST) Date: Sat, 26 Sep 2020 01:55:41 +0200 From: Tobias Jordan To: Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] bus: arm: integrator: fix device node iterator leak Message-ID: <20200925235541.GA28030@agrajag.zerfleddert.de> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200925_200107_107317_F1EB7506 X-CRM114-Status: GOOD ( 12.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In the for_each_available_child_of_node loop of integrator_lm_populate, add a call to of_node_put to avoid leaking the iterator if we bail out. Fixes: ccea5e8a5918 ("bus: Add driver for Integrator/AP logic modules") Signed-off-by: Tobias Jordan --- drivers/bus/arm-integrator-lm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bus/arm-integrator-lm.c b/drivers/bus/arm-integrator-lm.c index 845b6c43fef8..cb6da80d1c7d 100644 --- a/drivers/bus/arm-integrator-lm.c +++ b/drivers/bus/arm-integrator-lm.c @@ -53,6 +53,7 @@ static int integrator_lm_populate(int num, struct device *dev) base); ret = of_platform_default_populate(child, NULL, dev); if (ret) { + of_node_put(child); dev_err(dev, "failed to populate module\n"); return ret; } -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel