From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39755C4346E for ; Tue, 29 Sep 2020 09:26:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A42C32076B for ; Tue, 29 Sep 2020 09:26:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mZA+aqw3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A42C32076B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VA0kC74l3/uhP7ktKL78w0ZDJBdcFw3l3gHWOhSGwoo=; b=mZA+aqw37jPTPFntiqmWnAuK6 1qjCmVvWTlcC7dIb+AkTglIjm509i7xxSudsBi3p8NdHfyp9kNPfz82Zw5ouy22Euq/fdQ9qImOcr x1x/1ig1J+xAwjG+KnLAHgAK2dRWqtcyfb/M3cjNXXxjXsgIePLc/HcuvlYYchlGty17Uie0ClBTQ 0J8F2LxK5D2mYcFDw5YfareP39dMJvGXaV5R6xYMXEY6Bd/8hW3jwLt4gjSaOBwgSw7WOX7Kvi8Wa MIxAJ0kW8mcvOfL2fc/f4XVzpUzqK+uaSt/iJcu7aKKUq3q9W90mjSbgzZbm79tbjktQUncyMSoP9 8nIqiSYRA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNBsO-0005jL-Vd; Tue, 29 Sep 2020 09:24:49 +0000 Received: from mail-ed1-f66.google.com ([209.85.208.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNBsM-0005hw-Vb for linux-arm-kernel@lists.infradead.org; Tue, 29 Sep 2020 09:24:47 +0000 Received: by mail-ed1-f66.google.com with SMTP id k14so5595242edo.1 for ; Tue, 29 Sep 2020 02:24:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=G7eKygSeHsJSU7Elok8vNPdgOrN4BcXLT668jf/UCZU=; b=C3qQXVME874QWEyqDLow+MOaWYispruZP0s7iupDTN0REYXihQgJ0JJuusDglWnnE4 AMN95Gh/ZpLQXN7oG0KMUdmq6bsQdxllvg01az/F3qtUk1RtiqjTw0j2Qv5PHteJZAVJ zvahPWOh8robvlu6w3Xrn+8cUwa3K/xcp+55mPr6BVRP2VgJAuy2DKNNH+NOAcHuD1n9 QlQt8VbomT4OyNrpRi6YeawaA/uJQNCokhuR45J4U5VfrplrWOhBZ2FJXD4SXWIOAXR9 DP+tiS9MsuA1M3//KbF0EMA/6r8r6WojLpe2pJQFOlFQgvSI+aZ3YV+8Cwjt+/EZKe8J 28xg== X-Gm-Message-State: AOAM533mBy5IyJMYZJaTGylgCsIQcMvEL/xOWHgM+ihgH/0SRmckr3Km dfO2rYGbLvHV/+PWjlpCBv4= X-Google-Smtp-Source: ABdhPJwy6PsDLNLt1asd/+TESiGE1ob3XYxQF6V+VCOkN/LAHdLPvY+CsJw4WUuQaVDgBnRSbxgBSg== X-Received: by 2002:a50:fc91:: with SMTP id f17mr2277096edq.319.1601371483585; Tue, 29 Sep 2020 02:24:43 -0700 (PDT) Received: from kozik-lap ([194.230.155.194]) by smtp.googlemail.com with ESMTPSA id z17sm5566137edi.90.2020.09.29.02.24.39 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 Sep 2020 02:24:42 -0700 (PDT) Date: Tue, 29 Sep 2020 11:24:35 +0200 From: Krzysztof Kozlowski To: Sakari Ailus Subject: Re: [PATCH v4 4/4] media: i2c: imx258: get clock from device properties and enable it via runtime PM Message-ID: <20200929092435.GA10284@kozik-lap> References: <20200923152129.21736-1-krzk@kernel.org> <20200923152129.21736-4-krzk@kernel.org> <20200929091704.GG26842@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200929091704.GG26842@paasikivi.fi.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200929_052447_019873_81A1C10B X-CRM114-Status: GOOD ( 34.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Mauro Carvalho Chehab , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 29, 2020 at 12:17:04PM +0300, Sakari Ailus wrote: > Hi Krzysztof, > > On Wed, Sep 23, 2020 at 05:21:29PM +0200, Krzysztof Kozlowski wrote: > > The IMX258 sensor driver checked in device properties for a > > clock-frequency property which actually does not mean that the clock is > > really running such frequency or is it even enabled. > > > > Get the provided clock and check it frequency. If none is provided, > > fall back to old property. > > > > Enable the clock when accessing the IMX258 registers and when streaming > > starts with runtime PM. > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > Changes since v3: > > 1. None > > > > Changes since v2: > > 1. Do not try to set drvdata, wrap lines. > > 2. Use dev_dbg. > > > > Changes since v1: > > 1. Use runtime PM for clock toggling > > --- > > drivers/media/i2c/imx258.c | 71 +++++++++++++++++++++++++++++++++----- > > 1 file changed, 62 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c > > index ae183b0dbba9..7bedbfe5c4d6 100644 > > --- a/drivers/media/i2c/imx258.c > > +++ b/drivers/media/i2c/imx258.c > > @@ -2,6 +2,7 @@ > > // Copyright (C) 2018 Intel Corporation > > > > #include > > +#include > > #include > > #include > > #include > > @@ -68,6 +69,9 @@ > > #define REG_CONFIG_MIRROR_FLIP 0x03 > > #define REG_CONFIG_FLIP_TEST_PATTERN 0x02 > > > > +/* Input clock frequency in Hz */ > > +#define IMX258_INPUT_CLOCK_FREQ 19200000 > > + > > struct imx258_reg { > > u16 address; > > u8 val; > > @@ -610,6 +614,8 @@ struct imx258 { > > > > /* Streaming on/off */ > > bool streaming; > > + > > + struct clk *clk; > > }; > > > > static inline struct imx258 *to_imx258(struct v4l2_subdev *_sd) > > @@ -972,6 +978,29 @@ static int imx258_stop_streaming(struct imx258 *imx258) > > return 0; > > } > > > > +static int imx258_power_on(struct device *dev) > > +{ > > + struct v4l2_subdev *sd = dev_get_drvdata(dev); > > + struct imx258 *imx258 = to_imx258(sd); > > + int ret; > > + > > + ret = clk_prepare_enable(imx258->clk); > > + if (ret) > > + dev_err(dev, "failed to enable clock\n"); > > + > > + return ret; > > +} > > + > > +static int imx258_power_off(struct device *dev) > > +{ > > + struct v4l2_subdev *sd = dev_get_drvdata(dev); > > + struct imx258 *imx258 = to_imx258(sd); > > + > > + clk_disable_unprepare(imx258->clk); > > + > > + return 0; > > +} > > + > > static int imx258_set_stream(struct v4l2_subdev *sd, int enable) > > { > > struct imx258 *imx258 = to_imx258(sd); > > @@ -1199,9 +1228,28 @@ static int imx258_probe(struct i2c_client *client) > > int ret; > > u32 val = 0; > > > > - device_property_read_u32(&client->dev, "clock-frequency", &val); > > - if (val != 19200000) > > - return -EINVAL; > > + imx258 = devm_kzalloc(&client->dev, sizeof(*imx258), GFP_KERNEL); > > + if (!imx258) > > + return -ENOMEM; > > + > > + imx258->clk = devm_clk_get_optional(&client->dev, NULL); > > + if (!imx258->clk) { > > + dev_dbg(&client->dev, > > + "no clock provided, using clock-frequency property\n"); > > + > > + device_property_read_u32(&client->dev, "clock-frequency", &val); > > + if (val != IMX258_INPUT_CLOCK_FREQ) > > + return -EINVAL; > > + } else if (IS_ERR(imx258->clk)) { > > + return dev_err_probe(&client->dev, PTR_ERR(imx258->clk), > > + "error getting clock\n"); > > + } else { > > + if (clk_get_rate(imx258->clk) != IMX258_INPUT_CLOCK_FREQ) { > > + dev_err(&client->dev, > > + "input clock frequency not supported\n"); > > + return -EINVAL; > > + } > > + } > > > > /* > > * Check that the device is mounted upside down. The driver only > > @@ -1211,24 +1259,25 @@ static int imx258_probe(struct i2c_client *client) > > if (ret || val != 180) > > return -EINVAL; > > > > - imx258 = devm_kzalloc(&client->dev, sizeof(*imx258), GFP_KERNEL); > > - if (!imx258) > > - return -ENOMEM; > > - > > /* Initialize subdev */ > > v4l2_i2c_subdev_init(&imx258->sd, client, &imx258_subdev_ops); > > > > + /* Will be powered off via pm_runtime_idle */ > > + ret = imx258_power_on(&client->dev); > > + if (ret) > > + return ret; > > + > > /* Check module identity */ > > ret = imx258_identify_module(imx258); > > if (ret) > > - return ret; > > + goto error_identify; > > > > /* Set default mode to max resolution */ > > imx258->cur_mode = &supported_modes[0]; > > > > ret = imx258_init_controls(imx258); > > if (ret) > > - return ret; > > + goto error_identify; > > > > /* Initialize subdev */ > > imx258->sd.internal_ops = &imx258_internal_ops; > > @@ -1258,6 +1307,9 @@ static int imx258_probe(struct i2c_client *client) > > error_handler_free: > > imx258_free_controls(imx258); > > > > +error_identify: > > + imx258_power_off(&client->dev); > > You'll need this in remove callback, too. True, there is no runtime idle call so this is missing. Thanks. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel