From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA61FC4346E for ; Tue, 29 Sep 2020 09:42:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3278920848 for ; Tue, 29 Sep 2020 09:42:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Yb0wtx82" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3278920848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FbkjYI9+l74Y4Nlov6LgswZrrESnaG2OoOUff7lR/qc=; b=Yb0wtx82fl8zg5xgsMH0iUU5l jFZ77gRK/TiuUo+MTF0JVGfoAFKTPPthx9c9+gLxKe+pGNZKQu4JgrWQGQ/ozyorfTqB3cobqe8+J IlhVARO5prfmMOnFi6m0u5GBp/kv4V4G9kZKCKvTtTLczbStD62212G+WuOBFwlk0g6etRYz6Allu xijFzau8TriwU+C+rsHKe9Izco79bzHsT/2NNtXJSrOX4cLiVvmaiPty+ZmI/LMAngoh5iVVtUrD8 IQWzmQsDA0CssUSwZAmoTrapmdPVcQR9AZ56QU+rG4Wem2Qlst8mG9dfHrLsM/TULWgv5Ya77a6cz YDVhJPNYQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNC82-0001B1-J6; Tue, 29 Sep 2020 09:40:58 +0000 Received: from mga09.intel.com ([134.134.136.24]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNC7z-00019D-E9 for linux-arm-kernel@lists.infradead.org; Tue, 29 Sep 2020 09:40:56 +0000 IronPort-SDR: B3c61ZYlGXo5FkEP+Bmwed5VbX51mgnYywCaEwWZ0VArtakGprsza6vRoY2L2U5IwFtuFoBtbu vFdhJ+wEo9zA== X-IronPort-AV: E=McAfee;i="6000,8403,9758"; a="163033328" X-IronPort-AV: E=Sophos;i="5.77,318,1596524400"; d="scan'208";a="163033328" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 02:40:52 -0700 IronPort-SDR: /VJGhAI/awo1uw4sQ20g9MN8byzWtf7ZzBdoFu4aj+e9hLKild4FKTy+FxWCJpxcjQ9ANjVXZ8 8dOj7SaGag3Q== X-IronPort-AV: E=Sophos;i="5.77,318,1596524400"; d="scan'208";a="338562828" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 02:40:48 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 75317204FD; Tue, 29 Sep 2020 12:40:46 +0300 (EEST) Date: Tue, 29 Sep 2020 12:40:46 +0300 From: Sakari Ailus To: Krzysztof Kozlowski Subject: Re: [PATCH v4 1/4] dt-bindings: media: imx258: add bindings for IMX258 sensor Message-ID: <20200929094046.GH26842@paasikivi.fi.intel.com> References: <20200923152129.21736-1-krzk@kernel.org> <20200929091512.GF26842@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200929_054055_613470_4EE8C719 X-CRM114-Status: GOOD ( 26.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Shawn Guo , Sascha Hauer , "linux-kernel@vger.kernel.org" , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Mauro Carvalho Chehab , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 29, 2020 at 11:18:46AM +0200, Krzysztof Kozlowski wrote: > On Tue, 29 Sep 2020 at 11:15, Sakari Ailus wrote: > > > > Hi Krzysztof, > > > > On Wed, Sep 23, 2020 at 05:21:26PM +0200, Krzysztof Kozlowski wrote: > > > Add bindings for the IMX258 camera sensor. The bindings, just like the > > > driver, are quite limited, e.g. do not support regulator supplies. > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > > > --- > > > > > > Changes since v3: > > > 1. Document also two lane setup. > > > > > > Changes since v2: > > > 1. Remove clock-frequency, add reset GPIOs, add supplies. > > > > Oops. I missed this one. > > > > How does the driver know the appropriate clock frequency for the platform > > if it's not in DT? The sensor supports a range of frequencies, not a single > > frequency. > > > > Could you add clock-frequency back? > > Not really, it was removed on Rob's request. The bindings do not > describe driver's behavior so how the driver gets frequency should not > be part of the bindings. Also it's not a real problem - the driver > just calls clk_get_rate(). How is the rate determined? I mean, many ISPs or CSI-2 receivers that provide the clock are also capable of using a variety of frequencies. But only one can be used on the platform in general. Where does it come from if it's not in DT? Using another frequency generally leads to failure later on as the desired link frequency likely is not available for a random external clock frequency. -- Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel