From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22665C4727F for ; Wed, 30 Sep 2020 10:39:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A56072071E for ; Wed, 30 Sep 2020 10:39:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lGBp4Hvo"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="P++TvTpV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A56072071E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/vyP6YoxQjCtgVmCCNcd15apMjeWV9xG15x4SuVRb7M=; b=lGBp4HvoAl07IIFoWUXO5nqCh tQ+R2D3B2UpSyGp4vhNeDR2gprx8fijSQl6PZ6BGmMokwx/9QapK6Ijy4AVjgoQXLH8P4jNUDmUDe GOIXBHyLkHouv6Xl0NAZUJFu8IeT0i/f3yl1kh3Lyhpzmw6NzMx5MIIOtoQu5rmTN+iJvqNkEBl46 HF7u3BNhMLcwpn7aHNgPPxhuQFK5Y8CCiAXi9+1Rv0VGA6qFTPKZ2V5eaMqsyKrS7F1LCi7wumwzf KTsQ+YSqNbdQK9YUPHx/pXDp+i/byM+LFflvxUJ1Ep5KpRk9ZbCp9uyqMVun1Wgz8g3ZZfwdSSzTK aAHpPijVg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNZVF-0001L1-K1; Wed, 30 Sep 2020 10:38:29 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNZVD-0000d1-7T for linux-arm-kernel@lists.infradead.org; Wed, 30 Sep 2020 10:38:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=EuVEPFMW1rDyqkkUcMY67rMgM+/dxf8pZ15j8vYFSLw=; b=P++TvTpV3ieuhNOzT64wrQfSb Y2I9XB2TSSMfVPVjTifwQuobBT6KpMUfrctXXDLlHDIU1X5udOQJXayLB5bCq0Wyig0ezpe7CIPkC YRyahlRcpcJFvq3jUlLhaIgcacaOTzKq/1o8KOEVaML6yUAWQML7EYo3pzybUFlCmIPDBDDxFve84 8ymHusCXr/hXoE+9JKQXi52kIEGDqKRWrVyy+rgrCCZpy5EHpeqkiZEHOG2uXf5lG/hUoyxr1nZfj f25prYe/bZQlFO7N0KXlpH7tAKNMoSlV8qiEJ2WdEr0sP6inrkwbNDzu38ZX3bgUE1r6IUpeq0z5Z uktg/eNLA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:40150) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNZSF-0002NL-3G; Wed, 30 Sep 2020 11:35:23 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kNZSE-00023M-75; Wed, 30 Sep 2020 11:35:22 +0100 Date: Wed, 30 Sep 2020 11:35:22 +0100 From: Russell King - ARM Linux admin To: Florian Fainelli Subject: Re: [PATCH] arm: Support initrd with address in boot alias region Message-ID: <20200930103521.GD1551@shell.armlinux.org.uk> References: <58e39504-3970-597f-8146-5180babc6e16@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <58e39504-3970-597f-8146-5180babc6e16@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200930_063827_367347_D7F2E5CF X-CRM114-Status: GOOD ( 19.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Sverdlin, Alexander \(Nokia - DE/Ulm\)" , Rob Herring , Matija Glavinic Pecotic , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 29, 2020 at 10:21:35AM -0700, Florian Fainelli wrote: > +Rob, Russell, > > On 9/29/2020 12:54 AM, Matija Glavinic Pecotic wrote: > > If bootloader passes address of initrd in boot alias region, initrd > > will fail on memblock_is_region_memory as memblock with such address > > doesn't exist. > > > > Issue was observed with kexec which passed initrd address in boot alias > > region, while bootloader will typically pass physical address. Commit > > fe7db7570379 ("of/fdt: Populate phys_initrd_start/phys_initrd_size from FDT") > > uncovered problem by removing virt_to_phys on the initrd physical > > address. __virt_to_phys on our platform coincidentally fixed address. > > > > Fix by trying to correct address in case of invalid physical address. > > > > Signed-off-by: Matija Glavinic Pecotic > > This should have a Fixes tag: > > fe7db7570379 ("of/fdt: Populate phys_initrd_start/phys_initrd_size from > FDT") > > I am not familiar enough with how the identity map works, but it seems to do > what you want it to. It seems strange to pass the initrd in using an address that is not listed as part of the system memory map, especially as the initrd is freed during kernel initialisation. Which boot loader is this, and is there a reason it operates this way? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel