From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4463BC4727E for ; Wed, 30 Sep 2020 12:29:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC8932071E for ; Wed, 30 Sep 2020 12:29:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Qkr/Oc1/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="IjdYEN1b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC8932071E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=st/B/gZtJ+Uej7JSD4rbiYaDzIkSd+WoyRDs5jdaeH4=; b=Qkr/Oc1/0NyEqRN8JnDOQTMGJ yuaZGpCO2SGhYm1CUACUUOkXaVAFzxVjpj0H/GLj/G254tbgGYbyUvhLCBslhB7vrXTGHriLjNcIa Nqj3DY/qlz6kk68SajJuQhjfPdvzqgooYlT/LgpjTax4qftRSc1Dackkwxg+J65E2ENOqw9WCz2u/ V7jyEFyAEYHPhWb6JBgt4SPDmV3DuUOT4xlgeinrzkXFDqpQ2oebMXIl9mYyeV5VjoUPd7R4rHHtw Wjb4cPJ5KDBCPQ5jfqNqmcpQl/mo5+61nvxhxiVPxEHITFQZoi6TcgmFFWkQvwUIUNTpE6ukkmYXt eETEokimA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNbDR-00052A-2Q; Wed, 30 Sep 2020 12:28:13 +0000 Received: from aserp2120.oracle.com ([141.146.126.78]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNbDN-000514-9k; Wed, 30 Sep 2020 12:28:10 +0000 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08UC9YhR028137; Wed, 30 Sep 2020 12:27:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=g14+JbAXNUIDOSumYRcqglsnIcYylhw2m0sA+ZnTuX4=; b=IjdYEN1bVdBp3T8f3BZ+ye19TY732TkCur5PHaCZDHBcMBULxubjiugSeFTrj7lI/nhx ZZ9v1rf5L1X6EnWiPMR1ddHVH2DW+O383apYD7hSuWFPHHRworlst6V0vD9J684Aw8VS g53npCiBTWSoDv6oyWdwUGS4mRoh6BbPdAvZYj0yIG0dz6fYqVT+6IjXZsk2iPFdrNrM Jl59gTbABfWE0GsAQzdpPbVRONwgXbSzhqh1Tc9WfSfdpsIyFL1FuIrpuI5srGnHzwUD pCVq2j0iK1h96UrxEbjILqTGiKCBNU9pAEdy4AaIzZJcT2yd03GhIiNiGt+wottZAK1t aw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 33swkm06mk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 30 Sep 2020 12:27:58 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08UCOl96156864; Wed, 30 Sep 2020 12:27:58 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 33tfdttusg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 Sep 2020 12:27:58 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 08UCRnFl019263; Wed, 30 Sep 2020 12:27:50 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 30 Sep 2020 05:27:48 -0700 Date: Wed, 30 Sep 2020 15:27:41 +0300 From: Dan Carpenter To: Arnd Bergmann Subject: Re: [PATCH] staging: vchiq: silence an uninitialized variable warning Message-ID: <20200930122741.GB4282@kadam> References: <20200930090238.GA621698@mwanda> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9759 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0 adultscore=0 malwarescore=0 spamscore=0 mlxscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009300102 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9759 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 phishscore=0 suspectscore=0 mlxlogscore=999 clxscore=1015 priorityscore=1501 impostorscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009300101 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200930_082809_622325_65DEA53A X-CRM114-Status: GOOD ( 22.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: driverdevel , Greg Kroah-Hartman , Marcelo Diop-Gonzalez , kernel-janitors@vger.kernel.org, Nicolas Saenz Julienne , bcm-kernel-feedback-list , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , Jamal Shareef , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 30, 2020 at 12:22:37PM +0200, Arnd Bergmann wrote: > On Wed, Sep 30, 2020 at 11:02 AM Dan Carpenter wrote: > > > > Smatch complains that "userdata" can be passed to vchiq_bulk_transfer() > > without being initialized. Smatch is correct, however, in that > > situation the "userdata" is not used so it doesn't cause a problem. > > Passing an uninitialized variable will trigger a UBSan warning at > > runtime so this warning is worth silencing by setting "userdata" to > > NULL. > > > > Fixes: a4367cd2b231 ("staging: vchiq: convert compat bulk transfer") > > Signed-off-by: Dan Carpenter > > The change looks fine, but I wonder if it's actually worse and the > uninitialized pointer can end up getting copied back to user space > in the completion. Ah... Wow. You're right. I think I really need to resend this with a more accurate commit message. regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel