From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C685C4727C for ; Wed, 30 Sep 2020 17:55:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BFA720706 for ; Wed, 30 Sep 2020 17:55:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xhPqjsvz"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=beagleboard-org.20150623.gappssmtp.com header.i=@beagleboard-org.20150623.gappssmtp.com header.b="xS8WcxEV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BFA720706 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=beagleboard.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8b30nfkBG+aE2pJG/wWpzSsDHCK/32Som8wJn6Kt0Vg=; b=xhPqjsvzUsvK1YQCkB7jOSxwF IYImG70Rp57n5mDQm4QcdnHTGPAqmC/ugXXod75kYxVV07S3xW9ee0qIiA8P30ORMb9lJLK4Kmx+e DnGn7OS1yjnAkMSZqM3nY0afp/EmoWWyInY/y+mNhi5BKxCyGsKniFbAAwo4ghVLKul2069EvPdMU nxwSEyUSOElx8wGYeAhL1gCZNmq7VJPCGkCIIXGGXOXekiOwu2WorR50szLMMwKxE7A8orBL1QSRN YOshEQrkMQy02DqIbQTTkCuE5QZgpaZRA1BB626fYs9Lq8v8ObOnXuz/gz8Lt3UNtugnR27bT+BSU EAOxNU7zQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNgIP-0008Mz-45; Wed, 30 Sep 2020 17:53:41 +0000 Received: from mail-ot1-x344.google.com ([2607:f8b0:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNgIL-0008Lx-0W for linux-arm-kernel@lists.infradead.org; Wed, 30 Sep 2020 17:53:38 +0000 Received: by mail-ot1-x344.google.com with SMTP id q21so2677074ota.8 for ; Wed, 30 Sep 2020 10:53:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nmx3GK+BJ0d4VG1MnUd724aknrThpuCxNaLSY0XJ58c=; b=xS8WcxEVpDZKYDvgXPcKeyIkiQzftLTmFl1axoEXs0Fs32CiYI0KH+BPVPgCu6eiKV 42m2Uh5QfSYCU0vvxw0usyqGn8nqfxXeCy3g2usLicSNcT3LdNDZfvdwf2eAoq7kTuUn 9URHPG0/NHIcclklxub5afY/bGPhuRywQDtbKL7okklvJqXiNrbmgeAh+yJ+QxgUEhP6 hk7YmdzwYb0o2+fEnedyN4Tsc2cDh2t4jFOssNAd5XW6hSFR06iTvsNyKW9recaLnIvs frv4wfZLcvUgM3BDXaCuxAd4Wmdo5FgaXCj0KLCCh2DcHUXmGuk2btBzop8MkZn+T8E/ O/UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nmx3GK+BJ0d4VG1MnUd724aknrThpuCxNaLSY0XJ58c=; b=PgWrUqzRNU1dnnTRNyoU8GVLNiq1AloL3f9vWcdtb8n3vXafPHAki6M2BPquZner8j c+Mju1Er1BdvLZMShWFlps7nIPRb+QrgpVICYclA0/nQeNAI+nAyU/WOlq4sF+0GywE+ D7+LX5sb2b5eA/XUkdo/MvppLppbdn0WpBAgbVdjUZ5K1d3cHWg0XSjRPb22Ya92bNSR UHBe87M6mnDBxrXBsvb4e9rsdbsFUJ0s1C8nuhukP2gjlbPQ11rXTpJbjOX2HNjb2HsG CPkEznV4Pdx5MhBwgDEv0yYm5YIbSWIvKaYlZM9NtyOJnDnZVXBk8zrlA2qpvESlDM8D Jk+Q== X-Gm-Message-State: AOAM533QIyUm/IgJusNhSNiRDLiEPS2D0kUN1QUQdlxqKSu5Ls5ljRVg P5tFqa9aex3O12jlV5DNQNQRSA== X-Google-Smtp-Source: ABdhPJzpc1y+G2Mh4hI2b6mUBCT6UIG0Wm+AK1cTWmMfvdiwkQpSWSp64VdS6GC+wwAIzRfTI4QyCA== X-Received: by 2002:a9d:2925:: with SMTP id d34mr2284108otb.140.1601488413886; Wed, 30 Sep 2020 10:53:33 -0700 (PDT) Received: from x1 ([2600:1702:da0:ff40:985b:42bd:cfe:59b7]) by smtp.gmail.com with ESMTPSA id c19sm555297ooq.35.2020.09.30.10.53.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2020 10:53:33 -0700 (PDT) Date: Wed, 30 Sep 2020 12:53:30 -0500 From: Drew Fustini To: Tony Lindgren Subject: Re: [PATCH] pinctrl: single: check if #pinctrl-cells exceeds 3 Message-ID: <20200930175330.GA1295202@x1> References: <20200913210825.2022552-1-drew@beagleboard.org> <20200930051659.GO9471@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200930051659.GO9471@atomide.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200930_135337_084581_B5C55E06 X-CRM114-Status: GOOD ( 19.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Trent Piepho , Jason Kridner , Linus Walleij , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , Rob Herring , Haojian Zhuang , =?iso-8859-1?Q?Beno=EEt?= Cousson , Linux-OMAP , Robert Nelson , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 30, 2020 at 08:16:59AM +0300, Tony Lindgren wrote: > * Linus Walleij [200929 12:51]: > > On Sun, Sep 13, 2020 at 11:17 PM Drew Fustini wrote: > > > > > The property #pinctrl-cells can either be 2 or 3. There is currently > > > only a check to make sure that #pinctrl-cells is 2 or greater. This > > > patch adds a check to make sure it is not greater than 3. > > > > > > Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2") > > > Reported-by: Trent Piepho > > > Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/ > > > Signed-off-by: Drew Fustini > > > > Tony, does this and the other patch look good to you? > > Hmm well the description looks a bit confusing, #pinctrl-cells can > also be 1 that's the default. Might be worth clarifying that part. > > Regards, > > Tony Yes, that was my fault for confusing #pinctrl-cells with pinctrl_spec.args_count. - if #pinctrl-cells = <1>, then pinctrl_spec.args_count = 2 - if #pinctrl-cells = <2>, then pinctrl_spec.args_count = 3 - all other values are not valid I will post a v2. Thanks, Drew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel