From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B43B2C4727E for ; Thu, 1 Oct 2020 15:06:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41AE5207F7 for ; Thu, 1 Oct 2020 15:06:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0O3XsMf7"; dkim=temperror (0-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="IzI9XQUp"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="iXtlJjk3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41AE5207F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LBpV3sdy/cwuTv2AYeBHIrwbrwn3eFaZJte87tuOlkM=; b=0O3XsMf7k0Do8yfG0ap0CHLty rciwohEDBHD4Ocfvz90UouS+7szbfE8pNc4X00XksOsGFMrGTdeuxHFsKQPllzfF7zQyYtwPchgml Vg90oKSH+/BGhfnWN4oSmE9cJtJ/H6U9LrXj+3njOPDwU6YeZnlyBTOX/9HvngF7IbnQqpJGkNest CJerthxklmH5PV5RJGPS3OlvoS6blKNygHzB88fuYSKEX7+O6A2ieHRKRRjhCKScsP27jv7GjckVc qSTf4EDYBSigIAU1QrZbqyrYVfPaKvarUibuV4q4tHy0l17sGyI+ku7ZGS8d7dzxF1UU6rLB2U3cX QAMR0Tfuw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kO08W-0004K0-Ob; Thu, 01 Oct 2020 15:04:48 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kO08S-0004Gw-Lw; Thu, 01 Oct 2020 15:04:46 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 5C7E5EC9; Thu, 1 Oct 2020 11:04:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 01 Oct 2020 11:04:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=hsfcTzgykACUWAsl9gm17cAmSb/ jbx8vKMS03bYlBoc=; b=IzI9XQUpqwHQXDBqWSZsIOL8bjuBgldJm4aGWxlbmmN uq4yhSHKnzgIFDqomMxR+jJPp+kjkDdAhIrCxuNs0gayMH91X9YwftbqRCVwMYAx /3GM1+33/xrYZMyzwmHhEnxB3NP+5F2ZQGAgJQRe+e1NLiyUX+LsG8WlWPUToxUZ v045HIgNGitcwAed+9GG+Gzj/3bdq5+rAUU9eUcdfTeJ7t+AY272eaIHgmK1EbL8 iRfscdc+4pU9370AVpmDXUO2RblyipLkYO8SuzN5cPvggG6B3M7rE49BaaEBTVpZ 3lUcT7qDQ4RQDq8nY+cTzHaIe/u34CEIg/jd892+Swg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=hsfcTz gykACUWAsl9gm17cAmSb/jbx8vKMS03bYlBoc=; b=iXtlJjk3DfuxhwaFJE8mgq 4Rq6YsbpaFt/r9R6nmgIW3PRvJVnoISyVNbvgbkvs7F5KwAtxsNlZUrZ/PZSPlqg Q0VHnOuDT9J/FdXmlnp/9PSz9/CMr001YPMnjTscgJNpQWVOAZXDHr1qaTqjRAbj XWEacWDtXgWlhs0qijc/TmsopQG9p4owpSHjKYcJ8p/aEnYryOSUk1J/9aUDhYE3 Su5SMas/9oNpdQLiXrymtNnKXS4S8UmLR3DVodRjEi+yudiH4tAa7GVgad4OKmik QxlP/TWm5pmlVQAsXpYtIe/VVRRbzh0VJKGjbtJdMewmTGbpDEr1eFiya/79QSfA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrfeeggdekiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id E5B3F328005A; Thu, 1 Oct 2020 11:04:35 -0400 (EDT) Date: Thu, 1 Oct 2020 17:04:34 +0200 From: Maxime Ripard To: Hoegeun Kwon Subject: Re: [PATCH 1/2] drm/vc4: kms: Assign a FIFO to enabled CRTCs instead of active Message-ID: <20201001150434.g2wleylc7l6tj2nd@gilmour.lan> References: <20200918145918.101068-1-maxime@cerno.tech> <226dbb4a-e97a-f6b3-645e-785a20bbdacd@samsung.com> MIME-Version: 1.0 In-Reply-To: <226dbb4a-e97a-f6b3-645e-785a20bbdacd@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201001_110445_031916_DE9B1629 X-CRM114-Status: GOOD ( 22.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim Gover , Dave Stevenson , dri-devel@lists.freedesktop.org, Eric Anholt , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, =?utf-8?B?64KY7ISx6rWt?= , Phil Elwell , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============8918728098704116678==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8918728098704116678== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5tw7v2xntnj4obcw" Content-Disposition: inline --5tw7v2xntnj4obcw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 24, 2020 at 05:08:56PM +0900, Hoegeun Kwon wrote: > Hi Maxime, >=20 > On 9/18/20 11:59 PM, Maxime Ripard wrote: > > The HVS has three FIFOs that can be assigned to a number of PixelValves > > through a mux. > > > > However, changing that FIFO requires that we disable and then enable the > > pixelvalve, so we want to assign FIFOs to all the enabled CRTCs, and not > > just the active ones. >=20 > Thanks for the patch. >=20 > There is a problem when doing page flip. > After connecting 2 HDMIs without hotplug and booting.(Same thing when > using hotplug.) >=20 > When executing page flip for each of HDMI 0 and 1 in modetest > operation does not work normally. (crtc irq does not occur, so timeout=20 > occurs.) > Sometimes both hdmi 0 or 1 work or not. >=20 > LOGs: > root:~> modetest -Mvc4 -s 32:1280x720 -v > setting mode 1280x720-60Hz@XR24 on connectors 32, crtc 64 > failed to set gamma: Invalid argument > freq: 60.24Hz > freq: 60.00Hz >=20 > root:~> modetest -Mvc4 -s 38:1280x720 -v > setting mode 1280x720-60Hz@XR24 on connectors 38, crtc 69 > failed to set gamma: Invalid argument > select timed out or error (ret 0) > select timed out or error (ret 0) >=20 > Could you please check it? So I can reproduce that bug, but I've not been able to fix it yet. The issue seems to happen 100% of the time when you start first with the second connector, and then the first. It creates yet another muxing corner case, which is that when the first modeset runs, there's only one enabled CRTC (with the 69 here) that gets assigned the channel 0 (since it's the only one and it can run from that channel). However, when modeset exits, it doesn't disable that CRTC for some reason. Then you enable a second CRTC (64) with the second modeset command, but it has a lower index so it gets evaluated first and gets assigned the channel 0 as well since we haven't removed the CRTC 69 from the pool yet. I've fixed that up by first removing the channels in current use, and then allocating them in two separate passes, but it doesn't address the problem entirely, so I'll keep looking. Maxime --5tw7v2xntnj4obcw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX3XwAgAKCRDj7w1vZxhR xW0kAQDrvqxIBKWe9EPtrZibFmb88iU0CFvkWQPZJ2y0NRxOLAD/cEat243uR/LF S3N1zXZVD+Qdqw0Gpwebn2NKbqnmRAI= =hi47 -----END PGP SIGNATURE----- --5tw7v2xntnj4obcw-- --===============8918728098704116678== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8918728098704116678==--