From: Guenter Roeck <linux@roeck-us.net>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-watchdog@vger.kernel.org, srv_heupstream@mediatek.com,
seiya.wang@mediatek.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, linux-mediatek@lists.infradead.org,
Crystal Guo <crystal.guo@mediatek.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [v5,0/4] watchdog: mt8192: add wdt support
Date: Thu, 1 Oct 2020 08:16:39 -0700 [thread overview]
Message-ID: <20201001151639.GC64648@roeck-us.net> (raw)
In-Reply-To: <71e21cfd-fd44-2cf9-cf8a-f83dc1b0cc89@gmail.com>
On Thu, Oct 01, 2020 at 04:23:02PM +0200, Matthias Brugger wrote:
> Hi Crystal,
>
> It seems you forgot to send the email to one of the maintainers, Wim.
> Please make sure you add all the maintainers from get_maintainers.pl when
> you send a series.
>
> Regards,
> Matthias
>
> On 29/09/2020 05:20, Crystal Guo wrote:
> > v5 changes:
> > fix typos on:
> > https://patchwork.kernel.org/patch/11697493/
> >
> > v4 changes:
> > revise commit messages.
> >
> > v3 changes:
> > https://patchwork.kernel.org/patch/11692731/
> > https://patchwork.kernel.org/patch/11692767/
> > https://patchwork.kernel.org/patch/11692729/
> > https://patchwork.kernel.org/patch/11692771/
> > https://patchwork.kernel.org/patch/11692733/
This is less than helpful. It doesn't tell me anything. It expects me to
go back to the earlier versions, download them, and run a diff, to figure
out what changed. That means the patch or patch series ends at the bottom
of my pile of patches to review. Which, as it happens, is quite deep.
I will review this and similar patches without change log after (and only
after) I have reviewed all other patches in my queue.
Guenter
> >
> > Crystal Guo (4):
> > dt-binding: mediatek: watchdog: fix the description of compatible
> > dt-binding: mediatek: mt8192: update mtk-wdt document
> > dt-binding: mt8192: add toprgu reset-controller head file
> > watchdog: mt8192: add wdt support
> >
> > .../devicetree/bindings/watchdog/mtk-wdt.txt | 5 ++--
> > drivers/watchdog/mtk_wdt.c | 6 +++++
> > .../dt-bindings/reset-controller/mt8192-resets.h | 30 ++++++++++++++++++++++
> > 3 files changed, 39 insertions(+), 2 deletions(-)
> > create mode 100644 include/dt-bindings/reset-controller/mt8192-resets.h
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-01 15:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 3:20 [v5,0/4] watchdog: mt8192: add wdt support Crystal Guo
2020-09-29 3:20 ` [v5, 1/4] dt-binding: mediatek: watchdog: fix the description of compatible Crystal Guo
2020-09-29 3:20 ` [v5,2/4] dt-binding: mediatek: mt8192: update mtk-wdt document Crystal Guo
2020-10-02 9:28 ` Matthias Brugger
2020-10-09 3:32 ` Crystal Guo
2020-09-29 3:20 ` [v5,3/4] dt-binding: mt8192: add toprgu reset-controller head file Crystal Guo
2020-09-29 3:20 ` [v5,4/4] watchdog: mt8192: add wdt support Crystal Guo
2020-10-01 14:23 ` [v5,0/4] " Matthias Brugger
2020-10-01 15:16 ` Guenter Roeck [this message]
2020-10-02 9:51 ` Matthias Brugger
2020-10-02 14:41 ` Guenter Roeck
2020-10-09 3:20 ` Crystal Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001151639.GC64648@roeck-us.net \
--to=linux@roeck-us.net \
--cc=crystal.guo@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=seiya.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).