From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FBA0C4727E for ; Thu, 1 Oct 2020 17:47:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD3A920759 for ; Thu, 1 Oct 2020 17:47:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RQAvsWKj"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="T3AeyqU7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD3A920759 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=40twHGqTs9uPHDigq71o0yq462qildkmsm/Rdqya8hQ=; b=RQAvsWKjztQuV8d8ZHC3/KUpM aS7bViUtuw+PVIbROgFaGAldBgti33HryBFQFo7rpZn9eKchxKgFrL4F2tR41a2Cpxto0VHfoWHjE XnbgCRjdt00jIOORBAYTRuIyrdgopoJutltMU8SBR3AcqD5BRVXbBXSe0KdvO6WD2vQx4hk99bJ3P SR6VDujEs6QGlVzIj5eFZr4ybsSqvqCP8n4CKQLD4ydruO0P5aTrTC8/8/MzOmz++9lVhcgoH+tM6 qSsrCgbqXeImQxLU/ERoerIk6sq2X58GCPanddQTb43a4eRBD6jRQrj4Qoe6Zan+KIwu5brfZyWAs RLdSHT4rw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kO2eb-0004uZ-0l; Thu, 01 Oct 2020 17:46:05 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kO2eX-0004st-Oq for linux-arm-kernel@lists.infradead.org; Thu, 01 Oct 2020 17:46:02 +0000 Received: by mail-wr1-x441.google.com with SMTP id k15so6786498wrn.10 for ; Thu, 01 Oct 2020 10:46:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4X89ICg6LS0dHFVQkSUqAoV+hQlz/eq43PpADvUh29Q=; b=T3AeyqU7xkY2nJbeE9ox+8W8WTr+v/MvS0TOtz0WBwvoAfbOn3b23v+aC6OV5Z9qeC X9jf8YhWtYireUwIaP6Fo5z0IP4R2VZWBAW0KGnfdqLiYw5dD4q20u6LJntLwPO2d/+7 XOXsMz6pqvfVRKFW17eyZZ4IpPEEgwVUI6iij7/zGPUm00u50UVij6kacWy/cS1P2Phz rHFKDa+ee27rxnrBM0CO9BgU+GZU+w3h5lGnJ8u1soUKKpvBU9BBm4J5pAonhtShRNbr JJ5ZWCy5oIeD1G28gPNx1qthN/D5OWxATs4qG7nCLWNEhVAirocoPYkaxNjxv5BhzUHi +91A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4X89ICg6LS0dHFVQkSUqAoV+hQlz/eq43PpADvUh29Q=; b=NV33KYZLVXXxQowO0cGrZudAdRuE04/+xapKElNl4d9Ih+jm14wAZRbq4qYA3kaihV 7jOLcZUHwiIwNfOeTOO+QobhyJDKGKpO7hfWMjskDqaexhqn91q5r7QobphyYYGGBeT0 X3U6PMwxRJRYryIq4AoXj1HcBEfqODAwX5GIn1+GId2AiyYsgXsWYaanOpx91+Rj0AYi mjLJBwMBkdYScaZWr8nCyYI7oDqpQQ+1EPIGWXHqI+zC+eFTon/C2SuvtyG7aDEJ9n4I B0uzydteOBB6spKdwYaWpOxpkgBpMItRQxC8joagM1hbXzJdYdoHaoDa1Cn6bHRh0AeE 1JYw== X-Gm-Message-State: AOAM533K+F3AjgvSvbJwOMs9STtWfxQr7eV4vjE/ShUYZ8Io/ntWx7k/ F1QLm+v3Bknvs2449knaCZPG2w== X-Google-Smtp-Source: ABdhPJwgVoEbDG6cvTnMMQikPDpiTvYKZ5GZ/vqyc675l6eTSpho1m29kdZjBfyxcUZWkPeR+KBgFw== X-Received: by 2002:a5d:634e:: with SMTP id b14mr9870455wrw.190.1601574360526; Thu, 01 Oct 2020 10:46:00 -0700 (PDT) Received: from elver.google.com ([100.105.32.75]) by smtp.gmail.com with ESMTPSA id k6sm888277wmf.30.2020.10.01.10.45.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2020 10:45:59 -0700 (PDT) Date: Thu, 1 Oct 2020 19:45:54 +0200 From: elver@google.com To: Andrey Konovalov Subject: Re: [PATCH v3 17/39] kasan: rename print_shadow_for_address to print_memory_metadata Message-ID: <20201001174554.GM4162920@elver.google.com> References: <8580d4945df57614053084eee8f318edb64712d3.1600987622.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8580d4945df57614053084eee8f318edb64712d3.1600987622.git.andreyknvl@google.com> User-Agent: Mutt/1.14.5 (2020-06-23) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201001_134601_824330_BF325167 X-CRM114-Status: GOOD ( 21.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Branislav Rankov , Elena Petrova , Catalin Marinas , Kevin Brodsky , Will Deacon , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 25, 2020 at 12:50AM +0200, Andrey Konovalov wrote: > This is a preparatory commit for the upcoming addition of a new hardware > tag-based (MTE-based) KASAN mode. > > Hardware tag-based KASAN won't be using shadow memory, but will reuse > this function. Rename "shadow" to implementation-neutral "metadata". > > No functional changes. > > Signed-off-by: Andrey Konovalov > Signed-off-by: Vincenzo Frascino Reviewed-by: Marco Elver > --- > Change-Id: I18397dddbed6bc6d365ddcaf063a83948e1150a5 > --- > mm/kasan/report.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index 145b966f8f4d..9e4d539d62f4 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -250,7 +250,7 @@ static int shadow_pointer_offset(const void *row, const void *shadow) > (shadow - row) / SHADOW_BYTES_PER_BLOCK + 1; > } > > -static void print_shadow_for_address(const void *addr) > +static void print_memory_metadata(const void *addr) > { > int i; > const void *shadow = kasan_mem_to_shadow(addr); > @@ -311,7 +311,7 @@ void kasan_report_invalid_free(void *object, unsigned long ip) > pr_err("\n"); > print_address_description(object, tag); > pr_err("\n"); > - print_shadow_for_address(object); > + print_memory_metadata(object); > end_report(&flags); > } > > @@ -347,7 +347,7 @@ static void __kasan_report(unsigned long addr, size_t size, bool is_write, > if (addr_has_metadata(untagged_addr)) { > print_address_description(untagged_addr, get_tag(tagged_addr)); > pr_err("\n"); > - print_shadow_for_address(info.first_bad_addr); > + print_memory_metadata(info.first_bad_addr); > } else { > dump_stack(); > } > -- > 2.28.0.681.g6f77f65b4e-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel