From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3290CC4363C for ; Fri, 2 Oct 2020 15:49:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F1F92074B for ; Fri, 2 Oct 2020 15:49:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NA9d4iEv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F1F92074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=h/ZPpEvjlRupeECnuSpf9wLxb2XvaLBY74db5chHoFA=; b=NA9d4iEvTIFIp82PBIqxuJbk7N cCLiecFPqjLBy6Bm0LqJoVtUDkkUdSecNsyKa7VBAZFgMaImtpN9Xsa+40Or1DvZ4X4FnTFMl7OqE aKHmPmhC2+gpaMzkxeT3kOXdc38WKp5c8M9Md+nwACA3g0+/7l8reljh55l1auarTBuStuWMt1YV8 ZivhCmZBV8VnX6M5g+QVVHZcIf+19P0uiIqIDdcHCtLzoKtAWjh3wwT8DK8NoAM3N0GFtdQbxPt1V nFdkagvmIAroBxc0wEq4nShl94+nBmuEyFIrb9kiW222vZRVyV7p0wzwauHNo28dJUyGzvGWlJ4Iw uH2vAYAw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kONHz-00064l-Sx; Fri, 02 Oct 2020 15:48:07 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kONHx-000642-BN for linux-arm-kernel@lists.infradead.org; Fri, 02 Oct 2020 15:48:06 +0000 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kONHt-0000L3-6C; Fri, 02 Oct 2020 15:48:01 +0000 From: Colin King To: Will Deacon , Mark Rutland , Robin Murphy , linux-arm-kernel@lists.infradead.org Subject: [PATCH][next] perf: arm-cmn: fix less than zero check on unsigned dtc->irq Date: Fri, 2 Oct 2020 16:48:00 +0100 Message-Id: <20201002154800.92607-1-colin.king@canonical.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201002_114805_467637_23C05D45 X-CRM114-Status: GOOD ( 13.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Colin Ian King Currently the failure check on dtc->irq is always false because dtc->irq is an unsigned int. Fix this by using a temporary signed int for the less than zero error check. Addresses-Coverity: ("Unsigned compared against 0") Fixes: 0ba64770a2f2 ("perf: Add Arm CMN-600 PMU driver") Signed-off-by: Colin Ian King --- drivers/perf/arm-cmn.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c index a76ff594f3ca..21819af163f3 100644 --- a/drivers/perf/arm-cmn.c +++ b/drivers/perf/arm-cmn.c @@ -1246,11 +1246,13 @@ static int arm_cmn_init_dtc(struct arm_cmn *cmn, struct arm_cmn_node *dn, int id { struct arm_cmn_dtc *dtc = cmn->dtc + idx; struct arm_cmn_node *xp; + int irq; dtc->base = dn->pmu_base - CMN_PMU_OFFSET; - dtc->irq = platform_get_irq(to_platform_device(cmn->dev), idx); - if (dtc->irq < 0) - return dtc->irq; + irq = platform_get_irq(to_platform_device(cmn->dev), idx); + if (irq < 0) + return irq; + dtc->irq = irq; writel_relaxed(0, dtc->base + CMN_DT_PMCR); writel_relaxed(0x1ff, dtc->base + CMN_DT_PMOVSR_CLR); -- 2.27.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel