From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66C1BC4363A for ; Mon, 5 Oct 2020 08:08:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBD4920774 for ; Mon, 5 Oct 2020 08:08:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NMVPwaMd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBD4920774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RqqzL2cYdksUjyUKURviQnAqAndubzFGLP40I1i1Gd4=; b=NMVPwaMdtzVjkRiFM4UILxh5w Xk+iHfjsR6Gp+1eArTVIoxBO1SfkdYl6XF9BUJ9CUA/c4NhERzjM+QH+Pf2sonUYHW9wpE6oSJRCm Ri1KxiCQUbzBPDkkx+gZ8s1p/C2xGkq5G86U4uxEWwXCAmPTY0THIcoGXERDPnTjgSynPMJVdCV9M LaJ72WEXLVju/HLCbKA7v9JKCBemd0PYPfEeUPVuhof5CKMu53Npa+BhedOENSVkNp3ZyYQcvKdjD MnFXsILlZmDwS7lUHBdDMzcPe6GcCLgti5CO19KVijzAbFuWjhrYRMfQvbH3CZjtgFN6dwft9jF8t 7TIb5blCg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPLWv-0003kD-Nc; Mon, 05 Oct 2020 08:07:33 +0000 Received: from mail-wm1-f68.google.com ([209.85.128.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPLWs-0003j6-H6 for linux-arm-kernel@lists.infradead.org; Mon, 05 Oct 2020 08:07:31 +0000 Received: by mail-wm1-f68.google.com with SMTP id p15so3103614wmi.4 for ; Mon, 05 Oct 2020 01:07:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=AG8hP+MezQ849TpBpF7ybR9g9DALSYRtEfvkXe75nk4=; b=ggIVbvhdYfqaU2HgOeafXZgn8BpxHTFDryO6Qb2j6RHnSDgkMm6ZoAwKkjcNPzfL5y PqA9y2nzhiXy4U8VthLLutlz2YRCbTJT+FCQK/j7Hug/H/4mNQPFUM/dqtu3UEXu4GXQ QyXtHLMiNQlJDPQhFinXWOB42UQoGBlb/mnd4JPbYdff9D7q9fn9nd5HC/DsNk3h7pvk r+CdOHqJ/qpbabN8KwMg4MGScrR+6USIVq5qdJ4piMa9vKqLfGlrdOgMxenVrRKffSap sedri3tHbONgAVHvt5G1BvSqxkVZcuyMty5P7FZWn3F1sc8u/pcz1rsYOWFEycmH2Mex Gq7w== X-Gm-Message-State: AOAM5333f+xTyhe1MBPjs9jqsz9HE0IjxOCJ4BJEF7WDVyIhXCHrx/xv pgepH6sVBGYWnfS0LZb23Bo= X-Google-Smtp-Source: ABdhPJz0EMxPP196puOZzbWz1QWSvH4Y5YFa5lgdP6kVwE0lTzseA0j+Dt236zq0xwzGSLA9GVLNtA== X-Received: by 2002:a05:600c:230a:: with SMTP id 10mr5056204wmo.151.1601885248796; Mon, 05 Oct 2020 01:07:28 -0700 (PDT) Received: from kozik-lap ([194.230.155.194]) by smtp.googlemail.com with ESMTPSA id c16sm12558625wrx.31.2020.10.05.01.07.27 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 05 Oct 2020 01:07:27 -0700 (PDT) Date: Mon, 5 Oct 2020 10:07:25 +0200 From: Krzysztof Kozlowski To: Christian Eggers Subject: Re: [PATCH v2 2/3] i2c: imx: Check for I2SR_IAL after every byte Message-ID: <20201005080725.GB7135@kozik-lap> References: <20201002152305.4963-1-ceggers@arri.de> <20201002152305.4963-3-ceggers@arri.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201002152305.4963-3-ceggers@arri.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201005_040730_600246_94D8FD4B X-CRM114-Status: GOOD ( 15.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Oleksij Rempel , NXP Linux Team , Pengutronix Kernel Team , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 02, 2020 at 05:23:04PM +0200, Christian Eggers wrote: > Arbitration Lost (IAL) can happen after every single byte transfer. If > arbitration is lost, the I2C hardware will autonomously switch from > master mode to slave. If a transfer is not aborted in this state, > consecutive transfers will not be executed by the hardware and will > timeout. > > Signed-off-by: Christian Eggers > Cc: stable@vger.kernel.org > --- > drivers/i2c/busses/i2c-imx.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > Tested (not extensively) on Vybrid VF500 (Toradex VF50): Tested-by: Krzysztof Kozlowski The I2C on Vybrid VF500 still works fine. I did not test this actual condition (arbitration) but only a regular I2C driver (BQ27xxx fuel gauge). Obviously this only proves that regular operation is not broken... Alternatively if you have a specific testing procedure (reproduction of a problem), please share. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel