From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ABDFC4727D for ; Mon, 5 Oct 2020 08:27:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4FEC20776 for ; Mon, 5 Oct 2020 08:27:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="krbpDOEm"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="k/c78Y7c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4FEC20776 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JjZywFB14+K1FMaluXvdt57iTt9wmhdBGinyewqNZU0=; b=krbpDOEm0YEIbEqAwnPCggVai 0fXDk2ygC1k9Ea+ACGbJGEC6hMaWf0rbovM5RYAAUAHV6votMcdQ9pMU9t4D0ghdcXMjta4EOFV6j CUOn/AyE7XXmhb+XuyF173tyXpXUxdZMEI8JsmPPvC59p0hSKlrE8A5qooifLZvElmKpfjLtVqTFr h5Ptbgn7oGnYScxxdwGVAoqdpSWUMvpwUFtavWFfRqsL4/vV23D1cTNOgOG/RgAwr2npH6U/c3MZn 2UP6CrB9OygYTPzpapqp+pXaDBAWnThVIU8PHO+8jzSlm1W7f659GOoS/KhM2G7GuHI1mEBDE/jM7 54q/mDhgw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPLoz-0006ez-4B; Mon, 05 Oct 2020 08:26:13 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPLow-0006e5-Pm for linux-arm-kernel@lists.infradead.org; Mon, 05 Oct 2020 08:26:11 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 236292075A; Mon, 5 Oct 2020 08:26:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601886369; bh=Q6bpCS8F8w3+QNHcxdWg85Or0V7pIwMQIPCDJNBV7lE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k/c78Y7czRAZyZy0mdVpMcZVDpYjyq43EGMX4cfoLBxJmLojzgWfrPBRVTmuxIU9k +fmJWSf4jr0B7Po/SEulFcUG/8LAv7SeDHd9yAjGdiUbQu6U8GoZs+qekziEA9gLOe +BOIZh2q9HYC9drlfc9kJ9c7Qp5sh2OISbfAqxZ8= Date: Mon, 5 Oct 2020 09:26:04 +0100 From: Will Deacon To: Colin King Subject: Re: [PATCH][next] perf: arm-cmn: fix less than zero check on unsigned dtc->irq Message-ID: <20201005082603.GA23480@willie-the-truck> References: <20201002154800.92607-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201002154800.92607-1-colin.king@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201005_042610_905794_7E2375E3 X-CRM114-Status: GOOD ( 14.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , kernel-janitors@vger.kernel.org, Robin Murphy , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 02, 2020 at 04:48:00PM +0100, Colin King wrote: > From: Colin Ian King > > Currently the failure check on dtc->irq is always false because > dtc->irq is an unsigned int. Fix this by using a temporary signed > int for the less than zero error check. > > Addresses-Coverity: ("Unsigned compared against 0") > Fixes: 0ba64770a2f2 ("perf: Add Arm CMN-600 PMU driver") > Signed-off-by: Colin Ian King > --- > drivers/perf/arm-cmn.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) Cheers, but Gustavo beat you to it and I had a crack at a different fix which should now be in -next: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/commit/?h=for-next/core&id=d9ef632fab9ba81b708763bcbcfdbea9a55c95d2 Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel