From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05945C4363A for ; Mon, 5 Oct 2020 11:25:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 900C220795 for ; Mon, 5 Oct 2020 11:25:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N/ND413g"; dkim=temperror (0-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="VAfQeAFQ"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="MUyRZIUt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 900C220795 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D2DsbzQBN4/0zUVAlN4X/+gf3pgV9cVR4mpehKj7PaM=; b=N/ND413gjcfYHD193ZLmaYEIH Bmdt8CxLo/aQvu16pB7rV6PWXPPfsM9TMj8ewbfrKh5naeGBHx+vSJEhQas4JLtj8ZjV0+gIiKmS3 PykIQR/JZY8o3koypxIT5GDYTLb86c3VaXRNo4KQhQP7jfClnEqvwpABYPUPnJUCzwYAB0Ip5OAdv 7aEkR90lwsVexkhBvZqMR9BlnURMt8kOdOsW+QpqWGg2N0JRIIcQuAmKDjxlrEty4Eu+b9bQOJQwV b7h9dY74LVpoujYIY4l/9co1MO4p4VczTDFMPwWfSW+FBSSzNl3NPvytRmbaSOSVAYFRO8Hd4mge7 fFduhrAIg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPObT-00073x-Tn; Mon, 05 Oct 2020 11:24:27 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPObQ-00072o-Jh for linux-arm-kernel@lists.infradead.org; Mon, 05 Oct 2020 11:24:25 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id B830D5C012B; Mon, 5 Oct 2020 07:24:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 05 Oct 2020 07:24:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=SMknaWd59JlI04yMEv6mOREluuD TBiqnWDc4DKpb+8s=; b=VAfQeAFQ7OVvpzTG+XmyFZCtakGWjOMKd2f9izr+Eyw qM00vQkDnaw0njDu6uRN+qmQiWPcwmOQ2LW0Qnw5JBs9duHFItKWaCYUF7pMRuEb 9vQskD+ZuNKHcaLmokKIO+QmkrgmxppYHm1m0l3txVDc6yNjfNAMZN2Mv/2jD5iP rDIXcxP5fSdUFOfzY0ZoTArNYz3gPqfw5msBpSHMEjhWwSeG4cNkSMbTXmaLAIS7 g2LaQNokdvmExks+QXh42U5RZ7j/GlRm16MB/pmXb4j4+s1cdXY4bumoTjrWA5gf K7PlXjuwoW+HjoIjgzmYmQUhE0nXWok9CRpCqMUaBHA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=SMknaW d59JlI04yMEv6mOREluuDTBiqnWDc4DKpb+8s=; b=MUyRZIUt8ao9kblC67YX9K 8gvP++l1QAF/HVA4FoQQXZ5FFKpzgPfnKueotZPW9fHDH+QNuxJCiqfn3NQJVdKX j+9BwRZl9uB7ceIm9PbvE6ioLGVCUgtJxbt6KR+RWtXJAngX0VvIhYnsNXl+QVqX +qipy7re+Gv4WQmEk+jVuMLdUh3rgTMY0wWPh1cWdYgWjTx/YXlRwC4s84GZHS1d 653B2cVAdZJcuaR3tVEuq7RB72CUlxFoRI5svtlt5zN6AvD7nprm9TpVjJXEfaSG WbdDz9kvRCfWHl7ysEdkSGafokb0TkWt4MQaiT+DRPkH3qiKRuZsHr+dtBwWYGpQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrgedvgdegvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id B86B6328005A; Mon, 5 Oct 2020 07:24:19 -0400 (EDT) Date: Mon, 5 Oct 2020 13:24:18 +0200 From: Maxime Ripard To: Samuel Holland Subject: Re: [PATCH 09/25] ASoC: sun8i-codec: Prepare to extend the DAI driver Message-ID: <20201005112418.gxxwrjnfnukmdvgy@gilmour.lan> References: <20201001021148.15852-1-samuel@sholland.org> <20201001021148.15852-10-samuel@sholland.org> MIME-Version: 1.0 In-Reply-To: <20201001021148.15852-10-samuel@sholland.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201005_072424_838828_34AF35B7 X-CRM114-Status: GOOD ( 19.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ondrej Jirman , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Chen-Yu Tsai , Mark Brown , Jaroslav Kysela , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============3628973131067759175==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3628973131067759175== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="w4bavsivf5xoegl7" Content-Disposition: inline --w4bavsivf5xoegl7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Wed, Sep 30, 2020 at 09:11:32PM -0500, Samuel Holland wrote: > In preparation for adding additional DAIs to this component, convert the > DAI driver definition to an array. Since this changes all of the lines > in the definition anyway, let's move it closer to the ops function > definitions, instead of on the far side of the DAPM arrays. And while > moving the DAI driver ops, rename the set_fmt hook to match the usual > naming scheme. >=20 > Give the existing DAI an explicit ID and more meaningful stream names, > so it will remain unique as more DAIs are added. The AIF widget streams > must be updated to match. >=20 > Signed-off-by: Samuel Holland > --- > sound/soc/sunxi/sun8i-codec.c | 76 +++++++++++++++++++---------------- > 1 file changed, 42 insertions(+), 34 deletions(-) >=20 > diff --git a/sound/soc/sunxi/sun8i-codec.c b/sound/soc/sunxi/sun8i-codec.c > index 7590c4b04d14..346f699c2e86 100644 > --- a/sound/soc/sunxi/sun8i-codec.c > +++ b/sound/soc/sunxi/sun8i-codec.c > @@ -90,16 +90,21 @@ > #define SUN8I_SYSCLK_CTL_AIF2CLK_SRC_MASK GENMASK(5, 4) > #define SUN8I_SYS_SR_CTRL_AIF1_FS_MASK GENMASK(15, 12) > #define SUN8I_SYS_SR_CTRL_AIF2_FS_MASK GENMASK(11, 8) > #define SUN8I_AIF1CLK_CTRL_AIF1_BCLK_DIV_MASK GENMASK(12, 9) > #define SUN8I_AIF1CLK_CTRL_AIF1_LRCK_DIV_MASK GENMASK(8, 6) > #define SUN8I_AIF1CLK_CTRL_AIF1_WORD_SIZ_MASK GENMASK(5, 4) > #define SUN8I_AIF1CLK_CTRL_AIF1_DATA_FMT_MASK GENMASK(3, 2) > =20 > +enum { > + AIF1, > + NAIFS > +}; > + It's a bit of a nitpick, but we should have less generic names for the enums here, maybe prefix it with sun8i_codec like the rest of the driver? Once fixed, Acked-by: Maxime Ripard Maxime --w4bavsivf5xoegl7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX3sCYQAKCRDj7w1vZxhR xbqiAQC0ysaCPi3YH7Tsq2y/aLzL91Nsz8t9RHusgPVOQAD11gEAiPFKoJZh1uw1 Mnq8t+XP9zAHc6QsdYz3rCgLjHsdiAU= =mtg+ -----END PGP SIGNATURE----- --w4bavsivf5xoegl7-- --===============3628973131067759175== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3628973131067759175==--