From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEC9AC4727E for ; Mon, 5 Oct 2020 11:29:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 779CC20774 for ; Mon, 5 Oct 2020 11:29:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="wr1IcsEk"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X+C2jta0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 779CC20774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vte3aoS6O4AbxoOZhEr9gV5C8oOk62DVhv2gqU+Ryog=; b=wr1IcsEkJM8n0/ZqVEDV/Y6JX fmMHXuyIbfsxuSwli9bpoKrRsKfgW0HeoLawg3fdQ98iDK4T3bxdEdqTivCwy1KNjP+cYVGrDJft6 MC1YhXe5loHx9pPmatCgBtglZol0+q5WNnUKvzilmLATvIKrijovZFGgt9b/TiBTag30T5Dmb+TQZ HLn71pfguABIFf4Sj2MSnbjK7E83zNZAN6P3RzDQD65AEcoC66dgbVZFAXmzUZpz+rYpCx4nrZ5po YlEtvoZvGBuzYOpgLJ/Z3hf1y6ZJ6z+YYDDJqdKg15Hqlbx/5ezpbFTlMmd8llEQGZDccoc2VRYr1 KuP1kWsMQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPOey-0007iN-Ff; Mon, 05 Oct 2020 11:28:04 +0000 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPOet-0007er-Vd for linux-arm-kernel@lists.infradead.org; Mon, 05 Oct 2020 11:28:01 +0000 Received: by mail-ed1-x543.google.com with SMTP id p13so2936793edi.7 for ; Mon, 05 Oct 2020 04:27:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=BwDv5MO5rrSYkKheEXBgLNjSxoaATzOrKSREX7JeQTI=; b=X+C2jta0WQ9dZQw5812WDSv70h9NVY0sRx7xWT46oiplXSXuvD2wSjpPhF60Ptg94a qFAj+dXHZdEIJ5FVs9oJx0u+SAJz2R4A1AKlWomFFvT0z8rKHzFQn9LKO7I3N6PD92YB hPFxuYXeqpB5tNa9bNjgdiQiltjPrwy0fKWpTKr0i8sFRT2ETbYZCtKgIRTTx/ogfflQ Lt5/XxosLqxQ0JHl3Svnel5fXpHcFNZlMid/kEleq4EUDpNuO022+gVpJmE3xmtyB5bp xpJpe2+Y4SITqpPVjpIqIOHIWCE7GqjEy79jlQ/pkF3SnSu26TJanuvKoXD4r+l7XWTw j86w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BwDv5MO5rrSYkKheEXBgLNjSxoaATzOrKSREX7JeQTI=; b=Cq8XM8PlGFGF5BQbc/pG+108ShbK7+UK1ha3lQVOhs5TWL63TrN5JlDSiePc7eKbuP u7rcnipeqYfLLV9HPPSJcRSG/nU5OBZJ/izPmGTF4bK4acN1gfroXN2ie112IRB5Fths N4/gSb61z3faHKPj6UcUarxGqSO8Li1nPNFtC5asvwTPuyFm3w1veT21CzwrHifYI8lU zXiCD3z0LSUqUPbCYO17C4AHoUiKdcTLu9LyOKcyfbS1EP4HM2jJTaSXSERpVznBTAfI aqi6hJws3QEMEX//0Ca1cBMlPDHZMwT+4p/7bKI8TQM94SWAVvzia4j05a56Z75SYaAp fDtQ== X-Gm-Message-State: AOAM531voKOgfnl3iGvLkObRAObDs7Ii13YQipyCRP4DWE4E9TwZkbbM uPdpvTGFLZVFLeoxRzz2uYw= X-Google-Smtp-Source: ABdhPJz5507FXVIk1muIosCNNyJhsPzeIhVOPxQ+P7bub8nPqPbUcU4RWmwX2UnDZKuxz4tslEfUig== X-Received: by 2002:a50:d987:: with SMTP id w7mr16581456edj.113.1601897278474; Mon, 05 Oct 2020 04:27:58 -0700 (PDT) Received: from localhost ([217.111.27.204]) by smtp.gmail.com with ESMTPSA id rs18sm1407764ejb.69.2020.10.05.04.27.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2020 04:27:57 -0700 (PDT) Date: Mon, 5 Oct 2020 13:27:55 +0200 From: Thierry Reding To: Marc Zyngier Subject: Re: [PATCH 2/3] soc/tegra: pmc: Allow optional irq parent callbacks Message-ID: <20201005112755.GS425362@ulmo> References: <20201005111443.1390096-1-maz@kernel.org> <20201005111443.1390096-3-maz@kernel.org> MIME-Version: 1.0 In-Reply-To: <20201005111443.1390096-3-maz@kernel.org> User-Agent: Mutt/1.14.7 (2020-08-29) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201005_072800_064469_F2CE0B29 X-CRM114-Status: GOOD ( 19.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Venkat Reddy Talla , linux-kernel@vger.kernel.org, Jonathan Hunter , Sowjanya Komatineni , linux-tegra@vger.kernel.org, Dmitry Osipenko , kernel-team@android.com, Thomas Gleixner , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============1753015533135794749==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1753015533135794749== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qZLIv6EoKi7YuaSc" Content-Disposition: inline --qZLIv6EoKi7YuaSc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 05, 2020 at 12:14:42PM +0100, Marc Zyngier wrote: > Make the PMC driver resistent to variable depth interrupt hierarchy, > which we are about to introduce. The irq_chip structure is now > allocated statically, providing the indirection for the couple of > callbacks that are SoC-specific. >=20 > Signed-off-by: Marc Zyngier > --- > drivers/soc/tegra/pmc.c | 65 ++++++++++++++++++++++++++++++++++------- > 1 file changed, 54 insertions(+), 11 deletions(-) >=20 > diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c > index d332e5d9abac..9960f7c18431 100644 > --- a/drivers/soc/tegra/pmc.c > +++ b/drivers/soc/tegra/pmc.c > @@ -439,7 +439,6 @@ struct tegra_pmc { > struct pinctrl_dev *pctl_dev; > =20 > struct irq_domain *domain; > - struct irq_chip irq; Did you have any particular reason for pulling this out of the struct tegra_pmc and making it a global variable? Thierry --qZLIv6EoKi7YuaSc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl97AzsACgkQ3SOs138+ s6HyRg/9FiLC5m3jijFJBXlhg/2WP/TpTbwEdwYRsZsQ01I3rFItcby8jghFz5Nv arFqRmVYZmcpe3Rjs0oLyzuoVQ9F4eXhwnexo/NkKUWXAtflHL7H2faAD3Dv/4SV Noe6am/4uzOxpb0gkxMwk8U4M7qa7vgDlK3keF8LcANUAnd2Xp5wuaNdj7BH1XGV m/3SquQsaTIkNzu/DHKZ0Lptn/dxXl+R1wgl8BkvBiDp95zlEokufVRo+9a6Irk8 ACOg/7V8XT4G82JSkodws4qdZbPFvWN7uI+OrjkWJQAeoFzHVf4nq2EZHvwqf3JL gLZ2WnS5eeNZaMll8xWQ+3OnqF+bR5mAhDA/8Xisss3jFczdQifWJsrUFo+b3L2/ 6qCLqLSMnbeKAEGi34a8J6S/c+op8iqxlfeM7IHMBSxZtUUFeZLumk4gxGY8rrBG VVFgThicqcM3rXVxF42BB/7z/pp5X3hjGfQUF1wXEYkmv0lMRRs91LPdhML51DPU jGnzl+1V+thcZvebAtFuaI/SvTNv01ClchnD4aHrqHjyJQQwzkndxGDK8WFoN/ss wm4TlFERPioedUyVLEBn+uXEVm57BPFVDkPp6gUT3xL8nbHE8F7QhR7+r/dbJ2a7 NuZutGpBrmufbRsVPTAohdVAYepd553C/fs80epcPlg4zsRDt1c= =m80y -----END PGP SIGNATURE----- --qZLIv6EoKi7YuaSc-- --===============1753015533135794749== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1753015533135794749==--