From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23D39C4363D for ; Mon, 5 Oct 2020 15:27:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3ACD20637 for ; Mon, 5 Oct 2020 15:27:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="D1mzonWo"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="LKTs78TR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3ACD20637 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lAJz+98ZYBydK7Dn+nkntDaAf5n8iD6jfi7CwBs+Wgo=; b=D1mzonWo8S9HG0XxNKxuSmGMY sz/19/Ljcmyz1h2HKn7lwq3XYjV1g6RuME1KfkxQlzpACYWMEti/mQolOr4UuKgmfmuBm3I5PiGSl kgVlsSyRdQDTTX+v8Un7PUBO2g5QLzcKSFujmVFfmIwx8GTNkYVgFaRdXmX4urs3G7AhBeFYDIQsj Sru0+5QJo8GgqUq+gq/RFiRomTMvKZ/04bB6lhuxa/7Da0rzG9nup8dH0IdDF/QosnALZdMEiM/0H zcrfnnS6ICrI1+RyJiwSMAhbZOVv7r+MTxanNYkR1XvpD2JHQPjAlJeTrxsRCQE4ArCq1xe7lYCgi XzNOCCZ8A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPSNr-0003pc-4n; Mon, 05 Oct 2020 15:26:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPSNn-0003o8-EA for linux-arm-kernel@lists.infradead.org; Mon, 05 Oct 2020 15:26:36 +0000 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EF67920637; Mon, 5 Oct 2020 15:26:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601911594; bh=1DFlxAOneU1Q7X7FCOfNZN0wL4ZzNAHWNDg5k6DPbvI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LKTs78TRI/ttvaaeCdTLErmQurihH/lZPa2pf/cRUYJ/NoWFTXpoeqenTFihjHDjw cDcWWlcfcDiaXxdXS0+mmlbURBNIbho4R6fXjY6Wtgl2QcGyAKywRKhLJas6BExYVe 13K6pesTw94jy7i2ZnJvW5SrtsyYgk+c6alMbo58= Date: Mon, 5 Oct 2020 16:25:31 +0100 From: Mark Brown To: Olivier MOYSAN Subject: Re: [PATCH 1/1] ASoC: cs42l51: add soft dependency declaration Message-ID: <20201005152531.GE5139@sirena.org.uk> References: <20201002152904.16448-1-olivier.moysan@st.com> <20201002154107.GC5527@sirena.org.uk> <4e7fb9c0-84ea-ba01-cea8-8044d6ff60de@st.com> MIME-Version: 1.0 In-Reply-To: <4e7fb9c0-84ea-ba01-cea8-8044d6ff60de@st.com> X-Cookie: Most of your faults are not your fault. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201005_112635_647095_0E9A1E5C X-CRM114-Status: GOOD ( 20.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "alsa-devel@alsa-project.org" , Alexandre TORGUE , "linux-kernel@vger.kernel.org" , "tiwai@suse.com" , "lgirdwood@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "perex@perex.cz" , "linux-stm32@st-md-mailman.stormreply.com" , "arnaud.patard@rtp-net.org" Content-Type: multipart/mixed; boundary="===============4654505026265731158==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4654505026265731158== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BZaMRJmqxGScZ8Mx" Content-Disposition: inline --BZaMRJmqxGScZ8Mx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 05, 2020 at 03:01:23PM +0000, Olivier MOYSAN wrote: > On 10/2/20 5:41 PM, Mark Brown wrote: >=20 > On Fri, Oct 02, 2020 at 05:29:04PM +0200, Olivier Moysan wrote: >=20 >=20 > When configured as module, CS42L51 codec driver uses two modules > snd-soc-cs42l51 and snd-soc-cs42l51-i2c. > Add soft dependency on snd-soc-cs42l51-i2c in snd-soc-cs42l51, > to allow smart module dependency solving. Please fix your mail client, the formatting is completely broken - there's nothing distinguishing quoted and new text and you've got lines well over 80 columns. > Doesn't the userspace tooling usually manage to figure this out from > symbol usage? > cs42l51.c does not use symbols from cs42l51-i2c.c, so cs42l51-i2c does no= t appear > as a software dependency of cs42l51, for tools such as depmod. > (cs42l51-i2c.c uses symbols from cs42l51.c, > so there is a dependency in this way, but this does not help here) But that's the dependency that exists and we want - the I2C driver is what has the bus bindings in it and will be what we decide to load to instantiate the device, that will then pull in the core code that it needs. > When enabling a sound card based on cs42l51, all required modules are loa= ded automatically, > excepted snd-soc-cs42l51-i2c module. This one has to be inserted explicit= ely. Whatever is going on here this patch is not addressing it. Most likely some ID tables are in the wrong file. --BZaMRJmqxGScZ8Mx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl97OuoACgkQJNaLcl1U h9C2zQf+I6U/7Ee6oL1ZwLeSOSKeU3K681e5iVm0pg2A50BBNhVRhyzrxhdUeHvs zKwL+iBsoTqtW1U1iy8atRxhgWr37zShQox1w4JCpiNxN0SdqLdtACtaHM5V5/3O YlbH254TyscAiUEKyU4cmx3ncjyZ660doyFbdXtRGP0yJCDdLqGfC0avHkhcuRi7 hNwpL+zleSMQ4K9hDh2AC2OD+XCeEJEaW707sSrBZVBk+ZeXT3sgIk8TaUOu+vMf vxVrOdcxo5EEVE40ZcF3KM7mlgBZ47TKgdSTIXQ12HDTiykM0MORQcElsjudCnQ8 GzkgSwHvDBwdRjhQIDKZO3VJMoLqtw== =A6ZW -----END PGP SIGNATURE----- --BZaMRJmqxGScZ8Mx-- --===============4654505026265731158== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4654505026265731158==--