From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96CB7C4363A for ; Mon, 5 Oct 2020 17:22:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D59320665 for ; Mon, 5 Oct 2020 17:22:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0hyQIE2C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D59320665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wdEE7YtFLhaw0C7SoNN3ctfBv+PIThMps49oJ3RdZmQ=; b=0hyQIE2CW8TW1xGOWB3xRikiq ufpD7WILaTRvVEEabun3QBTPXgDp++FEz2eoIy+Ox2D9sSocc7WZXLDV3fXQCPJoXbPuUtsnNky/f ziKAJqazjjIESuQNVy2wQhPC9QaVmImCpRMyWaaF5/q9qRMv/SYCszOnLJT01tbK/rszc27n3hGTw KfmxO1I7VEq/jY7aDWKqEJZEtRyLyHBHr/zk9k0Y/3B20excjIkg7BZAlXOycIf4fE6B67s/b+Rt5 QjA2G58/8v3sg+5nZ29H/KcQWftWXDLPcU9YClnNa9QU+RbfMOAtqIBUdcR/9hwm2mHApWqs9cAV3 kMNlgqxHg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPUAf-0005kO-F5; Mon, 05 Oct 2020 17:21:09 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPUAb-0005j0-Vo; Mon, 05 Oct 2020 17:21:06 +0000 Received: from gaia (unknown [95.149.105.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A5ADD2078E; Mon, 5 Oct 2020 17:21:00 +0000 (UTC) Date: Mon, 5 Oct 2020 18:20:58 +0100 From: Catalin Marinas To: chenzhou Subject: Re: [PATCH v12 3/9] x86: kdump: use macro CRASH_ADDR_LOW_MAX in functions reserve_crashkernel[_low]() Message-ID: <20201005172057.GE14576@gaia> References: <20200907134745.25732-1-chenzhou10@huawei.com> <20200907134745.25732-4-chenzhou10@huawei.com> <20200918072526.GD25604@MiWiFi-R3L-srv> <14e22d92-1601-fc1c-a1c8-e3936d63db42@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <14e22d92-1601-fc1c-a1c8-e3936d63db42@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201005_132106_092588_E6B9EBC4 X-CRM114-Status: GOOD ( 22.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wangkefeng.wang@huawei.com, linux-doc@vger.kernel.org, bhsharma@redhat.com, huawei.libin@huawei.com, guohanjun@huawei.com, will@kernel.org, Baoquan He , corbet@lwn.net, rppt@linux.ibm.com, mingo@redhat.com, dyoung@redhat.com, John.P.donnelly@oracle.com, arnd@arndb.de, xiexiuqi@huawei.com, horms@verge.net.au, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, james.morse@arm.com, prabhakar.pkin@gmail.com, nsaenzjulienne@suse.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 18, 2020 at 05:06:37PM +0800, chenzhou wrote: > On 2020/9/18 16:59, chenzhou wrote: > > On 2020/9/18 15:25, Baoquan He wrote: > >> On 09/07/20 at 09:47pm, Chen Zhou wrote: > >>> To make the functions reserve_crashkernel[_low]() as generic, > >>> replace some hard-coded numbers with macro CRASH_ADDR_LOW_MAX. > >>> > >>> Signed-off-by: Chen Zhou > >>> --- > >>> arch/x86/kernel/setup.c | 11 ++++++----- > >>> 1 file changed, 6 insertions(+), 5 deletions(-) > >>> > >>> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c > >>> index d7fd90c52dae..71a6a6e7ca5b 100644 > >>> --- a/arch/x86/kernel/setup.c > >>> +++ b/arch/x86/kernel/setup.c > >>> @@ -430,7 +430,7 @@ static int __init reserve_crashkernel_low(void) > >>> unsigned long total_low_mem; > >>> int ret; > >>> > >>> - total_low_mem = memblock_mem_size(1UL << (32 - PAGE_SHIFT)); > >>> + total_low_mem = memblock_mem_size(CRASH_ADDR_LOW_MAX >> PAGE_SHIFT); > >> Just note that the replacement has been done in another patch from Mike > >> Rapoport, partially. He seems to have done reserve_crashkernel_low() > >> part, there's one left in reserve_crashkernel(), you might want to check > >> that. > >> > >> Mike's patch which is from a patchset has been merged into Andrew's next > >> tree. > >> > >> commit 6e50f7672ffa362e9bd4bc0c0d2524ed872828c5 > >> Author: Mike Rapoport > >> Date: Wed Aug 26 15:22:32 2020 +1000 > >> > >> x86/setup: simplify reserve_crashkernel() > As Baoquan said, some functions have been changed in the next tree, > if i need to rebase on top of the next tree. Please rebase at 5.10-rc1 when the x86 change will probably be in and aim to queue this series for 5.11. Thanks. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel