From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D78B5C4363D for ; Wed, 7 Oct 2020 12:37:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64E8B20789 for ; Wed, 7 Oct 2020 12:37:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uoq4h2WI"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="cZcO41+5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64E8B20789 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mU17Ti+eWFhz4F4tF29Fi2+qCJVUFXker6wu0tcXfSA=; b=uoq4h2WIfn/UOSn7gONHmn4lo tA4oqHKIn67/go0EJznrYu5gJqev8hLABF80lYXuI0COG52Wt5DRdqU2B8EDqNMsU5CZIS7/TWds9 EaFt7Xhlv66JBO7MsCTCNle75exV9BHKTbXhGk6p0NoavEgzL7TXbjm8sacoTA/kxybfBf+Gqzuwu jS6xRqGLtmk7zsilSxHL0wvf2AAtgZYA4Yh8vbHOqsYnm4SRnQH+Dq7RxcC9YvwlIQ0xjoak9ySIA cnEfEZJdtm+JsN58UI4HFiEd4H0l9W8UzsmElNDxgGpnLM6/7J37nvVUXjqf8Dd43YvDlIHhzU2Q9 zTJzIArJQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQ8fg-0000ym-LF; Wed, 07 Oct 2020 12:35:52 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQ8fe-0000yX-Fp for linux-arm-kernel@merlin.infradead.org; Wed, 07 Oct 2020 12:35:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=A8S5rW2sEaEJHpHml4mFPuJ2r5+DIxjOYtXnAeTe5d4=; b=cZcO41+5mqkO+dDkoy9Q3MuYw/ vGjFobbV9rfsNmO8Vf9dzYmHg7toIxcvMAB4Xmsh0WCB3wKn+l6lwEawXUTLzi+gj7kBaBcruiwez gfcd4yrJ+Zce7OFzUkztjbQlz2/SQ7ISgG0vyzrDNbFnetzpeP3Qphof2P4Yh8Ik4R5tN0LCXpfNK IGD3h+jN4WY69QfQVtgCxs/FTAzGldoXol6IxO1sM66G/Hth5XDyV6EmJlmhI3xfEJxr2S91FEcsP 9siebPZixepPSmbYEzyVH5amKjjV4nAaXypAfliKQbp5Y1z3vJFeg2ovOVMMEii5iR6uBgWnRj2Zr Z0/2uF5Q==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQ8fY-0003dz-Db; Wed, 07 Oct 2020 12:35:44 +0000 Date: Wed, 7 Oct 2020 13:35:44 +0100 From: Christoph Hellwig To: Jann Horn Subject: Re: [PATCH 1/2] mm/mprotect: Call arch_validate_prot under mmap_lock and with length Message-ID: <20201007123544.GA11433@infradead.org> References: <20201007073932.865218-1-jannh@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201007073932.865218-1-jannh@google.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Benjamin Herrenschmidt , Catalin Marinas , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org, Khalid Aziz , Dave Kleikamp , Paul Mackerras , Michael Ellerman , sparclinux@vger.kernel.org, Anthony Yznaga , Andrew Morton , Will Deacon , "David S. Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 07, 2020 at 09:39:31AM +0200, Jann Horn wrote: > diff --git a/arch/powerpc/kernel/syscalls.c b/arch/powerpc/kernel/syscalls.c > index 078608ec2e92..b1fabb97d138 100644 > --- a/arch/powerpc/kernel/syscalls.c > +++ b/arch/powerpc/kernel/syscalls.c > @@ -43,7 +43,7 @@ static inline long do_mmap2(unsigned long addr, size_t len, > { > long ret = -EINVAL; > > - if (!arch_validate_prot(prot, addr)) > + if (!arch_validate_prot(prot, addr, len)) This call isn't under mmap lock. I also find it rather weird as the generic code only calls arch_validate_prot from mprotect, only powerpc also calls it from mmap. This seems to go back to commit ef3d3246a0d0 ("powerpc/mm: Add Strong Access Ordering support") _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel