From: Marek Vasut <marex@denx.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Marek Vasut <marex@denx.de>,
Alexandre Torgue <alexandre.torgue@st.com>,
Patrice Chotard <patrice.chotard@st.com>,
Patrick Delaunay <patrick.delaunay@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
linux-stm32@st-md-mailman.stormreply.com
Subject: [PATCH] ARM: dts: stm32: Consistently enable internal pull-ups for SD bus
Date: Fri, 9 Oct 2020 23:08:20 +0200 [thread overview]
Message-ID: <20201009210820.243659-1-marex@denx.de> (raw)
The default state of SD bus and clock line is logical HI. SD card IO is
open-drain and pulls the bus lines LO. Always enable the SD bus pull ups
to guarantee this behavior. Note that on systems with bus voltage level
shifter on the SD bus, the pull ups might also be built into the level
shifter, however that should have no negative impact.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Patrick Delaunay <patrick.delaunay@st.com>
Cc: linux-stm32@st-md-mailman.stormreply.com
To: linux-arm-kernel@lists.infradead.org
---
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
index b2d19583450c..73d9a5b7f5ba 100644
--- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
@@ -1291,13 +1291,13 @@ pins1 {
<STM32_PINMUX('D', 2, AF12)>; /* SDMMC1_CMD */
slew-rate = <1>;
drive-push-pull;
- bias-disable;
+ bias-pull-up;
};
pins2 {
pinmux = <STM32_PINMUX('C', 12, AF12)>; /* SDMMC1_CK */
slew-rate = <2>;
drive-push-pull;
- bias-disable;
+ bias-pull-up;
};
};
@@ -1447,13 +1447,13 @@ pins1 {
<STM32_PINMUX('G', 6, AF10)>; /* SDMMC2_CMD */
slew-rate = <1>;
drive-push-pull;
- bias-disable;
+ bias-pull-up;
};
pins2 {
pinmux = <STM32_PINMUX('E', 3, AF9)>; /* SDMMC2_CK */
slew-rate = <2>;
drive-push-pull;
- bias-disable;
+ bias-pull-up;
};
};
@@ -1510,7 +1510,7 @@ pins {
<STM32_PINMUX('C', 7, AF10)>; /* SDMMC2_D7 */
slew-rate = <1>;
drive-push-pull;
- bias-disable;
+ bias-pull-up;
};
};
--
2.28.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-10-09 21:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 21:08 Marek Vasut [this message]
2020-10-14 13:26 ` [Linux-stm32] [PATCH] ARM: dts: stm32: Consistently enable internal pull-ups for SD bus Yann GAUTIER
2020-10-14 13:30 ` Marek Vasut
2020-10-14 14:52 ` Yann GAUTIER
2020-10-14 14:55 ` Marek Vasut
2020-10-15 12:44 ` Ahmad Fatoum
2020-10-15 12:52 ` Marek Vasut
2020-10-15 13:18 ` Ahmad Fatoum
2020-10-15 13:40 ` Marek Vasut
2020-10-15 13:47 ` Ahmad Fatoum
2020-10-15 15:51 ` Alexandre Torgue
2020-10-15 17:43 ` Marek Vasut
2020-10-16 6:19 ` Ahmad Fatoum
2020-10-16 11:02 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009210820.243659-1-marex@denx.de \
--to=marex@denx.de \
--cc=alexandre.torgue@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=patrice.chotard@st.com \
--cc=patrick.delaunay@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).