linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: alexandre.belloni@bootlin.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 0/4] iio: adc: at91: misc driver cleanups
Date: Sat, 10 Oct 2020 17:05:53 +0100	[thread overview]
Message-ID: <20201010170553.69d4ad02@archlinux> (raw)
In-Reply-To: <20200930135048.11530-1-alexandru.ardelean@analog.com>

On Wed, 30 Sep 2020 16:50:44 +0300
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:

> This whole thing started because the lkp bot haunted me for a while with
> this build warning:
> 
> >> drivers/iio/adc/at91_adc.c:1439:34: warning: unused variable
> >> 'at91_adc_dt_ids' [-Wunused-const-variable]  
>    static const struct of_device_id at91_adc_dt_ids[] = {
>                                     ^
>    1 warning generated.
> 
> The fix may likely be patch 'iio: adc: at91_adc: add Kconfig dependency
> on the OF symbol'; was pointed out by Jonathan.

Series applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it and see what we missed.

Thanks,

Jonathan

> 
> Changelog v3 -> v4:
> - https://lore.kernel.org/linux-iio/20200930125216.90424-1-alexandru.ardelean@analog.com/T/#t
> - for patch: 'iio: adc: at91_adc: remove platform data and move defs in driver file'
>    * updated/cleand up commit description
>    * remove redundant pdata erorr message
>    * return error code from at91_adc_probe_dt()
>    * remove 'if (!node)' null check in at91_adc_probe_dt()
> - added 'Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>'
>   for patch: 'iio: adc: at91_adc: add Kconfig dep on the OF symbol and remove of_match_ptr()'
> 
> Changelog v2 -> v3:
> - https://lore.kernel.org/linux-iio/20200930060008.42134-1-alexandru.ardelean@analog.com/T/#t
> - added 'Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>'
>   for patches:
>      iio: adc: at91_adc: use of_device_get_match_data() helper
>      iio: adc: at91_adc: const-ify some driver data
> - fixed description for patch 'iio: adc: at91_adc: add Kconfig dependency on the OF symbol'
> - squash patches:
>      iio: adc: at91_adc: add Kconfig dependency on the OF symbol
>      iio: adc: at91_adc: remove of_match_ptr() usage
> - added patch: 'iio: adc: at91_adc: remove platform data and move defs in driver file'
> 
> Changelog v1 -> v2:
> - https://lore.kernel.org/linux-iio/CA+U=Dspd11N-pXXnnY_5CSzNp50iRr7h16zXTCxo8Fk+v48F7g@mail.gmail.com/T/#m7c0efef4dc623776fe8bafdb5f734b0eaca50f82
> - for patch 'iio: adc: at91_adc: use of_device_get_match_data() helper'
>   changed description; it's just tidy-up patch, not a fix
> - added 2 more patches:
>   - iio: adc: at91_adc: add Kconfig dependency on the OF symbol
>   - iio: adc: at91_adc: remove of_match_ptr() usage
> 
> Alexandru Ardelean (4):
>   iio: adc: at91_adc: use of_device_get_match_data() helper
>   iio: adc: at91_adc: const-ify some driver data
>   iio: adc: at91_adc: add Kconfig dep on the OF symbol and remove
>     of_match_ptr()
>   iio: adc: at91_adc: remove platform data and move defs in driver file
> 
>  drivers/iio/adc/Kconfig                |  2 +-
>  drivers/iio/adc/at91_adc.c             | 73 ++++++++++----------------
>  include/linux/platform_data/at91_adc.h | 49 -----------------
>  3 files changed, 28 insertions(+), 96 deletions(-)
>  delete mode 100644 include/linux/platform_data/at91_adc.h
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      parent reply	other threads:[~2020-10-10 16:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 13:50 [PATCH v4 0/4] iio: adc: at91: misc driver cleanups Alexandru Ardelean
2020-09-30 13:50 ` [PATCH v4 1/4] iio: adc: at91_adc: use of_device_get_match_data() helper Alexandru Ardelean
2020-09-30 13:50 ` [PATCH v4 2/4] iio: adc: at91_adc: const-ify some driver data Alexandru Ardelean
2020-09-30 13:50 ` [PATCH v4 3/4] iio: adc: at91_adc: add Kconfig dep on the OF symbol and remove of_match_ptr() Alexandru Ardelean
2020-09-30 13:50 ` [PATCH v4 4/4] iio: adc: at91_adc: remove platform data and move defs in driver file Alexandru Ardelean
2020-09-30 14:05   ` Alexandre Belloni
2020-10-10 16:07     ` Jonathan Cameron
2020-10-10 16:05 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201010170553.69d4ad02@archlinux \
    --to=jic23@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alexandru.ardelean@analog.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).