From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62384C433E7 for ; Mon, 12 Oct 2020 13:06:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 003AB2076C for ; Mon, 12 Oct 2020 13:06:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XFNF4axl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 003AB2076C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pRJH5VIssm5wMKN0w8KmfXibHtSLBj2J6T+LDqe9/Lo=; b=XFNF4axl4uaWuEtbFwfDplHhg FNdvrgEIZqzO1I0mveiXLenl+sPksw1bXtg6WBJWwIGVSfcKykRj574W3uWsZ+pYkrWFhSf6zh/Hz qDwn70XpYQMN/GOmgC7hCJxkL1JTqvKmLo0Qd2WHJKOZorJJERh85xqm0JOJGRbxG1xCyiAOSMhHZ w89r3y1Tp/geFlQ4eiatJTQAznC8rOsu7knnqauGmwPkiW09If3xCOtSdUkiKCt6y+H8lYtJzjKiL b2tQm6UtMEGpux2IaDCeQ66XYoafRV/QTDQadsp3tkmLNDxmFUmQuLSvxsTfmpd+jg0PaJC+5bWwt mTZR61OyQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRxVz-0001Tk-Jl; Mon, 12 Oct 2020 13:05:23 +0000 Received: from mail-ej1-f68.google.com ([209.85.218.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRxVw-0001T2-VP for linux-arm-kernel@lists.infradead.org; Mon, 12 Oct 2020 13:05:21 +0000 Received: by mail-ej1-f68.google.com with SMTP id u21so23072107eja.2 for ; Mon, 12 Oct 2020 06:05:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=w0XrI3+HoVHG4WGLdvd3nsIAb7cMN2XARLbCLmhFRck=; b=JWUnpDkPJMMyFF/V+DLWrQE7/7sPuWtRnQhsygYxLc9/AltNSJ4N3rzi7TErGpA8vb Wtp83iFMZZk5EdaINQSqUG498dIrdR/yjWBqWIFl+jvYa6DZhwAPHaetj/NuvGStI/jS 11vASVbOVUGR0bcBeuEC9Bo6oIwesawmq+vr1KeENtui5E7RIeJ7VY8d/ZL1FU0miz2p RdGtaya4U91fdMJicWySO+103GxAOnariKF/H8Zgl5GXf2L2S2XDVFAILcRKfudm52XQ +3C/9bc8o9eB6NujdtDuYhb9Z1sF0mT9ceJd6NLJuKqJa9NWvtvO/67G3N5CeOZBqiGg Yjzg== X-Gm-Message-State: AOAM5315qscNqngwp5DkhtJBYAkC2aB1dNoD4Cz5cE0TW5K4HBebSqrB e5VeGsJpsymRyZugGFw900A= X-Google-Smtp-Source: ABdhPJwC6oQJ24XDfTrndQhWNvDhYkGiqCuRzbTjAdIEBKJ9fjEf9t9J+CEXTs7ayDrZEQBHv/0+MA== X-Received: by 2002:a17:906:ad94:: with SMTP id la20mr27351161ejb.522.1602507918789; Mon, 12 Oct 2020 06:05:18 -0700 (PDT) Received: from kozik-lap ([194.230.155.215]) by smtp.googlemail.com with ESMTPSA id t7sm4629018edj.45.2020.10.12.06.05.13 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Oct 2020 06:05:17 -0700 (PDT) Date: Mon, 12 Oct 2020 15:05:10 +0200 From: Krzysztof Kozlowski To: Anson Huang Subject: Re: [PATCH V2 2/3] arm64: dts: imx8mn: Correct WDOG_B pin configuration Message-ID: <20201012130510.GB6468@kozik-lap> References: <1602506642-5262-1-git-send-email-Anson.Huang@nxp.com> <1602506642-5262-2-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1602506642-5262-2-git-send-email-Anson.Huang@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201012_090521_082745_C6476B30 X-CRM114-Status: GOOD ( 18.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniel.baluta@nxp.com, peter.chen@nxp.com, abel.vesa@nxp.com, devicetree@vger.kernel.org, festevam@gmail.com, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, Linux-imx@nxp.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, l.stach@pengutronix.de, shawnguo@kernel.org, yibin.gong@nxp.com, aford173@gmail.com, shengjiu.wang@nxp.com, alifer.wsdm@gmail.com, jun.li@nxp.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 12, 2020 at 08:44:01PM +0800, Anson Huang wrote: > Different revision of i.MX8MN EVK boards may have different external > pull up registor design, some are enabled while some are NOT, to make > sure the WDOG_B pin works properly, better to enable internal pull up > resistor. Since enabling internal pull up resistor is NOT harmful and > having benefit of flexibility on different board design, just enable > it for all i.MX8MN boards; And schmitt input is NOT necessary for this > WDOG_B output pin, so remove it; Open drain outputs provide more > flexibility to a designer as they can be pulled-up to any voltage found > in the system, so enable it as well. > > Signed-off-by: Anson Huang > --- > Changes since V1: > - Provide more explanation of removing schmitt input and enabling open drain in commit msg. > --- > arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 2 +- > arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel