From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D79FC43457 for ; Mon, 12 Oct 2020 13:07:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32B482076C for ; Mon, 12 Oct 2020 13:07:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pUS/nHGf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32B482076C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gYwZ36UART/b/ffbHP7ntSYq6WmxvOc5Kj1U4Pczqqg=; b=pUS/nHGf31vPFqr38f5pFJlxs 1S2qjuf84MftYHIpdN6T09BSAAcCxXstbrEPzu5pT1gNj2Czl2GP+qc5U6UO25fELH6LAHUXBUfmp bLERu5/13OeXQCDe5HKzzbPR9i+paNTxrvdGkhR4exOF8U5ttXVu/RCpjbuU1eb5dBNrRnuIq7Zea 2fO9/jFPJ+h5YAdw0f+5n/EYK1/rasVuQTebVd86UdKSS68L2kRTJJKeS5zFtrTqcurTRwTYsLymE 248hdqv6tLjYMaHqqP28Oh2Tp2V1AuS+zdES/pcu+LEZwaiTXJN3UtILu2tYHZ5SjUggvaJvE/yvo 4mKTIapMA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRxWR-0001ar-JB; Mon, 12 Oct 2020 13:05:51 +0000 Received: from mail-ed1-f66.google.com ([209.85.208.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRxWO-0001a5-UX for linux-arm-kernel@lists.infradead.org; Mon, 12 Oct 2020 13:05:49 +0000 Received: by mail-ed1-f66.google.com with SMTP id g4so16881745edk.0 for ; Mon, 12 Oct 2020 06:05:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9ydwIlTuEwN4EX6ZQ9wz8gbjgf5SQz/6nMZbwr7W7Vk=; b=VYYpB+9TftJW2H34a0NPU0btCweLw1ocq+JJYV2IxLKGs3TsZytwQp9jmyObKQaBwI XFIeZ4jh+unpzGikfYNgrmu7P8pyol3vD8rgxRzJ9cT41/v2qJdHY4/RKl4w6FMlCg3m R0z/IP9V52eSN5KImJF56/tGzvZdUcK3QV6QCM6ewbrWo1Yp6dn8uIaLQR6ZYTn4cmmz pR3q3UPGA8jUjUeiRRib+nYn4rnJrcas/589P9zMfEfkCHlt/Lajy+qCt1PPhaG+kzI4 semXcBqZmLhpuE+kKlU41bNaYdKTytTDZlth763XVCgtwIqHOLVrliedPbvJk8H5Lpvi SWdA== X-Gm-Message-State: AOAM530bkk5WloyHmoHA+28z8NW0Mgsm98k4DK3WCACLE/2rciq0oFsX p0FYPaSc4TSPErC7IWmhjEI= X-Google-Smtp-Source: ABdhPJwG6YJ/YqbFjWqAQPFEIXmQsIVRi4YwedcPF81udFn+oBoRWG37Rp2oByAd+zGy1ereOMMvPw== X-Received: by 2002:a50:cd51:: with SMTP id d17mr13794841edj.93.1602507947594; Mon, 12 Oct 2020 06:05:47 -0700 (PDT) Received: from kozik-lap ([194.230.155.215]) by smtp.googlemail.com with ESMTPSA id f28sm10591423edc.94.2020.10.12.06.05.39 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Oct 2020 06:05:46 -0700 (PDT) Date: Mon, 12 Oct 2020 15:05:34 +0200 From: Krzysztof Kozlowski To: Anson Huang Subject: Re: [PATCH V2 3/3] arm64: dts: imx8mp-evk: Correct WDOG_B pin configuration Message-ID: <20201012130534.GC6468@kozik-lap> References: <1602506642-5262-1-git-send-email-Anson.Huang@nxp.com> <1602506642-5262-3-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1602506642-5262-3-git-send-email-Anson.Huang@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201012_090549_063790_97103646 X-CRM114-Status: GOOD ( 18.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniel.baluta@nxp.com, peter.chen@nxp.com, abel.vesa@nxp.com, devicetree@vger.kernel.org, festevam@gmail.com, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, Linux-imx@nxp.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, l.stach@pengutronix.de, shawnguo@kernel.org, yibin.gong@nxp.com, aford173@gmail.com, shengjiu.wang@nxp.com, alifer.wsdm@gmail.com, jun.li@nxp.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 12, 2020 at 08:44:02PM +0800, Anson Huang wrote: > Different revision of i.MX8MP EVK boards may have different external > pull up registor design, some are enabled while some are NOT, to make > sure the WDOG_B pin works properly, better to enable internal pull up > resistor. Since enabling internal pull up resistor is NOT harmful and > having benefit of flexibility on different board design, just enable > it for all i.MX8MP boards; And schmitt input is NOT necessary for this > WDOG_B output pin, so remove it; Open drain outputs provide more > flexibility to a designer as they can be pulled-up to any voltage found > in the system, so enable it as well. > > Signed-off-by: Anson Huang > --- > Changes since V1: > - Provide more explanation of removing schmitt input and enabling open drain in commit msg. > --- > arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel