From: Kalesh Singh <kaleshsingh@google.com>
Cc: joelaf@google.com, Gavin Shan <gshan@redhat.com>,
Brian Geffon <bgeffon@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
kaleshsingh@google.com, Ram Pai <linuxram@us.ibm.com>,
Dave Hansen <dave.hansen@intel.com>,
Will Deacon <will@kernel.org>,
lokeshgidra@google.com, linux-kselftest@vger.kernel.org,
"H. Peter Anvin" <hpa@zytor.com>,
Christian Brauner <christian.brauner@ubuntu.com>,
Shuah Khan <shuah@kernel.org>,
Mina Almasry <almasrymina@google.com>, Jia He <justin.he@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Masahiro Yamada <masahiroy@kernel.org>,
x86@kernel.org, Krzysztof Kozlowski <krzk@kernel.org>,
Steven Price <steven.price@arm.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Ingo Molnar <mingo@redhat.com>,
Sami Tolvanen <samitolvanen@google.com>,
kernel-team@android.com, Hassan Naveed <hnaveed@wavecomp.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Ralph Campbell <rcampbell@nvidia.com>,
Kees Cook <keescook@chromium.org>,
minchan@google.com, Anshuman Khandual <anshuman.khandual@arm.com>,
Sandipan Das <sandipan@linux.ibm.com>,
John Hubbard <jhubbard@nvidia.com>,
Frederic Weisbecker <frederic@kernel.org>,
Mark Brown <broonie@kernel.org>, Borislav Petkov <bp@alien8.de>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
surenb@google.com, linux-arm-kernel@lists.infradead.org,
SeongJae Park <sjpark@amazon.de>,
linux-mm@kvack.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Mike Rapoport <rppt@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Mike Kravetz <mike.kravetz@oracle.com>
Subject: [PATCH v4 2/5] arm64: mremap speedup - Enable HAVE_MOVE_PMD
Date: Wed, 14 Oct 2020 00:53:07 +0000 [thread overview]
Message-ID: <20201014005320.2233162-3-kaleshsingh@google.com> (raw)
In-Reply-To: <20201014005320.2233162-1-kaleshsingh@google.com>
HAVE_MOVE_PMD enables remapping pages at the PMD level if both the
source and destination addresses are PMD-aligned.
HAVE_MOVE_PMD is already enabled on x86. The original patch [1] that
introduced this config did not enable it on arm64 at the time because
of performance issues with flushing the TLB on every PMD move. These
issues have since been addressed in more recent releases with
improvements to the arm64 TLB invalidation and core mmu_gather code as
Will Deacon mentioned in [2].
From the data below, it can be inferred that there is approximately
8x improvement in performance when HAVE_MOVE_PMD is enabled on arm64.
--------- Test Results ----------
The following results were obtained on an arm64 device running a 5.4
kernel, by remapping a PMD-aligned, 1GB sized region to a PMD-aligned
destination. The results from 10 iterations of the test are given below.
All times are in nanoseconds.
Control HAVE_MOVE_PMD
9220833 1247761
9002552 1219896
9254115 1094792
8725885 1227760
9308646 1043698
9001667 1101771
8793385 1159896
8774636 1143594
9553125 1025833
9374010 1078125
9100885.4 1134312.6 <-- Mean Time in nanoseconds
Total mremap time for a 1GB sized PMD-aligned region drops from
~9.1 milliseconds to ~1.1 milliseconds. (~8x speedup).
[1] https://lore.kernel.org/r/20181108181201.88826-3-joelaf@google.com
[2] https://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg140837.html
Signed-off-by: Kalesh Singh <kaleshsingh@google.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
Changes in v4:
- Add Kirill's Acked-by.
arch/arm64/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 4b136e923ccb..434d6791e869 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -123,6 +123,7 @@ config ARM64
select GENERIC_VDSO_TIME_NS
select HANDLE_DOMAIN_IRQ
select HARDIRQS_SW_RESEND
+ select HAVE_MOVE_PMD
select HAVE_PCI
select HAVE_ACPI_APEI if (ACPI && EFI)
select HAVE_ALIGNED_STRUCT_PAGE if SLUB
--
2.28.0.1011.ga647a8990f-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-14 0:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 0:53 [PATCH v4 0/5] Speed up mremap on large regions Kalesh Singh
2020-10-14 0:53 ` [PATCH v4 1/5] kselftests: vm: Add mremap tests Kalesh Singh
2020-10-14 19:02 ` Kalesh Singh
2020-10-14 0:53 ` Kalesh Singh [this message]
2020-10-15 10:55 ` [PATCH v4 2/5] arm64: mremap speedup - Enable HAVE_MOVE_PMD Will Deacon
2020-10-14 0:53 ` [PATCH v4 4/5] arm64: mremap speedup - Enable HAVE_MOVE_PUD Kalesh Singh
2020-10-14 0:53 ` [PATCH v4 5/5] x86: " Kalesh Singh
2020-10-14 15:53 ` Ingo Molnar
2020-10-15 20:40 ` [PATCH v4 0/5] Speed up mremap on large regions Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014005320.2233162-3-kaleshsingh@google.com \
--to=kaleshsingh@google.com \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=anshuman.khandual@arm.com \
--cc=arnd@arndb.de \
--cc=bgeffon@google.com \
--cc=bp@alien8.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=christian.brauner@ubuntu.com \
--cc=dave.hansen@intel.com \
--cc=frederic@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=gshan@redhat.com \
--cc=hnaveed@wavecomp.com \
--cc=hpa@zytor.com \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=joelaf@google.com \
--cc=jpoimboe@redhat.com \
--cc=justin.he@arm.com \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxram@us.ibm.com \
--cc=lokeshgidra@google.com \
--cc=masahiroy@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=minchan@google.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rcampbell@nvidia.com \
--cc=rppt@kernel.org \
--cc=samitolvanen@google.com \
--cc=sandipan@linux.ibm.com \
--cc=shuah@kernel.org \
--cc=sjpark@amazon.de \
--cc=steven.price@arm.com \
--cc=surenb@google.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).