From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E381CC43467 for ; Wed, 14 Oct 2020 13:43:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 710292076D for ; Wed, 14 Oct 2020 13:43:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="h6fdViaI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 710292076D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CEgfYy2Csbt6zywBJQ8gHtnhwpMWA22NyGOEWnRHeno=; b=h6fdViaIKMwU1RBVl/hwDpvAi /Bx49fBfN40xSWQ2px3WIzkjHvZTWWIFNEqtcdhymgJ5EFEOZyurIg61Wzg/tGbw1CgfdBVjX3T1A BZ596fHj3jlYHlhfcgcWgkf8wSsl73KcCNZYCdK1ugRC69eChKtD/LITJpflxpx4zHa2D3Z7AT7Va jSfHKGTTf+NxmDv+oSVDp4PTMauMm72HBcxITXSLZjrr5i9qSQQU5SgS15z9s4mf+rkoucMpG5rP7 7N/leATAw57dlOS4uxX41a8L8+XTq7mEpPj2eoX3J3eBpCnyI6aTauMyHrXb2xaZV10hXzeKyJaGq JLB44RwaQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSh2U-00078A-6V; Wed, 14 Oct 2020 13:41:58 +0000 Received: from mail-ot1-f66.google.com ([209.85.210.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSh2R-00077Z-Rk for linux-arm-kernel@lists.infradead.org; Wed, 14 Oct 2020 13:41:56 +0000 Received: by mail-ot1-f66.google.com with SMTP id n15so2339932otl.8 for ; Wed, 14 Oct 2020 06:41:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ODkuPdZmS51vjj18LfZxUJIoA3CbimjnhVaLrPWSbJ8=; b=lefIOWy7LwTlsKsorvO7U1We61KOJfUIpMbaHGKJaFCfykvbvP2UD58WNJ658sJ6x7 hu0dXwPO8cWPvTshSGAXuZFW2V24K/BnwKnnbdqMopzCTshpSwdF+GoH6KkZ9gZQEn71 KYxuHQa1iUDh+ebTYfp0EtePrZC00dN2elt6V4Wmx/JaeL0hnP+5ZgQQ8irnObGlmCXi p33ULzWx6h6iDDShconNVz0+7f2OHSBSBe2agPq9oZqC3x8jqipziqwqJfpFuzZZOGCH irxm4iPtShp/0LCj/Iuohmvu34Z7fJdZYNGOdkab7gNCFnD0/HbSSKfRMroenrS+64nO FVKA== X-Gm-Message-State: AOAM531D7QfvC0VJ6N9KcUgBVL+O9yQVlqiJPsA84wupG5I9pqqgSUS8 dUUL3YJI7jPmX3Y0dfdU1w== X-Google-Smtp-Source: ABdhPJx2mT4anlgAXwIFtYcquTufwd0maY1yyo9ARfmO4AejEUr6gWCV4FXd8hyjIW1aG2Mk1X+9LQ== X-Received: by 2002:a9d:8d2:: with SMTP id 76mr3388791otf.270.1602682913956; Wed, 14 Oct 2020 06:41:53 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id c64sm1009630otb.50.2020.10.14.06.41.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2020 06:41:53 -0700 (PDT) Received: (nullmailer pid 1562646 invoked by uid 1000); Wed, 14 Oct 2020 13:41:52 -0000 Date: Wed, 14 Oct 2020 08:41:52 -0500 From: Rob Herring To: Zhen Lei Subject: Re: [PATCH 3/6] spi: dt-bindings: spi-controller: explicitly require #address-cells=<0> for slave mode Message-ID: <20201014134152.GA1560405@bogus> References: <20201013160845.1772-1-thunder.leizhen@huawei.com> <20201013160845.1772-4-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201013160845.1772-4-thunder.leizhen@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_094155_902972_EC7C8A66 X-CRM114-Status: GOOD ( 14.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Lubomir Rintel , Lee Jones , linux-kernel , Rob Herring , linux-spi , Guenter Roeck , Mark Brown , Dan Murphy , Pavel Machek , Enric Balletbo i Serra , Benson Leung , linux-leds , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 14 Oct 2020 00:08:42 +0800, Zhen Lei wrote: > scripts/dtc/checks.c: > if (get_property(node, "spi-slave")) > spi_addr_cells = 0; > if (node_addr_cells(node) != spi_addr_cells) > FAIL(c, dti, node, "incorrect #address-cells for SPI bus"); > if (node_size_cells(node) != 0) > FAIL(c, dti, node, "incorrect #size-cells for SPI bus"); > > The above code in check_spi_bus_bridge() require that the number of address > cells must be 0. So we should explicitly declare "#address-cells = <0>". > > Signed-off-by: Zhen Lei > --- > .../devicetree/bindings/spi/spi-controller.yaml | 20 ++++++++++++++------ > 1 file changed, 14 insertions(+), 6 deletions(-) > Applied, thanks! Note that I tried fixing this in dtc, but that was rejected. So this gets the schema in sync with dtc. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel