From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27097C433DF for ; Wed, 14 Oct 2020 13:51:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85D6322201 for ; Wed, 14 Oct 2020 13:51:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AvVBvoyN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85D6322201 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=77cPm8qr563c9y/23oconxwsMoSoa8helTujuYASgRI=; b=AvVBvoyNtRhvQYuysBJVVoxXd VGoR0z9KUvDlNnZhtaRRVFio8/IIDP0iN8Jgtj4XmmIH1OblC+s4EhdsD31jpqoFQdr9P5tug4TyC XW0F8GMEZZWlmruOt8/zUYgzPHrdOi52T2pxpJeowyZjxMbt0y7CEW4Hwi+svG95irrZ0c+pbeaSj D7zM+yQ6OTHcAqIdiK/u3U1LJMHnNfzYIxJeld783+mWdOmyujJDAHvhGAeirDGuG7TARe0z2ivkF X0o+SS7y7fDtqw4suAMGuO9cUcijPNjuyp/wKdPAoFkaT95roB9ogqNqsIjKkP5dPL3UV0OrnD5Rc R+8Wz3klQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kShAd-0008SR-Lv; Wed, 14 Oct 2020 13:50:23 +0000 Received: from mail-oi1-f195.google.com ([209.85.167.195]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kShAb-0008Ry-6R for linux-arm-kernel@lists.infradead.org; Wed, 14 Oct 2020 13:50:22 +0000 Received: by mail-oi1-f195.google.com with SMTP id l85so3254527oih.10 for ; Wed, 14 Oct 2020 06:50:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=T+lXWYZNK3Q/86DTyObhFOK72+nQRALeWr13HjYTpkA=; b=tjzj9yCM7MRykzBcsZvja4SlU/VdsIwkzW2yARmy3UcU+LhjKVaKH2b16XxtofD/AV sxEhvhlgStXTHxrjGlw7bE0MOjGnWP+A5la+Isa2xyrZBvqc+xMCDnwzI5wr3RgTM4vV hu8QY6QTOLoA6IPx9Qu+nD9R0uY7/vRchL2RKJY9NIajeXEWF6V1ku7xdchifcgFTyPj 3O8nzwNzdebx13Z9T9vYrcX+Eaurw+yHcDkpOhFE2mCs92brVda+/dfJwCCxsl44mSQr eZlmjG2YD40N32sikZyNZudHNJdN6RxjdeYSIqi5Lvr0X6MiZ5dZwXaqKUo+gfFtBNfl jp0Q== X-Gm-Message-State: AOAM531Pu0PI0pSsNlDMapUKozxd9gwX5ipw7HE6aKDUexRqTB07TQ/4 9/bBcTrdFi3ygayWaBxDIQ== X-Google-Smtp-Source: ABdhPJwBwzjfoCwN+5C7fXVadoxI98n+WgVzrNbDfrKV3BDTP85OLoUwNnnp9bI2euXzw7/77YIU8Q== X-Received: by 2002:aca:54c2:: with SMTP id i185mr2099742oib.169.1602683420675; Wed, 14 Oct 2020 06:50:20 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id h5sm1211010otb.11.2020.10.14.06.50.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2020 06:50:19 -0700 (PDT) Received: (nullmailer pid 1576100 invoked by uid 1000); Wed, 14 Oct 2020 13:50:19 -0000 Date: Wed, 14 Oct 2020 08:50:19 -0500 From: Rob Herring To: "Leizhen (ThunderTown)" Subject: Re: [PATCH 6/6] dt-bindings: misc: correct the property name cmd-gpios to cmd-gpio Message-ID: <20201014135019.GA1563910@bogus> References: <20201013160845.1772-1-thunder.leizhen@huawei.com> <20201013160845.1772-7-thunder.leizhen@huawei.com> <4f5f9b55-9fad-9318-82d4-6b258643738b@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4f5f9b55-9fad-9318-82d4-6b258643738b@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_095021_578908_10FA5D38 X-CRM114-Status: GOOD ( 20.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel , devicetree , Lubomir Rintel , Lee Jones , linux-kernel , linux-spi , Guenter Roeck , Mark Brown , Dan Murphy , Pavel Machek , Enric Balletbo i Serra , Benson Leung , linux-leds Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 14, 2020 at 09:29:26AM +0800, Leizhen (ThunderTown) wrote: > = > = > On 2020/10/14 1:32, Dan Murphy wrote: > > Zhen > > = > > On 10/13/20 11:08 AM, Zhen Lei wrote: > >> The property name used in arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts is > >> cmd-gpio. > >> > >> arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:235: > >> cmd-gpio =3D <&gpio 155 GPIO_ACTIVE_HIGH>; > >> > >> Signed-off-by: Zhen Lei > >> --- > >> =A0 Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml | 6 +++= --- > >> =A0 1 file changed, 3 insertions(+), 3 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yam= l b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml > >> index b3c45c046ba5e37..c7a06a9650db2ed 100644 > >> --- a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml > >> +++ b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml > >> @@ -24,7 +24,7 @@ properties: > >> =A0=A0=A0 compatible: > >> =A0=A0=A0=A0=A0 const: olpc,xo1.75-ec > >> =A0 -=A0 cmd-gpios: > >> +=A0 cmd-gpio: > > = > > Preference is gpios not gpio. But Rob H accept or reject > = > Look at the search result below. It seems that the driver have not been m= erged into mainline. Yes, in drivers/platform/olpc/olpc-xo175-ec.c. Your mistake is the gpiod api takes just 'cmd' as the GPIO core handles = both forms. > But the property name is really used as cmd-gpio at mmp2-olpc-xo-1-75.dts= :235, I don't think > the mmp2-olpc-xo-1-75.dts can make a mistake. Otherwise, the driver will = not work properly. > Meanwhile, Both names cmd-gpios and cmd-gpio seem to be in use. But I pre= fer cmd-gpio, after > all, only one gpio is assigned now. The motorola,cmd-gpios add "s" becaus= e it contains 3 gpio. The preference is it is always '-gpios' just like it's always = 'interrupts' or 'clocks'. However, whether to change this is really up to the OLPC folks. Given = the driver has always supported both forms, it should be okay to change = the dts. Though there could be other users besides the kernel. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel