From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52799C433E7 for ; Wed, 14 Oct 2020 16:28:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4B7C20B1F for ; Wed, 14 Oct 2020 16:28:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Cz8avFtH"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="L+xCqI9G"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="Tcm1BnHk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4B7C20B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YopU7V1gKlU7tZb7ko0Z5zfBy1iEcf1ANF16ME/SYwE=; b=Cz8avFtHULgFflz5fHonjmZS9 NGCyKYxlqMdWtowM9UIPyUIelJ6bStgoItAg3Fyu6mKV9/dBt6v+ls846UWd1A00eL/MG6xS+zuT3 ZKKSZVFdIMZwOqTE3fZLIY7hECyBZDh9rBMwogRo/pTGaqkLrxBlK8xVq0x9gMvNxOeBAo8kq+41t aI3EDQi+ssbw88ksizXMQs0/rlfjZAoulpb3n0xQYVyPhk9zDgwKmTWkG+b9inNs4YjxALCLs0i+v dUkNGXU/UpyZo5VnLQtQ1+RyVZ+rhr0cIsH+dRklns4QG18Qg3vOHLdbayQ9CCR6FUp2occtQ6CSP l4NsRGZ6Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSjcZ-00086r-2L; Wed, 14 Oct 2020 16:27:23 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSjcU-00085A-L4 for linux-arm-kernel@lists.infradead.org; Wed, 14 Oct 2020 16:27:19 +0000 Date: Wed, 14 Oct 2020 18:27:14 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1602692836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iCzjYxqIDkmw4xzx1KXku7b0cbN/u38jxZbnzmQ3jN8=; b=L+xCqI9GxpRCoP8PngWCWAQ9wkdzpZ5WodbiV80p51AGMLkCWCgkkJouSD5NDTKKaAroqH bEi6bv6abvSonjh+1Y12R0IyATkDhSK/gIBIqmUccHFDatfo1IDsEiCXwj/KvxA6xcB969 +QvmLvKCGJH+ljJRLWshZ7jhABUTtdtr7oF3r534O+65KNP+5PElTQ4ZLtbTPMG9aD58PS cDKitk7SPcV0bjRsHW8LaycZTd7vJ45QOKO9ZwUrJBaHGZ0duR9einY6Sx9lu0AsA6t7MA d8RfzgrkXilE9GPgUHUD0YyBNnf1JF+Rhl06BFTBmLBY5d1iHAlG7C7OIEDXqQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1602692836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iCzjYxqIDkmw4xzx1KXku7b0cbN/u38jxZbnzmQ3jN8=; b=Tcm1BnHk6fiDiswRFgM+Nea81sLWNx1RNxoZwpZ/WAKUDTLpiU48x1RzsOa3CKc7I7gjpu NnAHKINmRZmU+DAw== From: Sebastian Andrzej Siewior To: Alan Stern Subject: Re: [patch 03/12] USB: serial: keyspan_pda: Consolidate room query Message-ID: <20201014162714.ctv5earlhwsp4iqs@linutronix.de> References: <20201014145215.518912759@linutronix.de> <20201014145727.338773481@linutronix.de> <20201014161433.GB712494@rowland.harvard.edu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201014161433.GB712494@rowland.harvard.edu> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_122718_784413_A20ADB09 X-CRM114-Status: UNSURE ( 9.07 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Thomas Winischhofer , Mathias Nyman , Peter Zijlstra , Greg Kroah-Hartman , linux-usb@vger.kernel.org, LKML , Krzysztof Kozlowski , Johan Hovold , linux-samsung-soc@vger.kernel.org, Kukjin Kim , Valentina Manea , Duncan Sands , "Ahmed S. Darwish" , Thomas Gleixner , linux-omap@vger.kernel.org, Shuah Khan , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-10-14 12:14:33 [-0400], Alan Stern wrote: > Instead, consider using the new usb_control_msg_recv() API. But it > might be better to allocate the buffer once and for all. This will still allocate and free buffer on each invocation. What about moving the query_buf to the begin of the struct / align it? > Alan Stern Sebastian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel