From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0E10C433E7 for ; Wed, 14 Oct 2020 16:28:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C31F20B1F for ; Wed, 14 Oct 2020 16:28:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1tfq54R1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C31F20B1F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zlzooOZWt1CjJ+1kC/zF+ensCU63vPrNynykHV5YgYM=; b=1tfq54R1q1wkp+O1Qs+EjPuOp d+mDGkmWGxGCMXvPQlyNvEn6kSh+5lnJfARv1d+GocDwypuj/WUuzYvoJCCP0IXLleo4rScucgPVb gfEczoKEGBmsOHe3EQdV5AyLgUIbMm2HPWjMKWg4LHjKZOPFo7CcNMGn4QtazmWCsYbxUjPnLMBgQ L1Oq6ywKpTDKgpeWq4C+/eHwWDV8s0kNWZBiLBcw0WNActghAw4h7ewzDdeb5j/NFRV9VmFYAuiQA zO7PyL1flA6HeLVB11xNQhXIDo71LcHPrC/GG8ftSe9VBmDKTopMAh5WqJUzvVYEMBHkYUpVE2bho 2hRrzSqoA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSjcg-0008Ab-2n; Wed, 14 Oct 2020 16:27:30 +0000 Received: from netrider.rowland.org ([192.131.102.5]) by merlin.infradead.org with smtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSjcY-000873-Gs for linux-arm-kernel@lists.infradead.org; Wed, 14 Oct 2020 16:27:24 +0000 Received: (qmail 719448 invoked by uid 1000); 14 Oct 2020 12:27:21 -0400 Date: Wed, 14 Oct 2020 12:27:21 -0400 From: Alan Stern To: Thomas Gleixner Subject: Re: [patch 11/12] usb: core: Replace in_interrupt() in comments Message-ID: <20201014162721.GE712494@rowland.harvard.edu> References: <20201014145215.518912759@linutronix.de> <20201014145728.318078828@linutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201014145728.318078828@linutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_122722_660445_ACFF5455 X-CRM114-Status: GOOD ( 23.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Thomas Winischhofer , Mathias Nyman , Peter Zijlstra , Greg Kroah-Hartman , Sebastian Andrzej Siewior , linux-usb@vger.kernel.org, LKML , Krzysztof Kozlowski , Johan Hovold , linux-samsung-soc@vger.kernel.org, Kukjin Kim , Valentina Manea , Duncan Sands , "Ahmed S. Darwish" , linux-omap@vger.kernel.org, Shuah Khan , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 14, 2020 at 04:52:26PM +0200, Thomas Gleixner wrote: > From: Ahmed S. Darwish > > The usage of in_interrupt() in drivers is phased out for various reasons. > > Various comments use !in_interrupt() to describe calling context for > functions which might sleep. That's wrong because the calling context has > to be preemptible task context, which is not what !in_interrupt() > describes. > > Replace !in_interrupt() with more accurate plain text descriptions. > > The comment for usb_hcd_poll_rh_status() is misleading as this function is > called from all kinds of contexts including preemptible task > context. Remove it as there is obviously no restriction. > > Signed-off-by: Ahmed S. Darwish > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Thomas Gleixner > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > > --- > --- a/drivers/usb/core/hcd.c > +++ b/drivers/usb/core/hcd.c > @@ -746,9 +746,6 @@ static int rh_call_control (struct usb_h > * Root Hub interrupt transfers are polled using a timer if the > * driver requests it; otherwise the driver is responsible for > * calling usb_hcd_poll_rh_status() when an event occurs. > - * > - * Completions are called in_interrupt(), but they may or may not > - * be in_irq(). This comment should not be removed; instead it should be changed to say that completion handlers are called with interrupts disabled. > @@ -1691,7 +1690,6 @@ static void usb_giveback_urb_bh(unsigned > * @hcd: host controller returning the URB > * @urb: urb being returned to the USB device driver. > * @status: completion status code for the URB. > - * Context: in_interrupt() The comment should be changed to say that the routine runs in a BH handler (or however you want to express it). > --- a/drivers/usb/core/message.c > +++ b/drivers/usb/core/message.c > @@ -934,7 +939,7 @@ int usb_get_device_descriptor(struct usb > /* > * usb_set_isoch_delay - informs the device of the packet transmit delay > * @dev: the device whose delay is to be informed > - * Context: !in_interrupt() > + * Context: can sleep Why is this comment different from all the others? Alan Stern _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel